From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Indentation of def* Date: Wed, 20 Oct 2021 09:52:10 +0200 Message-ID: <87v91s876d.fsf@gnus.org> References: <878ryw1ptl.fsf@gnus.org> <87czo2lq0d.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14967"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Richard Stallman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 20 09:52:53 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1md6P5-0003do-VL for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Oct 2021 09:52:52 +0200 Original-Received: from localhost ([::1]:52752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1md6P4-0000MX-8s for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Oct 2021 03:52:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1md6OW-000892-Ps for emacs-devel@gnu.org; Wed, 20 Oct 2021 03:52:16 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:33928) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1md6OV-0005aX-8l; Wed, 20 Oct 2021 03:52:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sS1iTb+s68+A55susUeBEnXWEgRpLoCzy6Z4QDT8d5Q=; b=LG/TGa5NGPl3uiJT1VohimvaYU HYhpC1pq09/NT61fJmBztisHEj//EojxbK9ejjxguBXXlRmxRs1svk+9tkY1bK7VsqhpcKBRZ5kGg o3ZVWqLxAQTZF8S6ytc1G3ri210ICKMgFD1DVled38icVZm/7DEm0exuM7fGhH3ff3jI=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1md6OR-0005fp-8g; Wed, 20 Oct 2021 09:52:13 +0200 X-Now-Playing: case-lang-veirs's _case-lang-veirs_: "I Want To Be Here" In-Reply-To: (Richard Stallman's message of "Wed, 20 Oct 2021 02:47:01 -0400") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277427 Archived-At: Richard Stallman writes: > Please keep the heuristic. It is still useful. > > If file A uses a deffoober construct defined in file B, and you visit > file A with file B not loaded, the heuristic will make the uses of > deffoober indent properly. Or wrongly -- functions like `default-boundp' are indented wrongly using that heuristic. > The idea of this was that if you define something whose name starts > with `def', it should be a defining construct. If people don't follow > that convention, that's a mistake. They don't follow that convention. > Giving those macros explicit indentation properties is ok. With that > done, the heuristic is no longer needed when their definitions are loaded. > > But I think we should still use the heuristic for any def... construct > whose definition is not currenly loaded. I don't see what makes these macros special. You have the same problem with macros like `with-*' and `when-let' -- these also indent wrongly if you haven't loaded their definitions. The moral is: If you edit Emacs Lisp, you should load the file you're editing first, otherwise it'll indent badly. We've plastered over this "problem" for the def* macros only, but there's so many other macros that also need special indentation that handling def* macros specially is a disservice to everybody. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no