unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Add xwidget-webkit-isearch-yank-kill
Date: Thu, 11 Nov 2021 08:28:53 +0800	[thread overview]
Message-ID: <87v90z358a.fsf@yahoo.com> (raw)
In-Reply-To: <83zgqc2jry.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 10 Nov 2021 16:00:01 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

Apologies for pushing the patch in haste.  This will not happen again.

>> * lisp/xwidget.el: Bind C-y to xwidget-webkit-yank-kill in incremental

> This line is too long.  We produce ChangeLog from the Git log, where
> each entry has a TAB before it.  So each line in the commit log
> message should not be longer than 66 characters, because ChangeLog
> entries wrap at column 74.

Oops, sorry.  I assumed that M-q in a *vc-log* buffer would fill these
entries correctly, but I guess I'm wrong.

>> +(defun xwidget-webkit-isearch-yank-kill ()
>> +  "Pull string from kill ring and append it to the current query."
>            ^^^^^^
> Which string?  I think you mean the most recent kill, don't you?

Yes, what would you suggest I change it to?



  reply	other threads:[~2021-11-11  0:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <878rxw71v0.fsf.ref@yahoo.com>
2021-11-10 10:15 ` Add xwidget-webkit-isearch-yank-kill Po Lu
2021-11-10 11:43   ` Po Lu
2021-11-10 11:45     ` Lars Ingebrigtsen
2021-11-10 11:46       ` Po Lu
2021-11-10 14:03     ` Eli Zaretskii
2021-11-10 14:00   ` Eli Zaretskii
2021-11-11  0:28     ` Po Lu [this message]
2021-11-11  6:53       ` Eli Zaretskii
2021-11-11  6:55         ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v90z358a.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).