From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: Correct byte compiler error/warning positions. The solution! Date: Mon, 29 Nov 2021 14:24:47 +0100 Message-ID: <87v90b5c2o.fsf@gmail.com> References: <83pmqm16vz.fsf@gnu.org> <8335nh29pt.fsf@gnu.org> <83wnktzxb2.fsf@gnu.org> <83ilwcyc6o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28409"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 29 14:37:15 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mrgqI-0007CY-Ug for ged-emacs-devel@m.gmane-mx.org; Mon, 29 Nov 2021 14:37:14 +0100 Original-Received: from localhost ([::1]:46214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrgqH-00066c-US for ged-emacs-devel@m.gmane-mx.org; Mon, 29 Nov 2021 08:37:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrgeU-00008B-Vr for emacs-devel@gnu.org; Mon, 29 Nov 2021 08:25:03 -0500 Original-Received: from [2a00:1450:4864:20::32a] (port=36378 helo=mail-wm1-x32a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrgeK-0006lD-Il; Mon, 29 Nov 2021 08:24:54 -0500 Original-Received: by mail-wm1-x32a.google.com with SMTP id i8-20020a7bc948000000b0030db7b70b6bso16806576wml.1; Mon, 29 Nov 2021 05:24:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=fNG9cs2rfC96t9QqJFRNiDe46FTfAVdJB374ZW0W9s4=; b=FayixAkRDdciixBNDlNOH5DB9UZyS+tevWrrfB5NIumw99vwRfNqlX26KTnN1jr/pC dqz4frocTYugOj4dsE4HsuN7A85SkCV4W0Zwu3sxR7RjmE8alau66Rxvzt5106IAXTit 5MLASbV+JAYnMORxoXFOZnVq4iBVN4BwHlXzLA7vcw+q9+EGU5ChTbp/g8PBmMBBbsle YIPbIZ8lHqUL/fnJ0exdXKswySTYvKUatsA4FyYXF2NUwVi2umrOouMHPG/q83r9rfG2 NyidZZx8y07Os+QIUcD0RGDbKKNGad6PPs2I343oWoIX4bq+Zu2CPueiWHjezyMsA3K7 Z5KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=fNG9cs2rfC96t9QqJFRNiDe46FTfAVdJB374ZW0W9s4=; b=KItztpz1YZs7gqsJm4OgEooM5OuA6Fr9eRhsSsOLTqL7KKIFs8BggF1IjVkXy3tunc 7ee+x7hA8QfEDkvIys6SwpWSZ8+mUJMYX/v4YOJROB8F2t+YE8HUMiEYFqmd3CyHlY77 McUl1BsERv2wVVSiqeI8lko0cFIj75Q7Jm8WiqaA5kryhQEWbixz1wcQamSAMA/KJ8zH mC/THW/eourGV9dYhW1EZ6k5sWjx4Hl6wimC/xv0VjHaoLXBgPDJeS1guIRxL+LuUuPt ZhxLHDoKWVxieF8Q+XRnazMAp6MvVPKoVDXxyN7OHcVBM+CzJSE9pBVLXoc+fixMxosl wKGQ== X-Gm-Message-State: AOAM531b3fgxNv0+mAqMhQj0JCoMd754LqK2AcJVfxv+ENuHRwb+VmbG D/e1CHdrUYHoZUBe5qqJ/C0UXA76h44= X-Google-Smtp-Source: ABdhPJy+7lnEpYtPom4KxdMGCmO+FLRbMiz0eiU8WDKkh7wPzCSe77DE5ew6wbONWcnYYZVXcLwU8A== X-Received: by 2002:a1c:9842:: with SMTP id a63mr36598240wme.102.1638192289829; Mon, 29 Nov 2021 05:24:49 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb50:452b:223a:73d6:af90]) by smtp.gmail.com with ESMTPSA id o12sm15066536wmq.12.2021.11.29.05.24.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 05:24:48 -0800 (PST) Gmane-Reply-To-List: yes In-Reply-To: (Alan Mackenzie's message of "Mon, 29 Nov 2021 11:50:19 +0000") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::32a (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280470 Archived-At: >>>>> On Mon, 29 Nov 2021 11:50:19 +0000, Alan Mackenzie said: Alan> Anyhow, I've committed the current state in the new branch Alan> scratch/correct-warning-pos. It should build and run OK, althoug= h I Alan> haven't tried it out with native compilation, yet. It is margina= lly Alan> slower than master. Maybe we can merge it into master some time = for Alan> Emacs 29. "Thou shalt listen to Eli's warnings about '=3D=3D', else your branch shall not compile" ./configure --enable-check-lisp-object-type --enable-checking make[1]: Entering directory '/home/rpluim/repos/emacs-pos/src' CC dispnew.o In file included from dispnew.c:27: lisp.h: In function =E2=80=98EQ=E2=80=99: lisp.h:385:40: error: invalid operands to binary =3D=3D (have =E2=80=98Lisp= _Object=E2=80=99 and =E2=80=98Lisp_Object=E2=80=99) 385 | ? (XSYMBOL_WITH_POS((x)))->sym =3D=3D (y) \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~ | | | Lisp_Object lisp.h:1329:10: note: in expansion of macro =E2=80=98lisp_h_EQ=E2=80=99 1329 | return lisp_h_EQ (x, y); | ^~~~~~~~~ lisp.h:388:15: error: invalid operands to binary =3D=3D (have =E2=80=98Lisp= _Object=E2=80=99 and =E2=80=98Lisp_Object=E2=80=99) 387 | && ((XSYMBOL_WITH_POS((x)))->sym \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | Lisp_Object 388 | =3D=3D (XSYMBOL_WITH_POS((y)))->sym) \ | ^~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | Lisp_Object lisp.h:1329:10: note: in expansion of macro =E2=80=98lisp_h_EQ=E2=80=99 1329 | return lisp_h_EQ (x, y); | ^~~~~~~~~ lisp.h:391:18: error: invalid operands to binary =3D=3D (have =E2=80=98Lisp= _Object=E2=80=99 and =E2=80=98Lisp_Object=E2=80=99) 391 | && ((x) =3D=3D ((XSYMBOL_WITH_POS ((y)))->sym)))))) | ^~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | Lisp_Object lisp.h:1329:10: note: in expansion of macro =E2=80=98lisp_h_EQ=E2=80=99 1329 | return lisp_h_EQ (x, y); | ^~~~~~~~~ In file included from dispnew.c:27: lisp.h:1330:1: warning: control reaches end of non-void function [-Wreturn-= type] 1330 | } | ^ make[1]: *** [Makefile:406: dispnew.o] Error 1 Robert --=20