From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: Emacs pretest 28.0.90 is out Date: Thu, 09 Dec 2021 20:49:27 +0800 Message-ID: <87v8zy9c4o.fsf@yahoo.com> References: <83zgpf2mdr.fsf@gnu.org> <87fsr6pn9r.fsf@yahoo.com> <834k7l3nko.fsf@gnu.org> <87o85tlv9o.fsf@yahoo.com> <87a6hdlukl.fsf@yahoo.com> <83pmq925hc.fsf@gnu.org> <87tufljldf.fsf@yahoo.com> <87pmq9jh21.fsf@yahoo.com> <83k0ggzg6v.fsf@gnu.org> <87r1angb8d.fsf@yahoo.com> <838rwvxofc.fsf@gnu.org> <877dcfdy7a.fsf@yahoo.com> <83mtlbw75d.fsf@gnu.org> <8735n2cyui.fsf@yahoo.com> <83k0geuoi1.fsf@gnu.org> <87czm6ax3c.fsf@yahoo.com> <838rwuukkx.fsf@gnu.org> <878rwuavr7.fsf@yahoo.com> <831r2mug6n.fsf@gnu.org> <83zgpat0di.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39309"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 09 13:52:10 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mvIu9-0009xt-Sn for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Dec 2021 13:52:09 +0100 Original-Received: from localhost ([::1]:44260 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mvIu8-00013l-Dd for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Dec 2021 07:52:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvIrm-0007qK-Hk for emacs-devel@gnu.org; Thu, 09 Dec 2021 07:49:42 -0500 Original-Received: from sonic314-20.consmr.mail.ne1.yahoo.com ([66.163.189.146]:34638) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mvIrk-0003OT-Ku for emacs-devel@gnu.org; Thu, 09 Dec 2021 07:49:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1639054178; bh=IImOgNKk7QJvqRREbVbtfg+DIxR8V7HwQQeEilVyh6Q=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=HDYjx/X+6uHUaQsnjqN9wrJNrbccy3g2S+uNQVdzCLOrcXFHQCdnaTIS5rwZoDsba9j779Xt+gTNLkZM/GDUatYxdXIJhGwMH4EeNgLkJ2/6Q/bhvl0rGoGCY+TpeZi/ZC5WmwaT/b+VeBdp/mPkuJkeXia/8/9gcbohMWDRL3wzozKeJlPv7uA6pcRmw9T1MW8JnbEyLnhVllK3hB9tPBI0ZpylUP5Pcm9NXihkfe9fineyvVapWi03DEuyKg3WgjE6/JDdEvm8RALcnc1XOEkAXqnMEZXM6JoCnXR9OkwNSqn0OvDrdQyXGJY0QxUEvmIxvhepqyKkHDGnxSzQqQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1639054178; bh=fmger2YCrBBWTX3jVP/yDPVPMFp8WjiIoEpCaKjreVP=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=cnKpIXdVSsHcxey888El+FJIOznMTPOlga98G429S07S3LavhilvOnWF1XQNzpPmckjaeBo7QO3W2mqzlZETNxW4vCv+2eZct6O12z7jUkADQSYNirRvcBUc4kiEPiyFEeXywa9GOSUDLzeSyRQRhd+rLkCAz8wK4Nus4VqHUXSxAmo+2yqsI+v3xoF7aiCbMb92QCVvDbkzcn2W884mXekjhLnCNZWhMvcFPIdB5RxyYYkCEDN80moW/fBYkmlkM2yZOmXyAXO0EHF9c/cG/ZcBbrfDfD5R3iVajnc2PPzhwyDZKOHKpXEJi6NPoCYKQgCCSuGMz0q8aS4AUXZROA== X-YMail-OSG: 0BHrHZMVM1lX6k6.3HaJl5OAGPndhU.ExhgLMC09ZsVD8KVzbFtaziQdMIVYwLi lLqG8AQPXc03XdKw_UqQOuWpgsZXtL89KkNnbsPuwqPN1sqOXH50f9mYK32TJ57_UM0TyANq7GPQ Zbkmic_bFnTr3_6oHRYbjgKEyfvX5A6QUBVbQHg2Es2VRMD_agt2ySv7AgOyc3_tHSgqu2CQCpGS fXzCk38OCagM5FEHx8rSGSxa6zr0SJSGJbQKerJeo.1XSONNhbh1GwchVlPaCFFDpxq8Rqzkl9uj UIJbJUwBryr7kCSk75Vv_KorspDypHCqqW2j20vedkR7pGTlvSYaztIjaJCABendQfS9pmFS96qD rOy7GYrnft7R9ddI__K2VBaqZKeWZii.MaDsN8xdZDbrtNhCVS5LAXrLTojcV5HglyCW6fJg9DJA Uz7VeP5HG7kpRmID3f7iavJxTmw9LUANBV2Cf3hAEaUfVqJGKrm4cDfiVheo.T7JN2QSiVcdISIw F4Qfi0oEPzc4zlI3ZulnM5edWTj3UPfmplj1PzuzUK6O0LOFZJCc_Gb11hLl6Wc5n.qCtU9NCzkx ixkyDX5kx9NhD7ToKGrahQKKQElR079qvgHhjug6P0JO6Mr0rJz0BXBZNwmUZk.oDS1Rl0sUk2PS e2kmViIZcjbjdW3hUvIcdS1HEBTQiYmj0TTCoypb9fhCdIj_3DpqkvtwX.csbi_0Z1Zm9H8TTq_7 kB506ertmDEULSrklC_AAuHignqEoPVUpBQl5Q9vgTE2qt0Bxi2NIUMk9Q.n2iXVHpBEe1y7hpe3 9Sx9G3OMymn0XyiCy8R9gHK3HR1AlLVjbA5XSgXuN1 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ne1.yahoo.com with HTTP; Thu, 9 Dec 2021 12:49:38 +0000 Original-Received: by kubenode513.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 0711aaab6e857f76bf869c963a6ef9b4; Thu, 09 Dec 2021 12:49:34 +0000 (UTC) In-Reply-To: <83zgpat0di.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 09 Dec 2021 14:43:05 +0200") X-Mailer: WebService/1.1.19415 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.189.146; envelope-from=luangruo@yahoo.com; helo=sonic314-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281489 Archived-At: Eli Zaretskii writes: >> Date: Thu, 09 Dec 2021 14:16:16 +0200 >> From: Eli Zaretskii >> Cc: emacs-devel@gnu.org >> >> > After implementing the missing functions, the linker complained about >> > duplicate copies of mktime, one in libc.a, and the other in gnulib's >> > mktime module >> >> If we have mktime from Gnulib, then why does linker pull mktime from >> libc.a as well? It's supposed to be satisfied by the first function >> by that name that it sees in any library it links in. > > I think I know the answer: it's because we use localtime, which DJGPP > defines on the same source file as mktime. > > I see that in the Emacs 26.2 build, the function mktime in Gnulib's > mktime.c module was renamed to rpl_mktime, which is how the duplicate > definition problem was resolved. The current Gnulib's mktime.c module > still allows that (search mktime.c for "rpl"), so all you need to do > is arrange for the relevant cpp macro to be defined. This is supposed > to be done by sed2v2.inp, so I guess it is somehow not working now? It seems that `REPLACE_MKTIME' is 0 in gnulib.mk. I see the issue now, thanks!