unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: LdBeth <andpuke@foxmail.com>
Cc: Eric Abrahamsen <eric@ericabrahamsen.net>,
	Emacs Devel <emacs-devel@gnu.org>
Subject: Re: [PATCH] Gnus; Restore multi encoding support for NNTP
Date: Mon, 03 Jan 2022 12:18:31 +0100	[thread overview]
Message-ID: <87v8z13w54.fsf@gnus.org> (raw)
In-Reply-To: <tencent_2FBAB51CDD7A4430727412AC40FEFEDDD609@qq.com> (LdBeth's message of "Sat, 01 Jan 2022 11:32:19 +0800")

LdBeth <andpuke@foxmail.com> writes:

> +  (let ((pos (text-property-not-all 0 (length string) 'charset nil string)))
> +    (if pos (encode-coding-string string (get-text-property pos 'charset string))
> +      string)))

Like I said before, I'm not really very enthusiastic about stashing this
data in the text properties -- it's quite likely that there are packages
or functions of there that'll do various transforms on the group names,
and the text properties may be lost.  If this data has to be stored
non-ephemerally, then storing it in the group parameter list, for
instance, would be less brittle.

> @@ -472,7 +472,7 @@ gnus-request-compact-group
>  	 (result
>  	  (funcall (gnus-get-function gnus-command-method
>  				      'request-compact-group)
> -		   (gnus-group-real-name group)
> +		   (gnus-group-real-name (gnus-group-encoded-name group))
>  		   (nth 1 gnus-command-method) t)))
>      result))

(etc.)  And I'm not sure about giving the backends the encoded names --
that's a major change in behaviour, and has to end up causing problems
somewhere (for instance, in nnimap which is encoded to utf-7, and would
be double-encoded if there's a `charset' text property on the group
name).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  reply	other threads:[~2022-01-03 11:18 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-27  9:42 Gnus; Restore multi encoding support for NNTP LdBeth
2021-12-27 12:11 ` Lars Ingebrigtsen
2021-12-27 12:41   ` LdBeth
2021-12-27 12:57     ` Lars Ingebrigtsen
2021-12-27 13:58       ` LdBeth
2021-12-28  3:17         ` Eric Abrahamsen
2021-12-28 14:31           ` Lars Ingebrigtsen
2021-12-28 15:40             ` LdBeth
2021-12-28 14:29         ` Lars Ingebrigtsen
2021-12-28 15:43           ` LdBeth
2021-12-30 10:23         ` [PATCH] " LdBeth
2021-12-30 14:49           ` Lars Ingebrigtsen
2021-12-30 14:54             ` Eli Zaretskii
2021-12-30 15:18             ` LdBeth
2021-12-31 15:59               ` Lars Ingebrigtsen
2022-01-01  2:11                 ` LdBeth
2022-01-01  3:32                   ` LdBeth
2022-01-03 11:18                     ` Lars Ingebrigtsen [this message]
2022-01-03 11:25                       ` Lars Ingebrigtsen
2022-01-03 14:00                       ` LdBeth
2022-01-01  6:58                   ` Eli Zaretskii
2022-01-01  8:34                     ` LdBeth
2022-01-01  8:56                       ` Eli Zaretskii
2022-01-01  9:26                         ` LdBeth
2022-01-01  9:35                           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8z13w54.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=andpuke@foxmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=eric@ericabrahamsen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).