unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Tassilo Horn <tsdh@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Patch/Question] Likely bugs in mailcap docs and mailcap-view-file
Date: Sat, 15 Jan 2022 11:27:30 +0100	[thread overview]
Message-ID: <87v8yljnbs.fsf@gnu.org> (raw)
In-Reply-To: <jwv7db2lzk1.fsf-monnier+emacs@gnu.org>

Stefan Monnier <monnier@iro.umontreal.ca> writes:

Hi Stefan,

>> So I propose the attached patch which teaches `mailcap-view-file' the
>> symbol/function-valued viewer case and adjust the docs to match
>> what's already there.
> [...]
>> Does anyone see a problem with that?  I'm not very familiar with that
>> code.
>
> I'm not familiar either, but it looks OK.

Alright, thanks for checking.  Pushed!

> Any chance you could be convinced to throw in some regression test?

Of course.  I think I can write some tests that the viewer selection
procedure works as intended.  Is that what you have in mind?

Wrt. the changed function: I'm not exactly sure how I would test that.
I can probably test that the right viewer function is selected and run
on the right buffer but would skip the display stuff, i.e., that the
generated buffer is visible in some window.

Bye,
Tassilo



  reply	other threads:[~2022-01-15 10:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-14 21:24 [Patch/Question] Likely bugs in mailcap docs and mailcap-view-file Tassilo Horn
2022-01-14 22:32 ` Stefan Monnier
2022-01-15 10:27   ` Tassilo Horn [this message]
2022-01-15 14:52     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8yljnbs.fsf@gnu.org \
    --to=tsdh@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).