From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix bookmark-bmenu-list sorting. Date: Thu, 03 Mar 2022 11:41:55 -0600 Message-ID: <87v8wvkk64.fsf@red-bean.com> References: <875yovm1m6.fsf@elite.giraud> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15253"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel To: Manuel Giraud Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 03 18:43:18 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nPpTy-0003kg-4A for ged-emacs-devel@m.gmane-mx.org; Thu, 03 Mar 2022 18:43:18 +0100 Original-Received: from localhost ([::1]:52612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nPpTx-0006Nm-3G for ged-emacs-devel@m.gmane-mx.org; Thu, 03 Mar 2022 12:43:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPpSi-0004yv-GD for emacs-devel@gnu.org; Thu, 03 Mar 2022 12:42:02 -0500 Original-Received: from sanpietro.red-bean.com ([45.79.25.59]:43840) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPpSg-00033p-Im for emacs-devel@gnu.org; Thu, 03 Mar 2022 12:42:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:Reply-To:References:Subject:Cc:To:From:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=alHYU4WurtkwShgSd7bA5ocYnLF0yujaOYF5/Bg53Go=; t=1646329317; x=1647538917; b=HGM7YygL1VAR6+O4eluh+9+TAvW+4R8y2Nl7PM8+8KauWwG2exusEbCwiLitXaMEdEPrqdNpPFQ DEOmqb3BWzhTu7vtAU00Rex0t+09Yk80x8H5vfd0G7vBRVVF2pE/TB7GABQ8DILaqNIjZbEMB4VPu PlWAgYJZ93PgUK61tcysgkbHrfR42+O+Ex4tFv/mmu7HItejaYrlA8OgNnHLNhQN4X+gg5zMNPCIY tFsMt1CY1ZkJDzQt/8y7hc9a/uJfRDwiwkm+QUC+it6G/XKbXRBUnOuo27nEcKX+fKCtTgWXpHnuy Nhov0/RRBxcryFQQE66XbY2KLZ0AJaXOJ2rQ==; Original-Received: from [12.106.183.66] (port=30662 helo=hummy) by sanpietro.red-bean.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nPpSc-00C75m-Vx; Thu, 03 Mar 2022 17:41:56 +0000 In-Reply-To: <875yovm1m6.fsf@elite.giraud> (Manuel Giraud's message of "Thu, 03 Mar 2022 17:39:45 +0100") Received-SPF: pass client-ip=45.79.25.59; envelope-from=kfogel@red-bean.com; helo=sanpietro.red-bean.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286792 Archived-At: On 03 Mar 2022, Manuel Giraud wrote: >Here is a patch that I think fix the default >`bookmark-bmenu-list' >sorting when `bookmark-sort-flag' is nil. This looks correct to me. Thank you for the fix. I'm testing it now on 'emacs-28' and 'master' (it should behave the same on both, of course, but might as well make sure). Assuming it behaves as expected, I'll apply using 'git patch' on the emacs-28 branch. Best regards, -Karl