From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: PGTK-related misconceptions Date: Wed, 20 Apr 2022 16:25:11 +0800 Message-ID: <87v8v4b1qw.fsf@yahoo.com> References: <87bkww9ooc.fsf@treypeacock.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31235"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Morgan Smith , emacs-devel@gnu.org To: Trey Peacock Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 20 10:44:43 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nh5x4-0007uk-S3 for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Apr 2022 10:44:42 +0200 Original-Received: from localhost ([::1]:41672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nh5x3-0008Vb-9y for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Apr 2022 04:44:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35108) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nh5eO-00056B-Ms for emacs-devel@gnu.org; Wed, 20 Apr 2022 04:25:24 -0400 Original-Received: from sonic316-22.consmr.mail.ne1.yahoo.com ([66.163.187.148]:40981) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nh5eM-000407-IG for emacs-devel@gnu.org; Wed, 20 Apr 2022 04:25:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1650443120; bh=6d8X5ceXgdImzV/FB+JpZzD0DQEa60ZWCYABwhX5Avw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=XrGy0/dz0FHSRAIuZzT9lnsKmu8so3JGV3e+h1qBqKjsMYxnlR1hz4KtLmajv8nrdyviPm9v65UEBRp7Levbpz/FyZDHhV6I48wOPrQH62ZlsiG4zYvukHINdzPtcXeXrwM8pMP+vTH3ELzVYNowb92hO3DlLgCv8xW4q3uDirTpBg4fTmEa5lufgHK6uplZ/2V2pM4FLrGMpqRhfqKJI9oD09GCRAD1dd31ZZt40M5omve78yOlkvr9hYWOW48FaKbFyhwcJuzUU5kjYEmU5XLjG7mjavhX40xHWP0mufeynzsUkw4U0fyYvCk1IM+taECWAield61Cplv5zc99tw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1650443120; bh=xYvUVuAxm5URzggF1uHCdAL31HNgY9oCdXbS9/aj6M7=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=HrguxMdbywPhIzfI2iyFLqGOCaCc/iH0GrjqQB5a1RDi4Fc3FWR5g9tq7aBb76BuQay8dibcXpq7Vde490H+gpsEsgTeWup09xaJvcm9WkyOaveuLl8DdzfNRLZhrBfEU8sRS4t+4TzoFy/mu672Cwa6Och95dLF7SVtKl4p4yPeVXAyqf/zvJ4hvQ/hhi7sbqy8mjJEHVEkE0+yJa1jG89s/wiB1G8/VXQEd1nxjjo2zcMcLqwro4BhyaFrXd27ZVGKeRGzK0OvSKerug0NSVGBwo2iE4GPR7iXAEdlTFAtH1RDrYuVsjW8Q0unw39pCfc9BMHTF4o2V/2GbaU75w== X-YMail-OSG: OiJpdRUVM1lelaFEd2QMkXZk5PsHGYQkGhGgvUwIlMlwdO3rdscGRMe21njSy.g aRp7.prlPffMq6Y2YQp.Zq6p_SxNre2ntLBV41.uDdPyLBGEk_kodbFUF0jwYE5d6.xq.0yQDFkh tZprwUi_DEfZGj8UbTl3cg2i1fFBcZJqznSLK5XMyTiDPz3etq44fof4hDbF.CTwDPoojBTDBaL1 Vs0YU0hx9p3ulTO2ndm7dw.vabkGTqkFpK4wEJuv0ZRbDTN67acl9wtqPqck0vrxJoQ2SCyk0KSP K9._vSl1rMHju7p2YQqFY9IFZu86JDx2eUBGLiKb.op7wzsVM.n7sAEe9aJE.K46XmPkPkd.XP1V .FP5rHAtQqJxIatvJ2PNdBpCS2XrCJpWWEetPfFboafK6rd26kdEFapcnBmZ32QdznkOl2BEmz4b s4VBy8VoZxyHk.wX4d6pSNW0PI0HIFPrwXJ3lB.ZahqxPZUrc90.lFengfDHyRJfashh.b0XYE4C LA.GBNDq8Yj6c2qx.BT1mCCkxodRg1TSq6dSKNjXmCaDGktccOh3tjQWBerYqRVS4znjoatG92jo G2wkwCKq8N1LdLIjU8uU6lmWV6t9POtCIe8zIkbGbMRFLX43Ljt.WyTSmB3Bn2l8ztngioknR0kD Wt.qz5E42g3RabFAldNDkhVIq.kcYm.OQKOBSOuWzIYIBRnNTpv3Mu_ShrOSsbeT_eGis90kwWnf 7gNF5bW.kAX0JkDaMxyYHs8W_XNDjNrb1whq.slNu1HE1WwCIn.qQQSvTPv0f4o6ZpkdQJ0Mi_OO pO.GFxeRle6z83a0bW7x4CZNBgn.TivJjv8RJQvbvF X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Wed, 20 Apr 2022 08:25:20 +0000 Original-Received: by hermes--canary-production-sg3-6589f79784-hgzmb (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 036f6d85216b30cb2ab195213f8d2f13; Wed, 20 Apr 2022 08:25:17 +0000 (UTC) In-Reply-To: <87bkww9ooc.fsf@treypeacock.com> (Trey Peacock's message of "Wed, 20 Apr 2022 07:52:56 +0000") X-Mailer: WebService/1.1.20048 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.187.148; envelope-from=luangruo@yahoo.com; helo=sonic316-22.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288703 Archived-At: Trey Peacock writes: > You have already changed Emacs from accepting both MOD4 and SUPER_MASK > as its Super key modifiers to only accepting SUPER_MASK. I imagine > this response is born of more than just this issue but I would not let > it cloud an easy solution. First of all, the GDK_MODN_MASKs (aside from GDK_MOD1_MASK) are simply not set on Broadway, the other GDK backend that we try to support. Secondly, nothing is guaranteed about the behavior of the real modifier masks after GDK_MOD1_MASK. We cannot assume it means Super at all, since it is not documented to mean that. What if GDK changes its meaning in the future? Or the Wayland compositor developers? I am not going to settle for non-solutions (or half-solutions) like what you proposed, at least unless the GTK developers still haven't fixed this by the time Emacs 29.1 is released. > GTK 3.24.33 still accepts Mod2-5 masks, recognizes them separately > from the virtual modifier masks, and unlike the x11 implementation > does not contain the logic to set convert Super_L or Super_R to > GDK_SUPER_MASK. So what you have done is actually held Emacs to GDK's > x11 implementation and documentation rather than looking at the code > itself. Nowhere in the documentation for GdkModifierType does it say that the automatic mapping from real modifiers to virtual modifiers is X11-specific, so this is clearly a GTK bug. I'm pretty sure GTK accelerators that specify as a modifier will not work on those other Wayland compositors either, if what you say is true. > If the PGTK branch is meant for "alternative window systems available > on GNU/Linux and some Unix systems, such as Wayland" then I do think > there should be more consideration taken compositors that do not share > Mutter's workaround. Had you been using any other compositor, surely > you would not have made this change. Perhaps even filing a bug > yourself. I would still have made this change and then proceeded to ask someone else to report a GTK bug. I can't do that myself, since GNOME has been persistently been making it more and more difficult to report bugs without registering an account on whatever platform they currently use for bug reports, and putting up with the associated e-mail spam. But I don't use any other Wayland compositors, so that point is moot.