From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 91418d27e9: Add new functions for computing character metrics for windows Date: Fri, 29 Apr 2022 15:53:48 +0200 Message-ID: <87v8usc7wz.fsf@gnus.org> References: <165123811050.20687.5215165731843845332@vcs2.savannah.gnu.org> <20220429131511.9BD62C01683@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14112"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Titus von der Malsburg , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 29 15:56:16 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nkR6T-0003Pl-2M for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 15:56:13 +0200 Original-Received: from localhost ([::1]:59752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkR6S-0007LT-09 for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 09:56:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkR4I-00054H-5n for emacs-devel@gnu.org; Fri, 29 Apr 2022 09:53:58 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:56026) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkR4G-0000Wm-JL for emacs-devel@gnu.org; Fri, 29 Apr 2022 09:53:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CcFj4GFPBf1YAw0uXgpioj2lhLpmuQ6eWl+VZgAdSZg=; b=f168BX5RC0vZ0rDh/ZdeJT3wox UIkQuwaU3ofpiRRiGUcUMn6ppQ66Q2Iy3AcIyIeoi4s0Xy9ORXdujVmp1Xap20xV0I6KKNaUz0CVL GeoLeBn1Lt/EZJuTcGqaPOFM2HqcDfLxPDvr0tCyUe5rjM4duTHIwCpuv+auRCMNQBlU=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nkR4A-0000rM-3O; Fri, 29 Apr 2022 15:53:52 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEWXaIHevcLBv03/ //8lKWoeAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+YEHQ0xHfa5g4UAAAGOSURBVCjPTdDNatwwEAfw v428mD2ZIoekp01oSqqncEoDOSpgBbwn92DD+ilcQ8Pik09huyfXZI09T9kZd/shjNDPMxqNhMDi 3wiW2RCPHIpoPlbPpzHLLFS2LV6z41js5k5QvrrjWGYCJ+jG8scZz8XhY7HsKYtyVxxuaVt95Woz URv+PkXx7FJcJ/FCD4H1WsV/zh141fdU/cXdKZU051ziOTMlZ1jnaLYLnpiOSNIQPxUucYbSIBGc OM9Q7Tgx3t0u+OkcoB8EFZ0E8f8oXuLUui3Ngp3SNno445PWXOY9keBKR4x3ZAShjvhon4zcLOwE IPoGKGU7rBltz42Gtsaav6GfoC454neJGfoKKso1g19+aqD8/AC/NgNNn6Gu8wkRBBy5T4jrmGmp fd+YidET8QFBvV1ghhd5OJ8Ed/24gCP0Fm5a4MMeggkbrqb33OaGavgDd8DrVS+38LGqvQQXNa9v WqjmApGWAAasGnA3OW/b9wgEaz4pbG8gz70A/RrBF0mTMfkIHv+Aml/OxZANo//3HgAAACV0RVh0 ZGF0ZTpjcmVhdGUAMjAyMi0wNC0yOVQxMzo0OToyOSswMDowMHlXq9cAAAAldEVYdGRhdGU6bW9k aWZ5ADIwMjItMDQtMjlUMTM6NDk6MjkrMDA6MDAIChNrAAAAAElFTkSuQmCC X-Now-Playing: Tussle, Don Armando Bonilla's _Mutant Disco Vol 4_: "I'm An Indian Too (Re-Deconstruction ReMix)" In-Reply-To: (Stefan Monnier's message of "Fri, 29 Apr 2022 09:46:33 -0400") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288992 Archived-At: Stefan Monnier writes: > Any reason not to group them under the same heading? I thought the "probably introduced" thing only looked in the headings? And they were too long for one heading. >> + (let* ((face (if face face 'default)) > > (or face 'default) ? Yup; now done. > Any chance we could have a `cl-defstruct` for those font-info objects, so > we can use names rather than magic constants? Alternatively a short > comment here explaining the difference between 11 and 10 would be nice. Sure, a defstruct would be nice. >> +(defun window-max-characters-per-line (&optional window face) > > The name says "max", but AFAICT it's basically "window width / *average* > char width", so it's not really the "max" number of chars (unsurprisingly). > > I'm not sure how best to name it (and document it), tho. > For that I think I'd need to know what are the use cases (to see what > property they rely on). The use case basically is that you want to draw monospaced things that aren't too wide, but the function was made a bit more general. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no