* Re: master b7f227ed8b 2/2: ; * src/xterm.c (XTset_vertical_scroll_bar): Fix typo in last change.
[not found] ` <20220731024440.07F9EC09BFB@vcs2.savannah.gnu.org>
@ 2022-07-31 6:57 ` Lars Ingebrigtsen
2022-07-31 7:00 ` Lars Ingebrigtsen
0 siblings, 1 reply; 5+ messages in thread
From: Lars Ingebrigtsen @ 2022-07-31 6:57 UTC (permalink / raw)
To: Po Lu via Mailing list for Emacs changes; +Cc: Po Lu
With these scroll bar changes (probably), I'm getting the following
warning in a Gtk build:
xterm.c: In function 'XTset_vertical_scroll_bar':
xterm.c:14936:7: warning: implicit declaration of function 'x_scroll_bar_redraw'; did you mean 'x_scroll_bar_remove'? [-Wimplicit-function-declaration]
14936 | x_scroll_bar_redraw (bar);
| ^~~~~~~~~~~~~~~~~~~
| x_scroll_bar_remove
xterm.c:14936:7: warning: nested extern declaration of 'x_scroll_bar_redraw' [-Wnested-externs]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master b7f227ed8b 2/2: ; * src/xterm.c (XTset_vertical_scroll_bar): Fix typo in last change.
2022-07-31 6:57 ` master b7f227ed8b 2/2: ; * src/xterm.c (XTset_vertical_scroll_bar): Fix typo in last change Lars Ingebrigtsen
@ 2022-07-31 7:00 ` Lars Ingebrigtsen
2022-07-31 7:26 ` Po Lu
0 siblings, 1 reply; 5+ messages in thread
From: Lars Ingebrigtsen @ 2022-07-31 7:00 UTC (permalink / raw)
To: Po Lu; +Cc: Po Lu via Mailing list for Emacs changes
Lars Ingebrigtsen <larsi@gnus.org> writes:
> With these scroll bar changes (probably), I'm getting the following
> warning in a Gtk build:
>
> xterm.c: In function 'XTset_vertical_scroll_bar':
> xterm.c:14936:7: warning: implicit declaration of function
> 'x_scroll_bar_redraw'; did you mean 'x_scroll_bar_remove'?
> [-Wimplicit-function-declaration]
> 14936 | x_scroll_bar_redraw (bar);
> | ^~~~~~~~~~~~~~~~~~~
> | x_scroll_bar_remove
> xterm.c:14936:7: warning: nested extern declaration of
> 'x_scroll_bar_redraw' [-Wnested-externs]
And:
/usr/bin/ld: xterm.o: in function `XTset_vertical_scroll_bar':
/home/larsi/src/emacs/trunk/src/xterm.c:14936: undefined reference to `x_scroll_bar_redraw'
collect2: error: ld returned 1 exit status
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master b7f227ed8b 2/2: ; * src/xterm.c (XTset_vertical_scroll_bar): Fix typo in last change.
2022-07-31 7:00 ` Lars Ingebrigtsen
@ 2022-07-31 7:26 ` Po Lu
2022-07-31 8:36 ` Lars Ingebrigtsen
0 siblings, 1 reply; 5+ messages in thread
From: Po Lu @ 2022-07-31 7:26 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Po Lu via Mailing list for Emacs changes
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> With these scroll bar changes (probably), I'm getting the following
>> warning in a Gtk build:
>>
>> xterm.c: In function 'XTset_vertical_scroll_bar':
>> xterm.c:14936:7: warning: implicit declaration of function
>> 'x_scroll_bar_redraw'; did you mean 'x_scroll_bar_remove'?
>> [-Wimplicit-function-declaration]
>> 14936 | x_scroll_bar_redraw (bar);
>> | ^~~~~~~~~~~~~~~~~~~
>> | x_scroll_bar_remove
>> xterm.c:14936:7: warning: nested extern declaration of
>> 'x_scroll_bar_redraw' [-Wnested-externs]
>
> And:
>
> /usr/bin/ld: xterm.o: in function `XTset_vertical_scroll_bar':
> /home/larsi/src/emacs/trunk/src/xterm.c:14936: undefined reference to `x_scroll_bar_redraw'
> collect2: error: ld returned 1 exit status
Should be fixed now, thanks. Could you (and others) also run a build
with --without-toolkit-scroll-bars for a while, and see if any visual
glitches come up in the scroll bars?
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master b7f227ed8b 2/2: ; * src/xterm.c (XTset_vertical_scroll_bar): Fix typo in last change.
2022-07-31 7:26 ` Po Lu
@ 2022-07-31 8:36 ` Lars Ingebrigtsen
2022-07-31 8:45 ` Po Lu
0 siblings, 1 reply; 5+ messages in thread
From: Lars Ingebrigtsen @ 2022-07-31 8:36 UTC (permalink / raw)
To: Po Lu; +Cc: Po Lu via Mailing list for Emacs changes
Po Lu <luangruo@yahoo.com> writes:
> Should be fixed now, thanks. Could you (and others) also run a build
> with --without-toolkit-scroll-bars for a while, and see if any visual
> glitches come up in the scroll bars?
I've tried it a bit now, and I don't see any glitches (on a laptop with
the current Ubuntu/Gnome Shell). But I don't really use scroll bars
normally, so I'm probably not the best person to test.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master b7f227ed8b 2/2: ; * src/xterm.c (XTset_vertical_scroll_bar): Fix typo in last change.
2022-07-31 8:36 ` Lars Ingebrigtsen
@ 2022-07-31 8:45 ` Po Lu
0 siblings, 0 replies; 5+ messages in thread
From: Po Lu @ 2022-07-31 8:45 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Po Lu via Mailing list for Emacs changes
Lars Ingebrigtsen <larsi@gnus.org> writes:
> I've tried it a bit now, and I don't see any glitches (on a laptop with
> the current Ubuntu/Gnome Shell). But I don't really use scroll bars
> normally, so I'm probably not the best person to test.
Sure, thanks for testing.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-31 8:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <165923547930.6475.9574531983497191865@vcs2.savannah.gnu.org>
[not found] ` <20220731024440.07F9EC09BFB@vcs2.savannah.gnu.org>
2022-07-31 6:57 ` master b7f227ed8b 2/2: ; * src/xterm.c (XTset_vertical_scroll_bar): Fix typo in last change Lars Ingebrigtsen
2022-07-31 7:00 ` Lars Ingebrigtsen
2022-07-31 7:26 ` Po Lu
2022-07-31 8:36 ` Lars Ingebrigtsen
2022-07-31 8:45 ` Po Lu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).