unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Philip Kaludercic <philipk@posteo.net>
To: MICHAEL J MCCLENNEN <mmcclenn@geology.wisc.edu>
Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: request a change to electric.el
Date: Sun, 28 Aug 2022 08:10:21 +0000	[thread overview]
Message-ID: <87v8qczt3m.fsf@posteo.net> (raw)
In-Reply-To: <A9479A35-954C-430B-979A-DCE7D72BEF78@geology.wisc.edu> (MICHAEL J. MCCLENNEN's message of "Sat, 27 Aug 2022 20:19:40 +0000")

MICHAEL J MCCLENNEN <mmcclenn@geology.wisc.edu> writes:

> Hello,

Hi,

> This is directed at either K. Shane Hartman or else whoever is
> currently in charge of maintaining electric.el. Could you please make
> the following change to this module? The effect is to adapt
> electric-indent-mode to people like me who use indented lines instead
> of completely blank lines between their statements. Since I made this
> change in my own installation, electric-indent-mode has been much more
> satisfactory for me. The way I wrote this patch, it will have no
> effect unless somebody sets the electric-indent-preserve-whitespace
> locally.

This feature could be generalise a bit further, so that features like
whitespace-cleanup don't break the intended formatting.

> If this is not the proper way for me to submit such a request, please tell me what you would like me to do instead.

If you have a local git checkout of emacs.git, read through the
CONTRIBUTE file to see what you have to do.  The end result should be a
.patch file.

> Thank you for your time,
>
>   Michael McClennen
>
>
> 233a234,237
>> (defvar-local electric-indent-preserve-whitespace nil
>>   "If non-nil, whitespace will not be removed from a line that is reindented
>> after a newline.")
>>
> 282c286
> <               (when (eolp)
> ---
>>               (when (and (eolp) (not electric-indent-preserve-whitespace))



  reply	other threads:[~2022-08-28  8:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-27 20:19 request a change to electric.el MICHAEL J MCCLENNEN
2022-08-28  8:10 ` Philip Kaludercic [this message]
2022-08-28 15:08 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8qczt3m.fsf@posteo.net \
    --to=philipk@posteo.net \
    --cc=emacs-devel@gnu.org \
    --cc=mmcclenn@geology.wisc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).