From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Add zuul.el package to ELPA Date: Tue, 30 Aug 2022 09:02:58 +0000 Message-ID: <87v8qaumrh.fsf@posteo.net> References: <874jxuj3q1.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19147"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Niklas Eklund Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 30 11:04:57 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oSxB3-0004iA-4g for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 11:04:57 +0200 Original-Received: from localhost ([::1]:35806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oSxB2-0000Rk-73 for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 05:04:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSx9I-0006sz-RD for emacs-devel@gnu.org; Tue, 30 Aug 2022 05:03:10 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:38395) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSx9G-0008Gs-I5 for emacs-devel@gnu.org; Tue, 30 Aug 2022 05:03:08 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 57928240101 for ; Tue, 30 Aug 2022 11:03:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1661850184; bh=uSPkXbvS9MsN/ybeqNVX/4GCRdLqEmJ39zOBkN/WxPo=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=lD1K8Oc2CHH9Cy0CcBWFwPe/knxRdCDapeLkdo0T53dp68ByWCxNwazCYNJ/lmIT8 n4gasPZUrH5PzCc7Wp0k/TP1ngm6kmSgoy0T8TYeT/a0oK3hM9BnmCHADl37+iIewX RygwU8fxtOGGccNSt6Uz4tVbTrDayUDPt7iuUN7hX+mZrdaIXvMETd22LskM6RsGZ+ QPpNSjIpEcBfaAl3BUrdR/MbfkUqIbIfuKgSTR9YZ3H/R4R0NF2XOJyuWi5fyZ/sfJ /8/ZtNl0bYA6p3bu2wTq0zh3SGjuXD7kEx4Z7E0xtfa5xjQJUDARQAik6wkxV9Jofq M1OtmXmG+xD7g== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MH1YM5W0Qz6tmL; Tue, 30 Aug 2022 11:03:03 +0200 (CEST) In-Reply-To: <874jxuj3q1.fsf@posteo.net> (Niklas Eklund's message of "Mon, 29 Aug 2022 18:37:26 +0000") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294326 Archived-At: Niklas Eklund writes: > > Hello, > > I would like to add a package that I have developed named zuul.el, > https://git.sr.ht/~niklaseklund/zuul.el, to ELPA. Just a few comments from briefly skimming the code: I believe if you used compat, you can reduce the minimal version of Emacs down to 26.1, and the only hard dependency appears to be project.el? I'd also recommend using more specific custom types for your user options. See (elisp) Composite Types. It also appears you should be able to use defconst and defvar-local in your private variable section. Keywords (:foo) do not have to be quoted to prevent evaluation. I believe, but I might be mistaken, that it is advised to require rx in a `eval-when-compile' block. (mapconcat #'identity ...) should do the same as `string-join' Defining a map like zuul-log-mode-map is usually done using defvar (defvar foo-map (let ((map (make-sparse-keymap))) (define-key map ...) ... map)) > The package allows users to access build logs from the Zuul, > https://zuul-ci.org/, CI system. Users uses the completion interface of > Emacs to select a specific build and a buffer is then opened with the > build log. > > The package utilizes Emacs compilation mode to navigate between errors > in the logs. It also lets the user configure where projects can be found > on the local machine so that navigating to the source code of an error > works, even though the absolute path might not be found on the local > host. > > /Niklas Eklund > > From ed4201c73aa66b21b040169009dddb636ab76048 Mon Sep 17 00:00:00 2001 > From: Niklas Eklund > Date: Mon, 29 Aug 2022 20:26:35 +0200 > Subject: [PATCH] * elpa-packages (zuul): New package > > --- > elpa-packages | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/elpa-packages b/elpa-packages > index 4ae12a26ca..5ab182f93b 100644 > --- a/elpa-packages > +++ b/elpa-packages > @@ -810,4 +810,8 @@ > ("yasnippet-classic-snippets" :url nil) > ("zones" :url nil) ;https://www.emacswiki.org/emacs/zones.el > ("ztree" :url "https://github.com/fourier/ztree") > + ("zuul" :url "https://git.sr.ht/~niklaseklund/zuul.el" > + :news "CHANGELOG.org" > + :readme "README.md" > + :auto-sync t) > )