From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Amending commits Date: Sun, 25 Sep 2022 13:49:48 +0000 Message-ID: <87v8pbsgw3.fsf@posteo.net> References: <87h70vbw2f.fsf@gnus.org> <877d1ru3rd.fsf@posteo.net> <87zgenr812.fsf@gmail.com> <8735cfty9v.fsf@posteo.net> <8735cf6172.fsf@igel.home> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40123"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Visuwesh , Lars Ingebrigtsen , "Emacs-devel@gnu.org" To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 25 15:56:52 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ocS7n-000AHt-SX for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Sep 2022 15:56:51 +0200 Original-Received: from localhost ([::1]:48122 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ocS7l-0002zt-Td for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Sep 2022 09:56:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocS14-0003nr-IJ for Emacs-devel@gnu.org; Sun, 25 Sep 2022 09:49:55 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:36585) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocS12-0001Le-FZ for Emacs-devel@gnu.org; Sun, 25 Sep 2022 09:49:54 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 2D7B624002A for ; Sun, 25 Sep 2022 15:49:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1664113790; bh=C7BEUYSHBnO1x7qjHXm/d3Pfv6QbU89FQC8mn066EXY=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=MZGl/51bhJEuMVXYCYGwcxykjDUkzkQldkYn7Sly/nAQscCOBH4LI2L9GrdBFItyE rkJM+1oICxek83q47qNieh12dJfoqHHgByUL7RXywh2qAUPXqJbnlOJ2Ay77LMfrTB IkJV9Sx/hHWpiucOPmMI2GqEWzNsIETmncDz26/Z8S/p90bjkOSsfHRoZ6etzzSKo9 OFe3XCHm5QLr1kRgEPTArI1jF8t2dBtqarHnEqyriUXF9psd+gXvdYKdQwR3LgZAzO NiSjA+5ZiVuHnIp2/tDa78/TlNWqcn0dDVdjZFzNMZjoijwyAqPeJ/BBUiqdzV1C4x DjIr3KyY8501Q== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Mb6hF14gNz9rxj; Sun, 25 Sep 2022 15:49:48 +0200 (CEST) In-Reply-To: <8735cf6172.fsf@igel.home> (Andreas Schwab's message of "Sun, 25 Sep 2022 15:19:45 +0200") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296219 Archived-At: Andreas Schwab writes: > On Sep 25 2022, Philip Kaludercic wrote: > >> Visuwesh writes: >> >>> [=E0=AE=9E=E0=AE=BE=E0=AE=AF=E0=AE=BF=E0=AE=B1=E0=AF=81 =E0=AE=9A=E0=AF= =86=E0=AE=AA=E0=AF=8D=E0=AE=9F=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0=AE=B0=E0=AF=8D= 25, 2022] Philip Kaludercic wrote: >>> >>>>> There should be a command in `vc-dir-mode' that allows you to amend t= he >>>>> last commit, I think. >>>> >>>> That would be good, because it would also allow easier to reword a >>>> commit that doesn't require any code changes. >>> >>> As someone who does not really understand Git, does this mean we are >>> rewriting the log message without also committing a change? I thought >>> that was not allowed by Git. >> >> Git allows it if you pass the --allow-empty flag. > > You don't need --allow-empty if you use --amend. You are right, I made a mistake when testing it out locally.