From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Typo in defconst-1 and defvar-1 docstrings? Date: Thu, 06 Oct 2022 18:45:40 +0000 Message-ID: <87v8owlrjf.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7177"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 06 21:13:32 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ogWJI-0001hR-14 for ged-emacs-devel@m.gmane-mx.org; Thu, 06 Oct 2022 21:13:32 +0200 Original-Received: from localhost ([::1]:47240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogWJH-0007Qq-0Z for ged-emacs-devel@m.gmane-mx.org; Thu, 06 Oct 2022 15:13:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogVsd-0004pi-7j for emacs-devel@gnu.org; Thu, 06 Oct 2022 14:45:59 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:41197) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogVsW-0005aH-1f for emacs-devel@gnu.org; Thu, 06 Oct 2022 14:45:58 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id B3486240104 for ; Thu, 6 Oct 2022 20:45:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1665081942; bh=ecDYGREn6nr71kNUaZ7VzBNdtXMDaekLOxfy/Ml7yzc=; h=From:To:Subject:Autocrypt:Date:From; b=Ffr8gwxzxav1w6P8QBhc3VNOXmoWKKyXz86BySA8hupQUrk0ViiynAbHELrWAquF+ No9ddZG2wNDqpnr4ONyHOuaq/ETbuZ1eC61gX1+ylmWjL/7Gv8Gm7D/6ZL5UOgAfdS a56bNlj0ofREgwffwim3G6/BHkNIsvxR1kJ/CGjv6gCjP2tsg4MSEy6shlPxTO6PBl A/xMnEQm25sCKrFTdkw8vkdRVlB88jhEzCMpA/piO+3HU8BbsYY8A6+WDXOOsuyU6R g1jo4vA7o2PviEcvtRB0f6DOtS1QkacFJqJHmylKX892WUJF2PC7h/kxB1xM7W9UNi iliz3pdK5g7bQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Mk0kZ24vYz6tm6 for ; Thu, 6 Oct 2022 20:45:41 +0200 (CEST) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297115 Archived-At: --=-=-= Content-Type: text/plain I was reading through the implementation of defconst-1, but was confused by the docstring that states: More specifically behaves like (defvar SYM 'INITVALUE DOCSTRING). Isn't the point of defconst-1 as a functional variant of defconst, that SYM will evaluate to a symbol? And why should INITVALUE be quoted? Unless I am mistaken, this patch ought to resolve the confusion: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-misquoted-examples-in-def-var-const-1.patch >From 8fbe8fa10355845f759b3d8abbb1894f31b46eed Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Thu, 6 Oct 2022 20:41:51 +0200 Subject: [PATCH] Fix misquoted examples in def{var,const}-1 * src/eval.c (Fdefvar_1): Quote the SYM, not the INITVAL. (Fdefconst_1): Quote the SYM, not the INITVAL. --- src/eval.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/eval.c b/src/eval.c index 8810136c04..56c5c7ea06 100644 --- a/src/eval.c +++ b/src/eval.c @@ -834,7 +834,7 @@ DEFUN ("defvar", Fdefvar, Sdefvar, 1, UNEVALLED, 0, DEFUN ("defvar-1", Fdefvar_1, Sdefvar_1, 2, 3, 0, doc: /* Like `defvar' but as a function. -More specifically behaves like (defvar SYM 'INITVALUE DOCSTRING). */) +More specifically behaves like (defvar 'SYM INITVALUE DOCSTRING). */) (Lisp_Object sym, Lisp_Object initvalue, Lisp_Object docstring) { return defvar (sym, initvalue, docstring, false); @@ -875,7 +875,7 @@ DEFUN ("defconst", Fdefconst, Sdefconst, 2, UNEVALLED, 0, DEFUN ("defconst-1", Fdefconst_1, Sdefconst_1, 2, 3, 0, doc: /* Like `defconst' but as a function. -More specifically, behaves like (defconst SYM 'INITVALUE DOCSTRING). */) +More specifically, behaves like (defconst 'SYM INITVALUE DOCSTRING). */) (Lisp_Object sym, Lisp_Object initvalue, Lisp_Object docstring) { CHECK_SYMBOL (sym); -- 2.37.3 --=-=-=--