From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: master 59df0a7bd9: Add a VC command to prepare patches Date: Sat, 08 Oct 2022 12:40:13 +0000 Message-ID: <87v8oufpzm.fsf@posteo.net> References: <166522273249.875.4607071661972312638@vcs2.savannah.gnu.org> <20221008095212.D8BB0C21CF8@vcs2.savannah.gnu.org> <874jweed48.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15554"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 08 14:41:47 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oh99G-0003ob-Uw for ged-emacs-devel@m.gmane-mx.org; Sat, 08 Oct 2022 14:41:47 +0200 Original-Received: from localhost ([::1]:47936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oh99F-0007X5-Oi for ged-emacs-devel@m.gmane-mx.org; Sat, 08 Oct 2022 08:41:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54126) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oh97t-00064c-Od for emacs-devel@gnu.org; Sat, 08 Oct 2022 08:40:22 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:46759) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oh97q-0006bX-Or for emacs-devel@gnu.org; Sat, 08 Oct 2022 08:40:21 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 6ECCE24002E for ; Sat, 8 Oct 2022 14:40:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1665232816; bh=WEo5gFlEHbI87gk7mnD9jLnypAz8DvX2XP3WLwMUZUc=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=nxG+nIUsXmcUWmHU8ndP5xx/PO9Kvxtb3fAH3D1cjHCHeAgDixu5xk/59TpO/kauR 22ntQAw0hWd6/oGsrPmd8gBEdg3/B7n1YIMcC/AjQ1PfI4oqEP6psyY50nvepJbYPb fSdSdkMs0GeibAsxxsvF93zB3/MHmKnWrS+fEAD9k7Nvudwz68VzVJFTMlGCTdCevq 3RvpNfF//AvNcYPvdDwo0aNMgYvkiUJINd6GZgIDeFJbkh654wiUwpYe6XIbs2ud2u uwmeQW1VXXcY2Sv9aRPYL8dsG2Q2L4j6hbX4zI3bVqlx3mEX7LB2ZYpJJ22EuBQ4vJ NSJx2yfrLsNvg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Ml4Wx36Sqz9rxG; Sat, 8 Oct 2022 14:40:13 +0200 (CEST) In-Reply-To: <874jweed48.fsf@gmx.de> (Michael Albinus's message of "Sat, 08 Oct 2022 14:03:35 +0200") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297200 Archived-At: --=-=-= Content-Type: text/plain Michael Albinus writes: > Philip Kaludercic writes: > > Hi Philip, > >> --- a/etc/NEWS >> +++ b/etc/NEWS >> +--- >> +*** The function 'vc-read-revision' accepts a new MULTIPLE argument. >> +If non-nil, multiple revisions can be queried. This is done using >> +'completing-read-multiple'. >> + >> +--- >> +*** New function 'vc-read-multiple-revisions' >> +This function invokes 'vc-read-revision' with a non-nil value for >> +MULTIPLE. > > Both functions haven't a docstring. Now that we mention them in NEWS, > they should get it, shouldn't they? How do you like the following: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 14b149310c..2867539aa3 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -1926,6 +1926,13 @@ vc-revision-history "History for `vc-read-revision'.") (defun vc-read-revision (prompt &optional files backend default initial-input multiple) + "Query the user for a revision using PROMPT. +All subsequent arguments are optional. FILES may specify a file +set to restrict the revisions to. BACKEND is a VC backend as +listed in `vc-handled-backends'. DEFAULT and INITIAL-INPUT are +handled as defined by `completing-read'. If MULTIPLE is non-nil, +the user may be prompted for multiple revisions. If possible +this means that `completing-read-multiple' will be used." (cond ((null files) (let ((vc-fileset (vc-deduce-fileset t))) ;FIXME: why t? --Stef @@ -1947,6 +1954,10 @@ vc-read-revision answer))))) (defun vc-read-multiple-revisions (prompt &optional files backend default initial-input) + "Query the user for multiple revisions. +This is equivalent to invoking `vc-read-revision' with t for +MULTIPLE. The arguments PROMPT, FILES, BACKEND, DEFAULT and +INITIAL-INPUT are passed on to `vc-read-revision' directly." (vc-read-revision prompt files backend default initial-input t)) (defun vc-diff-build-argument-list-internal (&optional fileset) --=-=-= Content-Type: text/plain > Best regards, Michael. --=-=-=--