From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Call for volunteers: add tree-sitter support to major modes Date: Sun, 09 Oct 2022 12:26:09 +0000 Message-ID: <87v8ot2nfi.fsf@posteo.net> References: <83czb1jrm3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1034"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Yuan Fu To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 09 14:27:32 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohVP1-00006p-V2 for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Oct 2022 14:27:32 +0200 Original-Received: from localhost ([::1]:59914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohVP0-0001js-E5 for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Oct 2022 08:27:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohVNn-0000vN-NK for emacs-devel@gnu.org; Sun, 09 Oct 2022 08:26:22 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:44831) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohVNm-0005sl-3l for emacs-devel@gnu.org; Sun, 09 Oct 2022 08:26:15 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id C583A240107 for ; Sun, 9 Oct 2022 14:26:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1665318371; bh=5/CL1r6ENmcgYSGAe54C4Gl2lHpNanuYaYfp1OEd7BU=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=bUwhpgGI+4ItOCS5J/YHePvhI+md2HoVcox2vtF/phxqBfMZThvi91RxporvxWRTE PdNlzyUZgEfsl+DiyK5SvdSd7gSOOQ8iFaC6+Lq3LQ66fJc8kxFcGvLlvpv5QQsFqe FTTCZsn9utyZLERDp8oXHeW0+BeSlGup/CKI8HvIzm479qeM9GZEAS++cCCuyuiDkU l1HPgUTcMUKJyy3H3p8Klm2j42PlAqBGuYz+SjPGIdcAx8ItSq4A3aP11DAsCl7A3B zfuDrYDtZI4yXw2Z5tTU9ZcCNm8tZ/qM2U3kpITL7GGg/k/Nbh1xwUpS/oaJeLHOS3 YyRmSXJbdKSjg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Mlh9G1BxFz6tms; Sun, 9 Oct 2022 14:26:10 +0200 (CEST) In-Reply-To: <83czb1jrm3.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 09 Oct 2022 12:03:48 +0300") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297252 Archived-At: Eli Zaretskii writes: > Some of the popular major modes for which we would like to see > tree-sitter support in Emacs 29 are: > [...] > emacs-lisp-mode How much of a priority is using tree sitter for Emacs Lisp? It appears that this[0] is the grammar implementation, and it currently doesn't support the following: Autoload cookies Definitions (e.g. defun, defvar, defmacro) As far as I understand, this means that from your list of enhanced features, the following will either be restricted or not work at all: - font-lock - indentation - imenu - which-func Also, when taking a look at the current implementation for Python[1][2], I cannot but wonder if a few high-level functions/macros should be added first to make it easier. One more thing, it looks like the usage of tree-sitter is enabled for python by toggling `python-use-tree-sitter'. Will every mode now have this kind of an option? I would hope not... [0] https://github.com/Wilfred/tree-sitter-elisp [1] https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/progmodes/python.el?h=feature/tree-sitter#n953 [2] https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/progmodes/python.el?h=feature/tree-sitter#n5324