From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: feature/package-vc has been merged Date: Wed, 09 Nov 2022 17:35:46 +0000 Message-ID: <87v8no9gjx.fsf@posteo.net> References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <87sfiyk3a2.fsf_-_@posteo.net> <838rkp4ptj.fsf@gnu.org> <87zgd58i7y.fsf@posteo.net> <83k0492u5i.fsf@gnu.org> <87fsew8g18.fsf@posteo.net> <83mt941cyd.fsf@gnu.org> <87fsewp0ec.fsf@posteo.net> <837d0814c9.fsf@gnu.org> <878rkooz1o.fsf@posteo.net> <831qqg1306.fsf@gnu.org> <874jvcowzm.fsf@posteo.net> <83y1soypvx.fsf@gnu.org> <87y1song5x.fsf@posteo.net> <83v8nsyof7.fsf@gnu.org> <87leoond7l.fsf@posteo.net> <87mt90tyns.fsf@thaodan.de> <87o7tgfw4m.fsf@posteo.net> <87eductx0x.fsf@thaodan.de> <871qqcfs9y.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9655"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?utf-8?Q?Bj=C3=B6rn?= Bidar , Eli Zaretskii , rms@gnu.org, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 09 18:37:00 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osp0V-0002Fu-Pa for ged-emacs-devel@m.gmane-mx.org; Wed, 09 Nov 2022 18:36:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osozW-0001od-HY; Wed, 09 Nov 2022 12:35:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osozU-0001o7-CS for emacs-devel@gnu.org; Wed, 09 Nov 2022 12:35:56 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osozP-00068f-Ic for emacs-devel@gnu.org; Wed, 09 Nov 2022 12:35:56 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 14DE1240101 for ; Wed, 9 Nov 2022 18:35:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668015350; bh=qtsGMZp3eI+y7w4RK+JSxiPYPSduD5/j10qQTi05V7M=; h=From:To:Cc:Subject:Date:From; b=ngHiXbFnd0KRGiXee6yIRFcINkzEd43wHQ3TNe5wVhuxPLnZU0T9wq2HFba51Sg1V h6OPMsHRXQR2yLH6THJaUIzaAwEZ/pLLU6q3+S6BJ5mqO3dF56uJokvzEjlBMdRLy1 Us8Wf/0DfffXC5hi5VpTfUP27P+nvP66sqCnAC6dE6oIGsB2Z7FrdZr7WuojymRhMc eSSnx7NTDXSzSjJ9SgoTTRWoXLAr9Av2NpnzkeUAqjSxHL/YM0zcoAV7H2vrKdaNuJ nAjZOn/F+gAM3U9TtvRbaUSEnP6bHY7F0aydOkO/in9Pv4VomQQgUF8UIvroEbtYY3 K+Jtc7PgxVxUQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N6sZF34N5z9rxH; Wed, 9 Nov 2022 18:35:46 +0100 (CET) In-Reply-To: (Stefan Monnier's message of "Wed, 09 Nov 2022 12:25:26 -0500") Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299416 Archived-At: Stefan Monnier writes: >>> Without such a system the package could be without use in many cases. >> Many is probably the word of contention here. If you take a look at >> elpa.git:elpa-packages, you'll find only a few :make or :shell-command >> directives, none of which are critical. nongnu.git:elpa-packages has >> non at all. > > Indeed. We don't use `make` or `ninja` to compile the ELisp files, > instead we impose a standardized way to compile them. > > [ And those packages which rely on special build procedures will often > suffer from problems with the native compiler, which will lazily > recompile the files to native code without paying attention to the > special build requirements. ] What might be interesting is providing support for running commands to build additional software a package needs, e.g. when a package distributed a C module. But this wouldn't just be a package-vc thing, but a thing that would interest all packages. >> One thing I worry about, but which has also been discussed >> here are :renames. > > Indeed. Currently `elpa-admin.el` doesn't obey them when using "install > from Git" (it does obey them when building the tarballs, of course) :-( > >> E.g. Vertico uses these to move extensions from a subdirectory to the >> main directory for packaging. But moving the files would be >> registered by the VCS, and could make committing changes more >> difficult. Maybe we could create symbolic/hard links instead >> of renaming? > > Moving is definitely out of the question, but symlinks and hardlinks are > also problematic. We should probably document that `:renames` are not > fully supported in all cases and should thus be avoided. > I currently count 6 :renames, two for `extensions/` and 4 for `docs/`. I agree, luckily there hasn't been much need for it up until now. > AFAIK Those for docs are needed only because `package-install` handles > `.info` files only in the root directory of packages, but that doesn't > afflict `package-vc`, so we should be able to find a better solution. > > Those for `extensions/` can be handled by adding `extensions/` to > the `load-path` in the `-autoloads.el` generated by > `package-vc-install`. OK, but how would this generalise? Hard-coding something like "if 'extensions/' is renamed to the '', then add 'extensions/' to `load-path'" doesn't sound desirable. > > Stefan