From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: feature/package+vc 04c4c578c7 3/4: Allow for packages to be installed directly from VCS Date: Wed, 16 Nov 2022 20:01:35 +0000 Message-ID: <87v8nek6sg.fsf@posteo.net> References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <20220214140020.04438C00891@vcs2.savannah.gnu.org> <87v8neep21.fsf@bernoul.li> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37726"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , emacs-devel@gnu.org To: Jonas Bernoulli Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 16 21:02:40 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ovOcJ-0009Wy-Hz for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Nov 2022 21:02:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovObZ-0000tz-1k; Wed, 16 Nov 2022 15:01:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovObV-0000tI-AD for emacs-devel@gnu.org; Wed, 16 Nov 2022 15:01:50 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovObS-0003P7-G8 for emacs-devel@gnu.org; Wed, 16 Nov 2022 15:01:48 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 1491D24002A for ; Wed, 16 Nov 2022 21:01:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668628904; bh=w71LFirumFXC67NmjKPw/JIDuxxhPs1MXA0L4da5i0c=; h=From:To:Cc:Subject:Date:From; b=FGw0S7UBS+WoEjBjyPq44xG3RwMpEvbg2tFt4ckVZ+P9oRkHG/51XRqs0qPks3U1H UOaXCg3tTsGeEQ5jWweEGiP/bJ4d5LmLB/zrBjXPldndmfP8ZSFTX5wgvk8UMn/l90 X6kR1CktmLHljRK20+5sYZf0Quja7pdgwuD0apanhx4iA7+RhbItCEFicc1/VxbFe2 NFhFXjE+z1sZ6hfRlA5t9uSq9d12JR9a10ZoV1GBQbcOYRji9epHBYZHRaSzM+eu9F 88sJtjr+/ayGJIo3FmA1l6xMcRhP8CXQVbeqNUPcK4ksqbdzQw8KOL3aCni2x4zKC3 /DCGLKS+2zWsQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NCDTK5hx6z6tnM; Wed, 16 Nov 2022 21:01:40 +0100 (CET) In-Reply-To: <87v8neep21.fsf@bernoul.li> (Jonas Bernoulli's message of "Wed, 16 Nov 2022 19:23:34 +0100") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299983 Archived-At: Jonas Bernoulli writes: > I cannot find it now, but somewhere in this thread you discussed > uninstalling a vc-installed package without risking to lose any > local changes. I suppose you mean and . > In Borg I handle it like this: > > Installing a package detaches the gitdir from the working tree. > (Borg uses submodules, but you don't need to do that to detach the > gitdir.) > > Uninstalling the package only removes the working tree. Keeping the > gitdir preserves all branches, stashes and dangling revs. Uninstalling > is only allowed if there are no uncommitted changes. > > The gitdir remains and if the user ever installs the same package again, > they are at that time asked whether to simply restore the working tree > or to start over and discard the existing gitdir. >From what I see this relies on the advantage of fixing a VCS like Git, while package-vc -- to stay VCS agnostic -- keeps everything within a directory. I think that Stefan's suggestion to double-check if a user really wants to delete a VC package should be enough.