From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 2c8b09b06e7: Fix crash on Windows 9X Date: Tue, 06 Dec 2022 20:51:58 +0800 Message-ID: <87v8mon18x.fsf@yahoo.com> References: <167029029523.21453.12133435240921985505@vcs2.savannah.gnu.org> <20221206013135.E2E2DC004BE@vcs2.savannah.gnu.org> <87fsdtnn8x.fsf@yahoo.com> <83r0xc7mf8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33168"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 06 13:53:06 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2XRZ-0008Ob-Oq for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Dec 2022 13:53:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2XQm-0005mb-TF; Tue, 06 Dec 2022 07:52:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2XQl-0005mP-Pd for emacs-devel@gnu.org; Tue, 06 Dec 2022 07:52:15 -0500 Original-Received: from sonic306-20.consmr.mail.ne1.yahoo.com ([66.163.189.82]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2XQk-0005OR-9R for emacs-devel@gnu.org; Tue, 06 Dec 2022 07:52:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1670331132; bh=yKqlqOWa1jPYmnaLwiBao+eORXmBn7oyzmw34bC8pKY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=kJHIt5QX2+HUruet8dqIc+yWZyEHeRXQHsmzvtUNY21+g7FBvR4RTlIeL4DmfCz7sUVq1YLme4AY3ZeM9Vrswear0dgcxEhB+fWsRc/0OS9ySabceW1G8NHPdX452kztgHLtklJ/9oxh9zh6CK6aBarashO/HbmTw9b+zks8/QZPd8chsKQCwuBxzKmk749uIEZ8Vzwt4O/nORCfxxFV7HFaSoivkAoFNZ04wlhxtNkgcGdbIyayFxfQaxJpfNHwyiAzNoi7D1vf6j9arLtAHWUAErqVuJQYsPpAPnwdR2Uh6AqG/eejccf1Pu7AASfbcVddso2d24V6QL8b+1z00g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1670331132; bh=EOfwO+PqX4MRo5O9TjFkIl3fYUvbRdb98bpsbqLRwdW=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=bh+uHqK/utmQJhDwNHoV2fmADgZwrz4WAUQI/72EyuqmE0EeLxL9x11zGpjng+keXkP83Y8f9gOkEaN/VsLyWeRxfyX8t9gO2LtZoBUWeTNtVVyxPfu9eZ67GIiUWNIyjhcioRuTKmqMA3qfGL/HoKlkyIMLwapahIKXRkMmLAY3rVeuRvFg8Fs5NaH/TlNGbLli+wpVOzxDuFBWcq2uL81RT+Mrjnote+olXRao957aavwURcTz9FPO40KM38+nnrbeHYwESsxRe/+3qv2HF4fGoZbF8Fokn36bdyIHpwqAf6Gi0r3ZisurBdN7fxTgUQNq9E1opLbF/ikwMAs3mQ== X-YMail-OSG: d66WCPEVM1nhuGzmQZ8.BF8nyanvcBm7jlEufpil.nQMkMPP8BDYOx5D.DTQMMO i0F7qoT3nxsVjQdkLtcJl1cgqhYItknzhATv9XAyQps5uUlwKMVMRgeRiToOIyl6hxHckN_7sw9i A5dENspa4m6VtmqkGU9VGXUvUTy.KAvyf48lbL6QcvVTPANegtYLaLTIg6og64bdhb.CGNqtAlgE rH6FtidgE5pV_HEBezxiFm0._BbJTmRe74a4sPnthAAeCqVGzndbzJG9ifnDDbYFnBXupQZvDLQX mkmr8mDlkP1DSltw7QBH5CgxK6C.x1PaEqCKkqpbdAk6D0rC.J6JEyLvyPnK8YiXtHp8r2zaszL4 DVnDvXNf_DIstz7nEe1gRdOIr0Uwj1G3zLr0rrwx46pghlp9_UTxl5CWC6JglzUobCpFApP.J7rT QOnygAf3INAeWDW5N1Ek7qKO6YIHsWQwuZdI09aAcjEVB3h6BJu9XXdUEXZvPk7LhovRdF9TF8qw sxV504XHmY7vfLLPEG7Uev0m0wyPQLKjW4ULjFS2.HQ5gIwzEkm0ch2IA.PpjX1Wzh5.zWKecp0e P6geymZzoZfWpIsTtTwXd8Dd6HujykDy1fQtLnaNfCndasqgfsMdanidr5vdWw3uwxYIJb_IA1bm eM7QGRqdr3rYGC56.jvmj_s6uVDLirS5M.8fUoMlohlgcYNMmbBjYxMLlBqtymYH4pz5I_PrEqMf Sd2nxvBSuESgC2RD_9Ke.0rO6XfTNV3xNaK.8l7KxoK7mOmifsLdJOTk5Qu6DBUX.233OPYYHO9r hiYNRtBb1CB5fbKb0f7IHVRKokfy9WYDsBiaFitZI8 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Tue, 6 Dec 2022 12:52:12 +0000 Original-Received: by hermes--production-sg3-b666c6484-7wpvn (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 4c9cb84094398e016dd45b9a9b24c4f6; Tue, 06 Dec 2022 12:52:07 +0000 (UTC) In-Reply-To: <83r0xc7mf8.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 06 Dec 2022 14:21:15 +0200") X-Mailer: WebService/1.1.20940 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.189.82; envelope-from=luangruo@yahoo.com; helo=sonic306-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300963 Archived-At: Eli Zaretskii writes: >> From: Po Lu >> Cc: emacs-devel@gnu.org >> Date: Tue, 06 Dec 2022 12:56:46 +0800 >> >> Stefan Monnier writes: >> >> >> --- a/src/emacs.c >> >> +++ b/src/emacs.c >> >> @@ -1924,6 +1924,12 @@ Using an Emacs configured with --with-x-toolkit=lucid does not have this problem >> >> Vcoding_system_hash_table. */ >> >> syms_of_coding (); /* This should be after syms_of_fileio. */ >> >> init_frame_once (); /* Before init_window_once. */ >> >> + /* init_window_once calls make_initial_frame, which calls >> >> + Fcurrent_time and bset_display_time, both of which allocate >> >> + bignums. Without the following call to init_bignums, crashes >> >> + happen on Windows 9X after dumping when GC tries to free a >> >> + pointer allocated on the system heap. */ >> >> + init_bignum (); >> >> init_window_once (); /* Init the window system. */ >> >> #ifdef HAVE_WINDOW_SYSTEM >> >> init_fringe_once (); /* Swap bitmaps if necessary. */ >> > >> > I feel like I'm missing something: this adds a call to `init_bignum` >> > whereas I expected the patch to *move* the call. >> > Was this call simply missing? >> > >> > >> > Stefan >> >> No. The call I added is only called before dumping, while the second is >> called after dumping, AFAIK. > > No, the second one is done both before and after dumping. Only the first > call is conditioned. Ah, thanks for the clarification. In any case, it must come before init_window_once. Does calling it twice hurt?