From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: Merging feature/android Date: Tue, 14 Mar 2023 19:34:48 +0800 Message-ID: <87v8j37ehz.fsf@yahoo.com> References: <87edq7ztks.fsf.ref@yahoo.com> <87edq7ztks.fsf@yahoo.com> <874jqn9508.fsf@yahoo.com> <875yb3vftq.fsf@gmail.com> <87zg8f7h2d.fsf@yahoo.com> <871qlrvcc7.fsf@gmail.com> <87wn3jtwxg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34116"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 14 12:35:58 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pc2we-0008dX-8R for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Mar 2023 12:35:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pc2vr-0007Xq-D5; Tue, 14 Mar 2023 07:35:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pc2vp-0007U9-39 for emacs-devel@gnu.org; Tue, 14 Mar 2023 07:35:05 -0400 Original-Received: from sonic306-20.consmr.mail.ne1.yahoo.com ([66.163.189.82]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pc2vm-0002H1-Ou for emacs-devel@gnu.org; Tue, 14 Mar 2023 07:35:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1678793698; bh=13WaJ1iK0rBokfQE142mvcjLHrxvw16BCDrCBUMDUMA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=KMtcP85okYHDx4rCnl8XoJZlupbsqyCy5NGm7xMTtiGoacW6aqna1Cm3OnOM/YPsfk2woCqhK888kZSk9erSxKmfjVqvDaFIqfcbLV/vQHSkNzp9WARtAJSc5CivDonfVZ+VdhlMvqOzbjH10Kf4lWOd/04eMbjMcQoS+z3BfdT8+YhuzpvRndOOJ0cRXIZNNpU8JRQEe/Rv1mnu7iZrAPP8WsDyN7iEWf4LLVNYhYeDHGQQINnO6QtpmX7PqKThhigDiZBkbR+tE2sd9bfgL4PXfVHNv2JniWpFXQgtPbpHpFzfIOdBHLvNHBXkbok7Hue8ltKRXxiEna1xRJJpXw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1678793698; bh=4mr6hc1P2b3M1a5f4n7IXhE0A1CyxLyVTY4ow9W6Ut7=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=R+s9YOXdWSkiudgpxTngJyYGL5RnDR0reeR7y+HBYfs/ddIRb+cQinpKNnxEo+m86LYOGpFXcO2EL7P1/9GcTN9U2PgCV/zNf1SgfXlEPExhINMIMURF2bc+rksM8TydMRPkGzR2DPfEf2sh4nkv23iQNjPyTOQcGatAOPPcFn8tKZ7bX406xgkDgTsdsec9u1+ZTBnVSIXuUOpxxvPyJLLj/jVc3QYWfthMY2msF7JYo6+Eu7MWlN9pFBLZn9irArClGziehwym4vVz63rUFAsJ8PYuLbqCbgpMjD+cnjdZCmQFgUQdhFWnfGOqDCr16IbjBlWADjOArG+HQn+4Kw== X-YMail-OSG: buY9VYMVM1lhP2GG_oXdYwZ.YG8gqw8cXMGxgCtyndHE.EjCfMWrUfjfjQJA3FV LR4r9am9uEoE2rQUjijCrCrneu7QsCfZOVQN9dzbMtF525ZX54eO17z7qHVdGMTFZpWfgy5s9Ncg uXKD3327avXyk0G5S3QXZlmPFkSRhw_y0r8zy8XXzkAqg3TA309HGH30tCYdMg3dk7klJfw4p9A4 w3mO3i0sw7bA_K5ZAHiEnNlIWMit0A5WSG9cZ21.W5k_WJvgDG8yxMpfjRQbPmFelN5Xx387yuaK lSLfX4RBFsUyvvyWZ7oPi9P3CSuqG7vhcBIGTAl0_rNxN30kxLeHGNe2NowB5Kd3HLJQV2jpnGVM OgZXsn3j0SyWrYTY9WcvpKRUmrk1xbCL9P8Fg4AZAPnf.CPyH.ajXVe2sXGgetTXetukCgt7Npm6 8sXUJdD8t24H3bSLapoVT8a4OOl6KVN241MSqzf1cqohbhft.ZYr9nssDJ9m3q29xIvRjBGzgCeA PQwtTNIrvWeqoqPYm7d7GdjjWxea0qs9L.K8xFhasJdH9nRhq7qOamAhSFfP1nwkmbkeD4Ve6pEN GOGfnGmnFbGsO3Schof6YwXr8Vl4XbEf75Skr1pRKdbDc2TqhzXY_Tg11OloEsuKUirl1jets.Lt ifgsEijDOtk5Cuwzz_5j33splF2j4UeKHq7sKkpkoKbXRt64Q7USmydSm50gTzSceouCBuZPoGO8 IQtIuVwvuJOFbeIJiHe.z8NmRYUFgpeCMkxP_x4tDKKVKVqzJi0g2A.KLme6zmNeMdeERZtG4Vmw KakYS6H9FNliBdZnJIJGejWjslPcj6LQl65IkUCmWA X-Sonic-MF: X-Sonic-ID: f676fb13-a857-41eb-986b-cf8fd3142386 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Tue, 14 Mar 2023 11:34:58 +0000 Original-Received: by hermes--production-sg3-67c57bccff-b6t8r (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 43ea891dceeff9a2f285206fafe05235; Tue, 14 Mar 2023 11:34:53 +0000 (UTC) In-Reply-To: <87wn3jtwxg.fsf@gmail.com> (Robert Pluim's message of "Tue, 14 Mar 2023 12:05:47 +0100") X-Mailer: WebService/1.1.21284 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.189.82; envelope-from=luangruo@yahoo.com; helo=sonic306-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304431 Archived-At: Robert Pluim writes: >>>>>> On Tue, 14 Mar 2023 11:47:36 +0100, Robert Pluim said: > >>>>>> On Tue, 14 Mar 2023 18:39:22 +0800, Po Lu said: > >>> most of which are variants of > >>> > >>> Test simple-test-undo-extra-boundary-in-tex backtrace: > >>> signal(error ("Invalid argument macro in `get-device-terminal'")) > >>> apply(signal (error ("Invalid argument macro in `get-device-terminal > > Robert> Po Lu> If you could get a backtrace for this, it would be great. What is > Robert> Po Lu> calling frames-on-display-list? > > Robert> Po Lu> Thanks. > > This fixes 3 of the 4 test failures: > > diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el > index ef0eb1ca108..cdff129b7a8 100644 > --- a/lisp/minibuffer.el > +++ b/lisp/minibuffer.el > @@ -4598,9 +4598,10 @@ minibuffer-setup-on-screen-keyboard > (cancel-timer minibuffer-on-screen-keyboard-timer) > (setq minibuffer-on-screen-keyboard-timer nil)) > (setq minibuffer-on-screen-keyboard-displayed nil) > - (when (not (memq (device-class last-event-frame > + (when (and (not (eq last-event-frame 'macro)) > + (not (memq (device-class last-event-frame > last-event-device) > - '(keyboard core-keyboard))) > + '(keyboard core-keyboard)))) > (setq minibuffer-on-screen-keyboard-displayed > (frame-toggle-on-screen-keyboard (selected-frame) nil)))) > > > Robert Does this work too? Thanks. diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index ef0eb1ca108..b28bbae7c64 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -4598,9 +4598,11 @@ minibuffer-setup-on-screen-keyboard (cancel-timer minibuffer-on-screen-keyboard-timer) (setq minibuffer-on-screen-keyboard-timer nil)) (setq minibuffer-on-screen-keyboard-displayed nil) - (when (not (memq (device-class last-event-frame - last-event-device) - '(keyboard core-keyboard))) + (when (and (framep last-event-frame) + last-event-device + (not (memq (device-class last-event-frame + last-event-device) + '(keyboard core-keyboard)))) (setq minibuffer-on-screen-keyboard-displayed (frame-toggle-on-screen-keyboard (selected-frame) nil))))