From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: calibre.el Date: Tue, 18 Apr 2023 06:05:32 +0000 Message-ID: <87v8ht3etv.fsf@posteo.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1268"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Kjartan =?utf-8?Q?=C3=93li_=C3=81gustsson?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 18 08:06:05 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poeTc-00006d-De for ged-emacs-devel@m.gmane-mx.org; Tue, 18 Apr 2023 08:06:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1poeSl-0001a7-Cc; Tue, 18 Apr 2023 02:05:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1poeSj-0001Zw-I2 for emacs-devel@gnu.org; Tue, 18 Apr 2023 02:05:09 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1poeSg-00048l-CX for emacs-devel@gnu.org; Tue, 18 Apr 2023 02:05:09 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5AE55240302 for ; Tue, 18 Apr 2023 08:05:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1681797902; bh=BvFwDNORaG/d+1/+prhncQkpDYB4cib6n5PdI8apmwY=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=btaMiIh0nr7zMhVYEpSn9ZY3hpyaL9/9/ELo+mThCehKocUud9B3vO9IsyzrGA+Gv cLfTEN8vV11/qDWlLL2w3nA40Mye+yBOJlrvM4DcO0MtZxEwtA1dPlYNX/JXIdz2qt nJ2vjy8SV6WUsZ82UsFafsR6spum5AcrTiS3CPx/BfC/E4RLlBgTmaJy5PvV1oUaia ynKI2kdUMzheVvgmzF8M+aw0QHVuAaH77Qv/Zepj3lXXRz70KQd69dI/cynpDJWoED cXvxBO+10U68UyV8aFwSGrSE7CA4w2NSY8+tdyghg4ICIff57TLShzm0oX46AOj2CI HYyUxGbpA+DIQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Q0tgK6rTsz9rxM; Tue, 18 Apr 2023 08:05:01 +0200 (CEST) In-Reply-To: ("Kjartan =?utf-8?Q?=C3=93li_=C3=81gustsson=22's?= message of "Mon, 17 Apr 2023 23:23:11 +0000") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305398 Archived-At: Kjartan =C3=93li =C3=81gustsson writes: > I am currently working on a package to interact with Calibre > (https://calibre-ebook.com/). The repository can be found here: > https://git.disroot.org/kjartanoli/calibre.el.=20=20 Sounds interesting! > Would there be any > interest in adding it to GNU ELPA? And if so, is my copyright assignment > for Emacs sufficient, or does ELPA require a separate assignment? No separate assignment is necessary, as GNU ELPA packages are regarded to be part of Emacs. > This is my first attempt at writing an Emacs package, so I expect to > have gotten many things wrong. As such I would welcome reviews from > people who know more about Elisp packaging. The first thing to note is that you don't need a -pkg.el file. ELPA will generate one for you using the metadata in the main file and overwrite whatever you have written. This means you should copy the metadata to calibre.el. Especially the dependency list. (Also, why do you depend on "29.1.0", a version which is unreleased and has an additional ".0" at the end? I guess you need Emacs 29 because of SQLite? Have you taken a look at emacsql?) >From a brief skim of the code, it looks more or less fine. There are minor things I am not sure about (such as the usage of eieio or why you declare some functions instead of requiring the file).