From: Ihor Radchenko <yantar92@posteo.net>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: emacs-devel@gnu.org
Subject: Re: Is it valid to call isearch-filter-predicate outside isearch?
Date: Thu, 01 Jun 2023 11:42:25 +0000 [thread overview]
Message-ID: <87v8g79zoe.fsf@localhost> (raw)
In-Reply-To: <87fs7c10cq.fsf@web.de>
Michael Heerdegen <michael_heerdegen@web.de> writes:
>> I am now investigating an Org mode issue related to interaction between
>> Org mode folding and isearch.
>> https://list.orgmode.org/orgmode/CAP7OBx+L11ck3Ni6rv94HGU3otdj6C4rG-rMDzkwR1LTj=BWiw@mail.gmail.com/
>
> The answer to the subject is probably: query-replace is also ok, else
> "no".
AFAIK, at least evil does it:
https://github.com/emacs-evil/evil/blob/be736b8dbc468d53e6cb3e76db66c1141330b030/evil-search.el#L183
I asked them to respect `isearch-mode-end-hook' in
https://github.com/emacs-evil/evil/issues/1630, but after seeing
`query-replace' I started to doubt my confidence.
>> Org mode overrides the default value of isearch-filter-predicate with
>>
>> (defun org-fold-core--isearch-filter-predicate-overlays (beg end)
>> "Return non-nil if text between BEG and END is deemed visible by isearch.
>> This function is intended to be used as `isearch-filter-predicate'."
>> (org-fold-core--create-isearch-overlays beg end) ;; trick isearch by creating overlays in place of invisible text
>> (isearch-filter-visible beg end))
>>
>> As you can see, Org produces side effects when the predicate is
>> called.
>
> (if (org-fold-core-get-folding-spec-property spec :isearch-open)
> (overlay-put o 'isearch-open-invisible #'delete-overlay)
> (overlay-put o 'isearch-open-invisible #'ignore)
> (overlay-put o 'isearch-open-invisible-temporary #'ignore))
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> Can't you bind this to a function that does what you want? AFAIU it is
> called with two arguments - the overlay itself and a bool saying "open"
> (nil) or "re-hide" (non-nil). That should allow to not rely on any
> hooks to remove your helper overlays. Unless, maybe, not all of them
> are opened. Can that happen?
I tried... But it is prohibited to remove overlays when isearch is
tracking them: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60399
Also, closing an overlay does not necessarily mean that isearch is over
- Org cannot yet convert it back to text properties.
That said, the idea is good for other reasons.
> If it does, maybe using `post-command-hook' would be a better choice
> than `isearch-end-hook' (which is, obviously, not a good choice)?
Surely not. `post-command-hook' is triggered after each
`self-insert-command' during isearch/query-replace.
I had to advice `isearch-clean-overlays', which appears to be called by
all the users of `isearch-filter-predicate' (replace-regexp, evil-mode,
and swipet). Still a workaround. Ugly.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=7dee2c07f
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-06-01 11:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-20 14:10 Is it valid to call isearch-filter-predicate outside isearch? Ihor Radchenko
2023-05-22 18:12 ` Juri Linkov
2023-05-31 10:08 ` Ihor Radchenko
2023-05-31 12:44 ` Eli Zaretskii
2023-05-31 12:56 ` Ihor Radchenko
2023-05-31 14:21 ` Eli Zaretskii
2023-05-31 14:38 ` Ihor Radchenko
2023-05-31 15:22 ` [External] : " Drew Adams
2023-06-01 8:10 ` Ihor Radchenko
2023-05-31 23:10 ` Michael Heerdegen
2023-06-01 11:48 ` Ihor Radchenko
2023-06-01 23:30 ` Michael Heerdegen
2023-06-02 8:58 ` Ihor Radchenko
2023-06-01 6:38 ` Juri Linkov
2023-06-01 11:44 ` Ihor Radchenko
2023-05-31 23:17 ` Michael Heerdegen
2023-06-01 5:55 ` Eli Zaretskii
2023-06-01 23:13 ` Michael Heerdegen
2023-06-01 0:40 ` Michael Heerdegen
2023-06-01 11:42 ` Ihor Radchenko [this message]
2023-06-01 16:21 ` Juri Linkov
2023-06-02 8:56 ` Ihor Radchenko
2023-06-01 23:22 ` Michael Heerdegen
2023-06-02 9:07 ` Ihor Radchenko
2023-06-02 13:36 ` [External] : " Drew Adams
2023-06-02 23:06 ` Michael Heerdegen
2023-06-03 8:35 ` Ihor Radchenko
2023-06-04 0:06 ` Michael Heerdegen
2023-06-17 13:05 ` Ihor Radchenko
2023-06-18 2:48 ` Michael Heerdegen
2023-06-18 11:31 ` Ihor Radchenko
2023-06-04 2:06 ` Michael Heerdegen
2023-06-18 10:31 ` Ihor Radchenko
2023-06-18 21:39 ` Michael Heerdegen
2023-06-19 10:44 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8g79zoe.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-devel@gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).