From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: Permanently fix org versioning breakage during builds? Date: Sun, 24 Dec 2023 17:05:10 +0000 Message-ID: <87v88n3515.fsf@localhost> References: <25989.50971.995591.385250@google.com> <87a5q0dc9m.fsf@localhost> <87edfbbyzm.fsf@localhost> <875y0n4px0.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27389"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "T.V Raman" , emacs-devel To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 24 18:02:32 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rHRs0-0006u4-Lx for ged-emacs-devel@m.gmane-mx.org; Sun, 24 Dec 2023 18:02:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rHRrf-00029j-2n; Sun, 24 Dec 2023 12:02:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHRrd-00026L-Ga for emacs-devel@gnu.org; Sun, 24 Dec 2023 12:02:09 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHRra-0001mB-WA for emacs-devel@gnu.org; Sun, 24 Dec 2023 12:02:09 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id A83D2240027 for ; Sun, 24 Dec 2023 18:02:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1703437322; bh=aKkTFNtCBJAUKKaniQOv/kd3gjit1mX4uaEaO6r0CV8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=SWNf4jEUCDkCxrlkADZjRjtjLVGJ7dqCi9fIaeJbQ2l4pRiWNqAEJ40crVvOQBI6V OeVu9q7pI1oaPdCNbI7y7aZT0ulUFJO/JVcsdNGPpolbPs4gkzxQsocDlm7S0iAFv5 lJVqxzZ3HN7uafCJYwuna1K4nHZ4jy49Bt1lmiHrbFNA0vdZCzvMlT/Q5QhK2Uq28k cibH3dIedUcnbYkAUnZFryk2W7ZY/h3hfXs/VV+T/PIQJrHQaxWTweC7iXUv9NZ0ZX LB4/JjmbqMn+JPY7rrHkilIgqzxHDvrsnMzKDMmTW+U89cEuCpoBi0vTDT8aDc74JF kp9g17qCZh9pg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SynQ16qpkz6tm4; Sun, 24 Dec 2023 18:02:01 +0100 (CET) In-Reply-To: Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314149 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > OK, what thing does `org-assert-version` assert and what is one concrete > example of a breakage. Can this unexpected breakage exist if someone > has never ever installed Org mode from ELPA? The assertion is (equal (org-release) ,(org-release)) - assert run-time and compile-time versions of Org equal. And here we are talking about the situation when a user compiles Emacs from git upstream - make will generate a bunch of .elc files that become obsolete if git pull pulls in a new Org version. Then, another make will not re-compile .elc files for the files that remain unchanged, causing version conflict. >> Or, similarly, when built-in Org mode is updated, some macros are >> changed, but their users are not re-compiled, leaving stale macro >> expansions inside .elc files. Again, this causes various breakages. > > Well, this is a problem that is very commonly solved by the technique > I described. But without an example of one member of this "some macros" > set and the example of one of its users in some other file, it's hard > to justify your previous assertion that "the idea will not work". My statement about "the idea will not work" was referring to the `org-assert-version' macro. If we wrap calls to `org-assert-version' into a function, only the file defining that function will be used to derive compile-time Org version. --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at