unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Philip Kaludercic <philipk@posteo.net>
To: Psionic K <psionik@positron.solutions>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: Submitting Dslide to Non-GNU ELPA
Date: Thu, 20 Jun 2024 17:53:23 +0000	[thread overview]
Message-ID: <87v8234i24.fsf@posteo.net> (raw)
In-Reply-To: <CADQMGARvQjv_de1MEBbb8qCv2xfaOqdRJ0bL=wnO4GsVnNGmTA@mail.gmail.com> (Psionic K.'s message of "Fri, 21 Jun 2024 01:16:10 +0900")

Psionic K <psionik@positron.solutions> writes:

>> So you are pretty sure there is no chance your changes could get
>> upstreamed?
>
> I'm sure.  I upstreamed all I intended to.  To support the features I
> wanted, it was necessary to allow the features to diverge, and then
> the implementations, based on org-element API instead of regex and
> matching, became similar only in spirit.  Keeping the org-tree-slide
> commit history intact is more an acknowledgement to Taka and the other
> contributors than something with technical justification.

My main concern is then to have some explanation for people not familiar
with either package (like me) to briefly summarise the main differences
between your package and org-tree-slide, making it easier to decide
which of the two one wants to use.

>> beyond my own eyes
>
> Good eyes.  I barely had time to overcome my favorite butcher shop
> closing down, so I was hoping the quick turnaround meant there is a
> static tool with those behaviors.

Most of my comments are really just superficial observations that anyone
would make with some Elisp familiarity and no prior familiarity with a
codebase.  That being said, if you have any concrete suggestions on how
to implement something, I am glad to comment on that.

-- 
	Philip Kaludercic on peregrine



  reply	other threads:[~2024-06-20 17:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20  6:02 Submitting Dslide to Non-GNU ELPA Psionic K
2024-06-20  8:05 ` Philip Kaludercic
2024-06-20  8:57   ` Psionic K
2024-06-20 13:28     ` Philip Kaludercic
2024-06-20 16:16       ` Psionic K
2024-06-20 17:53         ` Philip Kaludercic [this message]
2024-06-20 23:34           ` Psionic K
2024-06-21  5:55             ` Philip Kaludercic
2024-06-21  6:06               ` Psionic K
2024-06-21  6:59                 ` Philip Kaludercic
2024-06-21  8:55                   ` Psionic K
2024-06-21 13:42                     ` Psionic K
2024-06-21 15:04                     ` Philip Kaludercic
2024-06-22  0:47                       ` Psionic K
2024-07-02 15:41                         ` Psionic K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8234i24.fsf@posteo.net \
    --to=philipk@posteo.net \
    --cc=emacs-devel@gnu.org \
    --cc=psionik@positron.solutions \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).