From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master fcb4d89aaa7 2/3: Prefer `memcpy` to `strcpy` in image.c Date: Tue, 16 Jul 2024 14:21:52 +0200 Message-ID: <87v815cysf.fsf@gmail.com> References: <172109597956.10135.3773889760488581016@vcs2.savannah.gnu.org> <20240716021300.67222C3534C@vcs2.savannah.gnu.org> <87a5iiyrlg.fsf@yahoo.com> <86a5ihir06.fsf@gnu.org> <87cyndsfcp.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14930"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Po Lu , emacs-devel@gnu.org, stefankangas@gmail.com To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 16 14:23:14 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sThD7-0003eo-5d for ged-emacs-devel@m.gmane-mx.org; Tue, 16 Jul 2024 14:23:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sThC0-0004qF-Dx; Tue, 16 Jul 2024 08:22:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sThBx-0004lq-2U for emacs-devel@gnu.org; Tue, 16 Jul 2024 08:22:02 -0400 Original-Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sThBt-0006lj-8s; Tue, 16 Jul 2024 08:21:59 -0400 Original-Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-3680667d831so2230503f8f.3; Tue, 16 Jul 2024 05:21:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721132514; x=1721737314; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=y0M2QSMnyqmhkoNYOM3FncP2sD+34mVr8YyB8Wjj9sY=; b=LRrPZfx2GL3n+f6b35INh64ZtpRs5WX6GBjEfyyaqYzhsr+JVzwG23n9zYELgDEIA0 vXhfSRNh54k9Ov37Nm61wcpwx2ZQxweTidl7oE7hMp5AkTZ5kfyy1EMaEqahALE2up3v RjmavOvxB5ObQOatSQdGnQEV3bPyy6Ns6YYw+lQ73MQ2kaZ15HRAN02ZsVhdKVPV/e81 u+xYnedGazFiQKQYT4wQDeJBUOWvO+U+R9TRu7SRzR2ZdTE3UGLe8/3yBOJxRRovZdrL NMCLJTRJMNZsw+tcBmnpLtl9P6px3wkOmdhUVR4zA6txBocAYLwxSEOBzGgQ+zEDkaoN 37sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721132514; x=1721737314; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y0M2QSMnyqmhkoNYOM3FncP2sD+34mVr8YyB8Wjj9sY=; b=pfxk9mOIVQ6tUf+z/gUynpP9b9QklYpWihG5v1LPuLM2QXJAbFgXDxnV9h4uBijrvK N1KXfwJrsQRfFhgyy/3UlTxrhrPbZZJhTAskGzE0f4TDomFhvewcNBtEK3+7+esRz8NX LTQ/NetSaTplmn/HvyB1UjH4lBoBBkd9SvXJN6BqCpvcT7m+tzwrpSytGiKJNmYFp1aK B0RcbU6PC+9GLTqT6IiJppk16GrkpkcXi75Pl9FOzreQK9ywd6wJNuuuV2jnPVMj/Mn/ OOk4guIS//iFmJZAVMHC7drUes5Sd1yrmnLXyg87p1ytWAM5uOQ6bSrEAxn9E51J9Sz2 +j8g== X-Forwarded-Encrypted: i=1; AJvYcCWr8X4/99C5sjQlzR/tNwcJ2GQfAxvquShzTnsM4NJAJac/pSzJoxL0vrAsuXOFLbTuvsE1XRTjxhcuAxTuCWdRWK9t X-Gm-Message-State: AOJu0YwACST4tpafDcJo/CLvxptt5VRCbpQ38J52AOqiMTymLs/X5dVW HYs7C9TxYnfAJsThfwud/FZZrDwuSTQiTr9ZsblHWpcPbmUPNUv5 X-Google-Smtp-Source: AGHT+IErp20Mp1pha9lZe+fY7uB5Bt5h0g/x4sWD0fNkNaLDPbrlLbMiX/4i/10Cv1QMrQZ2SMVaUQ== X-Received: by 2002:a5d:6186:0:b0:367:8e4f:eeb6 with SMTP id ffacd0b85a97d-36826098cfdmr1287929f8f.4.1721132514224; Tue, 16 Jul 2024 05:21:54 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680daccd68sm8862310f8f.63.2024.07.16.05.21.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 05:21:53 -0700 (PDT) In-Reply-To: <87cyndsfcp.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 16 Jul 2024 12:15:02 +0000") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=rpluim@gmail.com; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321697 Archived-At: >>>>> On Tue, 16 Jul 2024 12:15:02 +0000, Philip Kaludercic said: Philip> Eli Zaretskii writes: >>> From: Po Lu >>> Cc: Stefan Kangas >>> Date: Tue, 16 Jul 2024 10:54:03 +0800 >>>=20 >>> Stefan Kangas writes: >>>=20 >>> > branch: master >>> > commit fcb4d89aaa7bf3ed77aaa4d6d5047a0ec2ed9225 >>> > Author: Stefan Kangas >>> > Commit: Stefan Kangas >>> > >>> > Prefer `memcpy` to `strcpy` in image.c >>>=20 >>> Could we agree not to insert pairs of "``" as quotation marks in co= mmit >>> messages, source code comments, and the like? It gives me the >>> impression of reading a poorly typeset document whose authors were >>> either ignorant of or unwilling to correct directional quotation ma= rks >>> inserted by their input methods. >>=20 >> Our conventions are to quote 'like this' or `like this' in commit log >> messages. Please, everybody, don't use the Markdown-style `like thi= s` >> quoting. Philip> My understanding was that commit logs were to only include 'thi= s this', Philip> while `like this' was only to be used in Elisp docstring and co= mments? I think that falls in the "strongly recommended but not mandatory" category. From CONTRIBUTE: - Emacs follows the GNU coding standards for ChangeLog entries: see https://www.gnu.org/prep/standards/html_node/Change-Logs.html or run 'info "(standards)Change Logs"'. One exception is that commits still sometimes quote `like-this' (as the standards used to recommend) rather than 'like-this' or =E2=80=98like this=E2=80=99 (as= they do now), as `...' is so widely used elsewhere in Emacs. (although I notice that the text allows U+2018 and U+2019 as well) Robert --=20