From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Add elisa to GNU ELPA Date: Wed, 17 Jul 2024 22:12:44 +0000 Message-ID: <87v813fz1f.fsf@posteo.net> References: <8734o9sdig.fsf@posteo.net> <2BA1B431-B60C-471D-9862-540DE7BB24C9@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19226"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Sergey Kostyaev Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 18 00:13:51 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sUCuE-0004Zu-UM for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Jul 2024 00:13:50 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sUCtM-00059R-9n; Wed, 17 Jul 2024 18:12:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sUCtK-000590-WC for emacs-devel@gnu.org; Wed, 17 Jul 2024 18:12:55 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sUCtJ-0004Ps-7G for emacs-devel@gnu.org; Wed, 17 Jul 2024 18:12:54 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 2593E240028 for ; Thu, 18 Jul 2024 00:12:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1721254367; bh=kQ+YzESVrYKF2YWbaOUaYrkpuxRdG3jdzDIPa4OVimA=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=L8wPJ7GN2z6KpNzcl2/WBy7ILYODHsnl9hhj3q4eVNlurHotuDVzXTWBs4CVUJ8n4 KVmfHyKl8NxPhkjXJsp4ARaX3uQyENJ0LxvYnfW4fgSyDWlLjhEn4dV13rNT6K5ztt Ub2jlwa1t/pMEFjv25mEmKZHU4Xt5ms30LczY1iRLXyzlbMhuZTeYpZutAFI5LMI+y UKlMeAKiCzEkgeiawGWfSnZYo/dab5aMe+/NYeDbVlq7vdFPpCUeRsZVouN3sUKJYt kU5/c5wGSrSB/gVJcQqWQFiLPCs8ebTJTwuTNdN/UIOXZMyOtAR0cbSb/rl/ntAsth 6R/5WxVUQ1LVA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WPVYV1WWpz9rxF; Thu, 18 Jul 2024 00:12:44 +0200 (CEST) In-Reply-To: <2BA1B431-B60C-471D-9862-540DE7BB24C9@gmail.com> (Sergey Kostyaev's message of "Thu, 18 Jul 2024 04:26:23 +0700") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321765 Archived-At: Sergey Kostyaev writes: > I have fixed review issues and improve package documentation. Philip, please see one more time. I admit I was lazy; there are a few SQL strings that could still upcased. A general question I have is why you depend on Emacs 29.2? Package-lint indicates that you don't need anything before 28.1, with the exception of the SQLite integration, which would mean you could reduce the minimal version to 29.1. Otherwise I guess it looks fine, I'll add it to elpa.git. > Best regards, > Sergey Kostyaev > -- Philip Kaludercic on peregrine