* Re: master 644d2a83316 1/2: Fix early use of use-package-always-ensure
[not found] ` <20240819235727.648FFC1F9E8@vcs2.savannah.gnu.org>
@ 2024-08-22 20:15 ` john muhl
2024-09-01 9:32 ` Stefan Kangas
0 siblings, 1 reply; 2+ messages in thread
From: john muhl @ 2024-08-22 20:15 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Kangas
[-- Attachment #1: Type: text/plain, Size: 61 bytes --]
This commit caused some use-package tests to start failing.
[-- Attachment #2: use-package-tests.log --]
[-- Type: text/plain, Size: 27634 bytes --]
Running 166 tests (2024-08-22 15:11:49-0500, selector `(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))')
test-map (keymap #^[nil nil keymap nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil] (f1 . ignore))
binding ((<f1> . test-map) ignore nil)
passed 1/166 bind-key/845 (0.000243 sec)
passed 2/166 bind-key/:prefix-map (0.000061 sec)
passed 3/166 use-package-test-handler/:vc-6 (0.000106 sec)
passed 4/166 use-package-test-normalize-function (0.000116 sec)
passed 5/166 use-package-test-normalize/:bind-1 (0.000049 sec)
passed 6/166 use-package-test-normalize/:bind-2 (0.000051 sec)
passed 7/166 use-package-test-normalize/:bind-3 (0.000064 sec)
passed 8/166 use-package-test-normalize/:custom (0.000109 sec)
passed 9/166 use-package-test-normalize/:delight (0.000138 sec)
passed 10/166 use-package-test-normalize/:diminish (0.000085 sec)
passed 11/166 use-package-test-normalize/:ensure (0.000117 sec)
passed 12/166 use-package-test-normalize/:hook (0.000154 sec)
passed 13/166 use-package-test-normalize/:mode (0.000109 sec)
passed 14/166 use-package-test-normalize/:vc (0.000193 sec)
passed 15/166 use-package-test-recognize-function (0.000133 sec)
passed 16/166 use-package-test/334-1 (0.000075 sec)
passed 17/166 use-package-test/334-2 (0.000041 sec)
passed 18/166 use-package-test/482-1 (0.000153 sec)
passed 19/166 use-package-test/482-2 (0.000149 sec)
passed 20/166 use-package-test/482-3 (0.000060 sec)
passed 21/166 use-package-test/538 (0.000133 sec)
passed 22/166 use-package-test/543 (0.000101 sec)
passed 23/166 use-package-test/545 (0.000100 sec)
passed 24/166 use-package-test/550 (0.000126 sec)
passed 25/166 use-package-test/558 (0.000057 sec)
passed 26/166 use-package-test/560 (0.000188 sec)
passed 27/166 use-package-test/572-1 (0.000103 sec)
passed 28/166 use-package-test/572-2 (0.000094 sec)
passed 29/166 use-package-test/572-3 (0.000102 sec)
passed 30/166 use-package-test/575-1 (0.000139 sec)
passed 31/166 use-package-test/575-2 (0.000120 sec)
passed 32/166 use-package-test/585 (0.000136 sec)
passed 33/166 use-package-test/589 (0.000106 sec)
passed 34/166 use-package-test/591 (0.000144 sec)
passed 35/166 use-package-test/:after-1 (0.000081 sec)
passed 36/166 use-package-test/:after-10 (0.000179 sec)
passed 37/166 use-package-test/:after-2 (0.000109 sec)
passed 38/166 use-package-test/:after-3 (0.000095 sec)
passed 39/166 use-package-test/:after-4 (0.000087 sec)
passed 40/166 use-package-test/:after-5 (0.000140 sec)
passed 41/166 use-package-test/:after-6 (0.000142 sec)
passed 42/166 use-package-test/:after-7 (0.000133 sec)
passed 43/166 use-package-test/:after-8 (0.000202 sec)
passed 44/166 use-package-test/:after-9 (0.000148 sec)
passed 45/166 use-package-test/:autoload-1 (0.000104 sec)
passed 46/166 use-package-test/:bind*-1 (0.000123 sec)
passed 47/166 use-package-test/:bind-1 (0.000115 sec)
passed 48/166 use-package-test/:bind-2 (0.000114 sec)
passed 49/166 use-package-test/:bind-3 (0.000134 sec)
passed 50/166 use-package-test/:bind-4 (0.000088 sec)
passed 51/166 use-package-test/:bind-5 (0.000127 sec)
passed 52/166 use-package-test/:bind-6 (0.000135 sec)
passed 53/166 use-package-test/:bind-7 (0.000127 sec)
passed 54/166 use-package-test/:bind-8 (0.000143 sec)
passed 55/166 use-package-test/:bind-keymap*-1 (0.000109 sec)
passed 56/166 use-package-test/:bind-keymap-1 (0.000088 sec)
passed 57/166 use-package-test/:catch-1 (0.000110 sec)
passed 58/166 use-package-test/:catch-2 (0.000097 sec)
passed 59/166 use-package-test/:catch-3 (0.000106 sec)
passed 60/166 use-package-test/:commands-1 (0.000097 sec)
passed 61/166 use-package-test/:commands-2 (0.000080 sec)
passed 62/166 use-package-test/:commands-3 (0.000119 sec)
passed 63/166 use-package-test/:commands-4 (0.000100 sec)
passed 64/166 use-package-test/:commands-5 (0.000148 sec)
passed 65/166 use-package-test/:commands-6 (0.000155 sec)
passed 66/166 use-package-test/:config-1 (0.000084 sec)
passed 67/166 use-package-test/:config-2 (0.000100 sec)
passed 68/166 use-package-test/:config-3 (0.000087 sec)
passed 69/166 use-package-test/:config-4 (0.000087 sec)
passed 70/166 use-package-test/:custom-1 (0.000091 sec)
passed 71/166 use-package-test/:custom-face-1 (0.000081 sec)
passed 72/166 use-package-test/:custom-face-2 (0.000096 sec)
passed 73/166 use-package-test/:custom-face-3 (0.000099 sec)
passed 74/166 use-package-test/:custom-with-comment1 (0.000089 sec)
passed 75/166 use-package-test/:defer-1 (0.000080 sec)
passed 76/166 use-package-test/:defer-2 (0.000093 sec)
passed 77/166 use-package-test/:defer-3 (0.000098 sec)
passed 78/166 use-package-test/:defer-4 (0.000093 sec)
passed 79/166 use-package-test/:defines-1 (0.000087 sec)
passed 80/166 use-package-test/:defines-2 (0.000108 sec)
passed 81/166 use-package-test/:delight-1 (0.000088 sec)
passed 82/166 use-package-test/:delight-2 (0.000095 sec)
passed 83/166 use-package-test/:delight-3 (0.000096 sec)
passed 84/166 use-package-test/:delight-4 (0.000091 sec)
passed 85/166 use-package-test/:delight-5 (0.000087 sec)
passed 86/166 use-package-test/:delight-6 (0.000082 sec)
passed 87/166 use-package-test/:demand-1 (0.000098 sec)
passed 88/166 use-package-test/:demand-2 (0.000114 sec)
passed 89/166 use-package-test/:demand-3 (0.000112 sec)
passed 90/166 use-package-test/:demand-4 (0.000120 sec)
passed 91/166 use-package-test/:demand-5 (0.000096 sec)
passed 92/166 use-package-test/:demand-6 (0.000109 sec)
Test use-package-test/:demand-7 backtrace:
signal(ert-test-failed (((should (pcase (expand-minimally (use-packa
ert-fail(((should (pcase (expand-minimally (use-package counsel :loa
(if (unwind-protect (setq value-1389 (let* ((val (let (... ...) (mac
(let (form-description-1390) (if (unwind-protect (setq value-1389 (l
(let ((value-1389 (gensym "ert-form-evaluation-aborted-"))) (let (fo
#f(lambda () [t] (let ((value-1389 (gensym "ert-form-evaluation-abor
#f(compiled-function () #<bytecode -0xa2d6579ff388130>)()
handler-bind-1(#f(compiled-function () #<bytecode -0xa2d6579ff388130
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name use-package-test/:demand-7 :documenta
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
command-line()
normal-top-level()
Test use-package-test/:demand-7 condition:
(ert-test-failed
((should (pcase (expand-minimally ...) (... t))) :form
(let* ((val ...)) (if (consp val) (let* ... ...))) :value nil))
FAILED 93/166 use-package-test/:demand-7 (0.000353 sec) at lisp/use-package/use-package-tests.el:1432
Test use-package-test/:diminish-1 backtrace:
signal(ert-test-failed (((should (pcase (expand-minimally (use-packa
ert-fail(((should (pcase (expand-minimally (use-package foo :diminis
(if (unwind-protect (setq value-1424 (let* ((val (let (... ...) (mac
(let (form-description-1425) (if (unwind-protect (setq value-1424 (l
(let ((value-1424 (gensym "ert-form-evaluation-aborted-"))) (let (fo
#f(lambda () [t] (let ((value-1424 (gensym "ert-form-evaluation-abor
#f(compiled-function () #<bytecode -0xa2d6579ff388130>)()
handler-bind-1(#f(compiled-function () #<bytecode -0xa2d6579ff388130
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name use-package-test/:diminish-1 :documen
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
command-line()
normal-top-level()
Test use-package-test/:diminish-1 condition:
(ert-test-failed
((should (pcase (expand-minimally ...) (... t))) :form
(let* ((val ...)) (if (equal val ...) (let nil t))) :value nil))
FAILED 94/166 use-package-test/:diminish-1 (0.000216 sec) at lisp/use-package/use-package-tests.el:1522
Test use-package-test/:diminish-2 backtrace:
signal(ert-test-failed (((should (pcase (expand-minimally (use-packa
ert-fail(((should (pcase (expand-minimally (use-package foo :diminis
(if (unwind-protect (setq value-1426 (let* ((val (let (... ...) (mac
(let (form-description-1427) (if (unwind-protect (setq value-1426 (l
(let ((value-1426 (gensym "ert-form-evaluation-aborted-"))) (let (fo
#f(lambda () [t] (let ((value-1426 (gensym "ert-form-evaluation-abor
#f(compiled-function () #<bytecode -0xa2d6579ff388130>)()
handler-bind-1(#f(compiled-function () #<bytecode -0xa2d6579ff388130
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name use-package-test/:diminish-2 :documen
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
command-line()
normal-top-level()
Test use-package-test/:diminish-2 condition:
(ert-test-failed
((should (pcase (expand-minimally ...) (... t))) :form
(let* ((val ...)) (if (equal val ...) (let nil t))) :value nil))
FAILED 95/166 use-package-test/:diminish-2 (0.000179 sec) at lisp/use-package/use-package-tests.el:1530
Test use-package-test/:diminish-3 backtrace:
signal(ert-test-failed (((should (pcase (expand-minimally (use-packa
ert-fail(((should (pcase (expand-minimally (use-package foo :diminis
(if (unwind-protect (setq value-1428 (let* ((val (let (... ...) (mac
(let (form-description-1429) (if (unwind-protect (setq value-1428 (l
(let ((value-1428 (gensym "ert-form-evaluation-aborted-"))) (let (fo
#f(lambda () [t] (let ((value-1428 (gensym "ert-form-evaluation-abor
#f(compiled-function () #<bytecode -0xa2d6579ff388130>)()
handler-bind-1(#f(compiled-function () #<bytecode -0xa2d6579ff388130
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name use-package-test/:diminish-3 :documen
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
command-line()
normal-top-level()
Test use-package-test/:diminish-3 condition:
(ert-test-failed
((should (pcase (expand-minimally ...) (... t))) :form
(let* ((val ...)) (if (equal val ...) (let nil t))) :value nil))
FAILED 96/166 use-package-test/:diminish-3 (0.000288 sec) at lisp/use-package/use-package-tests.el:1538
Test use-package-test/:diminish-4 backtrace:
signal(ert-test-failed (((should (pcase (expand-minimally (use-packa
ert-fail(((should (pcase (expand-minimally (use-package foo :diminis
(if (unwind-protect (setq value-1430 (let* ((val (let (... ...) (mac
(let (form-description-1431) (if (unwind-protect (setq value-1430 (l
(let ((value-1430 (gensym "ert-form-evaluation-aborted-"))) (let (fo
#f(lambda () [t] (let ((value-1430 (gensym "ert-form-evaluation-abor
#f(compiled-function () #<bytecode -0xa2d6579ff388130>)()
handler-bind-1(#f(compiled-function () #<bytecode -0xa2d6579ff388130
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name use-package-test/:diminish-4 :documen
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
command-line()
normal-top-level()
Test use-package-test/:diminish-4 condition:
(ert-test-failed
((should (pcase (expand-minimally ...) (... t))) :form
(let* ((val ...)) (if (equal val ...) (let nil t))) :value nil))
FAILED 97/166 use-package-test/:diminish-4 (0.000224 sec) at lisp/use-package/use-package-tests.el:1546
passed 98/166 use-package-test/:disabled-1 (0.000091 sec)
passed 99/166 use-package-test/:ensure-1 (0.000132 sec)
Test use-package-test/:ensure-10 backtrace:
signal(ert-test-failed (((should (pcase (expand-minimally (use-packa
ert-fail(((should (pcase (expand-minimally (use-package foo :ensure
(if (unwind-protect (setq value-258 (let* ((val (let (... ...) (macr
(let (form-description-259) (if (unwind-protect (setq value-258 (let
(let ((value-258 (gensym "ert-form-evaluation-aborted-"))) (let (for
(let ((use-package-always-ensure t)) (let ((value-258 (gensym "ert-f
#f(lambda () [t] (let ((use-package-always-ensure t)) (let ((value-2
#f(compiled-function () #<bytecode -0xa2d6579ff388130>)()
handler-bind-1(#f(compiled-function () #<bytecode -0xa2d6579ff388130
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name use-package-test/:ensure-10 :document
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
command-line()
normal-top-level()
Test use-package-test/:ensure-10 condition:
(ert-test-failed
((should (pcase (expand-minimally ...) (... t))) :form
(let* ((val ...)) (if (consp val) (let* ... ...))) :value nil))
FAILED 100/166 use-package-test/:ensure-10 (0.000205 sec) at lisp/use-package/use-package-tests.el:307
passed 101/166 use-package-test/:ensure-11 (0.000177 sec)
passed 102/166 use-package-test/:ensure-12 (0.000155 sec)
passed 103/166 use-package-test/:ensure-13 (0.000135 sec)
Test use-package-test/:ensure-14 backtrace:
signal(ert-test-failed (((should (pcase (expand-minimally (use-packa
ert-fail(((should (pcase (expand-minimally (use-package ess-site :en
(if (unwind-protect (setq value-269 (let* ((val (let (... ...) (macr
(let (form-description-270) (if (unwind-protect (setq value-269 (let
(let ((value-269 (gensym "ert-form-evaluation-aborted-"))) (let (for
#f(lambda () [t] (let ((value-269 (gensym "ert-form-evaluation-abort
#f(compiled-function () #<bytecode -0xa2d6579ff388130>)()
handler-bind-1(#f(compiled-function () #<bytecode -0xa2d6579ff388130
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name use-package-test/:ensure-14 :document
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
command-line()
normal-top-level()
Test use-package-test/:ensure-14 condition:
(ert-test-failed
((should (pcase (expand-minimally ...) (... t))) :form
(let* ((val ...)) (if (equal val ...) (let nil t))) :value nil))
FAILED 104/166 use-package-test/:ensure-14 (0.000243 sec) at lisp/use-package/use-package-tests.el:343
Test use-package-test/:ensure-15 backtrace:
signal(ert-test-failed (((should (pcase (expand-minimally (use-packa
ert-fail(((should (pcase (expand-minimally (use-package foo :pin "el
(if (unwind-protect (setq value-271 (let* ((val (let (... ...) (macr
(let (form-description-272) (if (unwind-protect (setq value-271 (let
(let ((value-271 (gensym "ert-form-evaluation-aborted-"))) (let (for
(let ((use-package-always-ensure t)) (let ((value-271 (gensym "ert-f
#f(lambda () [t] (let ((use-package-always-ensure t)) (let ((value-2
#f(compiled-function () #<bytecode -0xa2d6579ff388130>)()
handler-bind-1(#f(compiled-function () #<bytecode -0xa2d6579ff388130
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name use-package-test/:ensure-15 :document
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
command-line()
normal-top-level()
Test use-package-test/:ensure-15 condition:
(ert-test-failed
((should (pcase (expand-minimally ...) (... t))) :form
(let* ((val ...)) (if (equal val ...) (let nil t))) :value nil))
FAILED 105/166 use-package-test/:ensure-15 (0.000198 sec) at lisp/use-package/use-package-tests.el:358
passed 106/166 use-package-test/:ensure-2 (0.000191 sec)
passed 107/166 use-package-test/:ensure-3 (0.000146 sec)
passed 108/166 use-package-test/:ensure-4 (0.000123 sec)
passed 109/166 use-package-test/:ensure-5 (0.000153 sec)
passed 110/166 use-package-test/:ensure-6 (0.000130 sec)
Test use-package-test/:ensure-7 backtrace:
signal(ert-test-failed (((should (pcase (expand-minimally (use-packa
ert-fail(((should (pcase (expand-minimally (use-package foo :ensure
(if (unwind-protect (setq value-204 (let* ((val (let (... ...) (macr
(let (form-description-205) (if (unwind-protect (setq value-204 (let
(let ((value-204 (gensym "ert-form-evaluation-aborted-"))) (let (for
(let ((use-package-always-ensure nil)) (let ((value-204 (gensym "ert
#f(lambda () [t] (let ((use-package-always-ensure nil)) (let ((value
#f(compiled-function () #<bytecode -0xa2d6579ff388130>)()
handler-bind-1(#f(compiled-function () #<bytecode -0xa2d6579ff388130
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name use-package-test/:ensure-7 :documenta
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
command-line()
normal-top-level()
Test use-package-test/:ensure-7 condition:
(ert-test-failed
((should (pcase (expand-minimally ...) (... t))) :form
(let* ((val ...)) (if (consp val) (let* ... ...))) :value nil))
FAILED 111/166 use-package-test/:ensure-7 (0.000187 sec) at lisp/use-package/use-package-tests.el:277
Test use-package-test/:ensure-8 backtrace:
signal(ert-test-failed (((should (pcase (expand-minimally (use-packa
ert-fail(((should (pcase (expand-minimally (use-package foo :ensure
(if (unwind-protect (setq value-222 (let* ((val (let (... ...) (macr
(let (form-description-223) (if (unwind-protect (setq value-222 (let
(let ((value-222 (gensym "ert-form-evaluation-aborted-"))) (let (for
(let ((use-package-always-ensure t)) (let ((value-222 (gensym "ert-f
#f(lambda () [t] (let ((use-package-always-ensure t)) (let ((value-2
#f(compiled-function () #<bytecode -0xa2d6579ff388130>)()
handler-bind-1(#f(compiled-function () #<bytecode -0xa2d6579ff388130
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name use-package-test/:ensure-8 :documenta
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
command-line()
normal-top-level()
Test use-package-test/:ensure-8 condition:
(ert-test-failed
((should (pcase (expand-minimally ...) (... t))) :form
(let* ((val ...)) (if (consp val) (let* ... ...))) :value nil))
FAILED 112/166 use-package-test/:ensure-8 (0.000194 sec) at lisp/use-package/use-package-tests.el:287
Test use-package-test/:ensure-9 backtrace:
signal(ert-test-failed (((should (pcase (expand-minimally (use-packa
ert-fail(((should (pcase (expand-minimally (use-package foo :ensure
(if (unwind-protect (setq value-240 (let* ((val (let (... ...) (macr
(let (form-description-241) (if (unwind-protect (setq value-240 (let
(let ((value-240 (gensym "ert-form-evaluation-aborted-"))) (let (for
(let ((use-package-always-ensure nil)) (let ((value-240 (gensym "ert
#f(lambda () [t] (let ((use-package-always-ensure nil)) (let ((value
#f(compiled-function () #<bytecode -0xa2d6579ff388130>)()
handler-bind-1(#f(compiled-function () #<bytecode -0xa2d6579ff388130
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name use-package-test/:ensure-9 :documenta
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
command-line()
normal-top-level()
Test use-package-test/:ensure-9 condition:
(ert-test-failed
((should (pcase (expand-minimally ...) (... t))) :form
(let* ((val ...)) (if (consp val) (let* ... ...))) :value nil))
FAILED 113/166 use-package-test/:ensure-9 (0.000251 sec) at lisp/use-package/use-package-tests.el:297
passed 114/166 use-package-test/:functions-1 (0.000190 sec)
passed 115/166 use-package-test/:functions-2 (0.000127 sec)
passed 116/166 use-package-test/:functions-3 (0.000110 sec)
passed 117/166 use-package-test/:functions-4 (0.000130 sec)
passed 118/166 use-package-test/:functions-5 (0.000122 sec)
passed 119/166 use-package-test/:hook-1 (0.000198 sec)
passed 120/166 use-package-test/:hook-2 (0.000146 sec)
passed 121/166 use-package-test/:hook-3 (0.000147 sec)
passed 122/166 use-package-test/:hook-4 (0.000129 sec)
passed 123/166 use-package-test/:hook-5 (0.000188 sec)
passed 124/166 use-package-test/:hook-6 (0.000220 sec)
passed 125/166 use-package-test/:hook-7 (0.000154 sec)
passed 126/166 use-package-test/:if-1 (0.000094 sec)
passed 127/166 use-package-test/:if-2 (0.000086 sec)
passed 128/166 use-package-test/:if-3 (0.000095 sec)
passed 129/166 use-package-test/:init-1 (0.000091 sec)
passed 130/166 use-package-test/:init-2 (0.000103 sec)
passed 131/166 use-package-test/:interpreter-1 (0.000126 sec)
passed 132/166 use-package-test/:interpreter-2 (0.000121 sec)
passed 133/166 use-package-test/:load-path-1 (0.000160 sec)
passed 134/166 use-package-test/:load-path-2 (0.000147 sec)
passed 135/166 use-package-test/:load-path-3 (0.000216 sec)
passed 136/166 use-package-test/:load-path-4 (0.000183 sec)
passed 137/166 use-package-test/:magic-1 (0.000110 sec)
passed 138/166 use-package-test/:magic-2 (0.000123 sec)
passed 139/166 use-package-test/:magic-fallback-1 (0.000129 sec)
passed 140/166 use-package-test/:magic-fallback-2 (0.000108 sec)
passed 141/166 use-package-test/:mode-1 (0.000120 sec)
passed 142/166 use-package-test/:mode-2 (0.000103 sec)
passed 143/166 use-package-test/:no-require-1 (0.000087 sec)
passed 144/166 use-package-test/:no-require-2 (0.000089 sec)
passed 145/166 use-package-test/:no-require-3 (0.000085 sec)
passed 146/166 use-package-test/:pin-1 (0.000093 sec)
passed 147/166 use-package-test/:pin-2 (0.000101 sec)
passed 148/166 use-package-test/:preface-1 (0.000091 sec)
passed 149/166 use-package-test/:preface-2 (0.000095 sec)
passed 150/166 use-package-test/:preface-3 (0.000118 sec)
passed 151/166 use-package-test/:preface-4 (0.000126 sec)
passed 152/166 use-package-test/:requires-1 (0.000095 sec)
passed 153/166 use-package-test/:requires-2 (0.000116 sec)
passed 154/166 use-package-test/:requires-3 (0.000098 sec)
passed 155/166 use-package-test/:requires-4 (0.000106 sec)
passed 156/166 use-package-test/:unless-1 (0.000093 sec)
passed 157/166 use-package-test/:unless-2 (0.000083 sec)
passed 158/166 use-package-test/:unless-3 (0.000092 sec)
passed 159/166 use-package-test/:vc-1 (0.000095 sec)
passed 160/166 use-package-test/:vc-2 (0.000115 sec)
passed 161/166 use-package-test/:vc-3 (0.000096 sec)
passed 162/166 use-package-test/:vc-4 (0.000097 sec)
passed 163/166 use-package-test/:vc-5 (0.000153 sec)
passed 164/166 use-package-test/:when-1 (0.000086 sec)
passed 165/166 use-package-test/:when-2 (0.000089 sec)
passed 166/166 use-package-test/:when-3 (0.000089 sec)
Ran 166 tests, 155 results as expected, 11 unexpected (2024-08-22 15:11:50-0500, 1.049032 sec)
11 unexpected results:
FAILED use-package-test/:demand-7
FAILED use-package-test/:diminish-1
FAILED use-package-test/:diminish-2
FAILED use-package-test/:diminish-3
FAILED use-package-test/:diminish-4
FAILED use-package-test/:ensure-10
FAILED use-package-test/:ensure-14
FAILED use-package-test/:ensure-15
FAILED use-package-test/:ensure-7
FAILED use-package-test/:ensure-8
FAILED use-package-test/:ensure-9
[-- Attachment #3: Type: text/plain, Size: 8994 bytes --]
Stefan Kangas <stefankangas@gmail.com> writes:
> branch: master
> commit 644d2a8331670cc8068c914d86993a17d0efbc96
> Author: Stefan Kangas <stefankangas@gmail.com>
> Commit: Stefan Kangas <stefankangas@gmail.com>
>
> Fix early use of use-package-always-ensure
>
> * lisp/use-package/use-package-core.el:
> * lisp/use-package/use-package-delight.el:
> * lisp/use-package/use-package-diminish.el:
> * lisp/use-package/use-package-ensure.el: Move add-to-list for
> 'use-package-keywords' and 'use-package-defaults' from here...
> * lisp/use-package/use-package-core.el (use-package-ensure)
> (use-package-keywords): ...to the default definition here.
>
> * lisp/use-package/use-package-ensure.el
> (use-package-ensure): Move this defgroup...
> (use-package-always-ensure)
> (use-package-always-pin, use-package-ensure-function): ...and
> these defcustoms from here...
> * lisp/use-package/use-package-core.el (use-package-ensure)
> (use-package-always-ensure, use-package-always-pin)
> (use-package-ensure-function): ...to here. (Bug#72453)
> ---
> lisp/use-package/use-package-core.el | 56 ++++++++++++++++++++++++++++++--
> lisp/use-package/use-package-delight.el | 2 --
> lisp/use-package/use-package-diminish.el | 2 --
> lisp/use-package/use-package-ensure.el | 48 ---------------------------
> 4 files changed, 53 insertions(+), 55 deletions(-)
>
> diff --git a/lisp/use-package/use-package-core.el b/lisp/use-package/use-package-core.el
> index 8c3241d5ee0..e5925a294d1 100644
> --- a/lisp/use-package/use-package-core.el
> +++ b/lisp/use-package/use-package-core.el
> @@ -65,6 +65,12 @@
> :link '(custom-manual "(use-package) Top")
> :version "29.1")
>
> +(defgroup use-package-ensure nil
> + "Support for :ensure and :pin keywords in `use-package' declarations."
> + :group 'use-package
> + :link '(custom-manual "(use-package) Installing packages")
> + :version "29.1")
> +
> (defconst use-package-version "2.4.5"
> "This version of `use-package'.")
>
> @@ -76,6 +82,10 @@
> :functions
> :preface
> :if :when :unless
> + :ensure
> + :pin
> + :delight
> + :diminish
> :vc
> :no-require
> :catch
> @@ -114,7 +124,8 @@ Note that `:disabled' is special in this list, as it causes
> nothing at all to happen, even if the rest of the `use-package'
> declaration is incorrect."
> :type '(repeat symbol)
> - :group 'use-package)
> + :group 'use-package
> + :version "30.1")
>
> (defcustom use-package-deferring-keywords
> '(:bind-keymap
> @@ -189,7 +200,12 @@ See also `use-package-defaults', which uses this value."
> (lambda (name args)
> (and use-package-always-demand
> (not (plist-member args :defer))
> - (not (plist-member args :demand))))))
> + (not (plist-member args :demand)))))
> + (:ensure (list use-package-always-ensure)
> + (lambda (name args)
> + (and use-package-always-ensure
> + (not (plist-member args :load-path)))))
> + (:pin use-package-always-pin use-package-always-pin))
> "Default values for specified `use-package' keywords.
> Each entry in the alist is a list of three elements:
> The first element is the `use-package' keyword.
> @@ -214,7 +230,8 @@ attempted."
> (list (symbol :tag "Keyword")
> (choice :tag "Default value" sexp function)
> (choice :tag "Enable if non-nil" sexp function)))
> - :group 'use-package)
> + :group 'use-package
> + :version "30.1")
>
> (defcustom use-package-merge-key-alist
> '((:if . (lambda (new old) `(and ,new ,old)))
> @@ -360,6 +377,39 @@ stability issues."
> :version "30.1"
> :group 'use-package)
>
> +(defcustom use-package-always-ensure nil
> + "Treat every package as though it had specified using `:ensure SEXP'.
> +See also `use-package-defaults', which uses this value."
> + :type 'sexp
> + :group 'use-package-ensure
> + :version "29.1")
> +
> +(defcustom use-package-always-pin nil
> + "Treat every package as though it had specified using `:pin SYM'.
> +See also `use-package-defaults', which uses this value."
> + :type 'symbol
> + :group 'use-package-ensure
> + :version "29.1")
> +
> +(defcustom use-package-ensure-function 'use-package-ensure-elpa
> + "Function that ensures a package is installed.
> +This function is called with three arguments: the name of the
> +package declared in the `use-package' form; the arguments passed
> +to all `:ensure' keywords (always a list, even if only one); and
> +the current `state' plist created by previous handlers.
> +
> +Note that this function is called whenever `:ensure' is provided,
> +even if it is nil. It is up to the function to decide on the
> +semantics of the various values for `:ensure'.
> +
> +This function should return non-nil if the package is installed.
> +
> +The default value uses package.el to install the package."
> + :type '(choice (const :tag "package.el" use-package-ensure-elpa)
> + (function :tag "Custom"))
> + :group 'use-package-ensure
> + :version "29.1")
> +
> (defvar use-package-statistics (make-hash-table))
>
> ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
> diff --git a/lisp/use-package/use-package-delight.el b/lisp/use-package/use-package-delight.el
> index c458d263cf0..c67e2aa6320 100644
> --- a/lisp/use-package/use-package-delight.el
> +++ b/lisp/use-package/use-package-delight.el
> @@ -81,8 +81,6 @@
> `((if (fboundp 'delight)
> (delight '(,@args)))))))
>
> -(add-to-list 'use-package-keywords :delight t)
> -
> (provide 'use-package-delight)
>
> ;;; use-package-delight.el ends here
> diff --git a/lisp/use-package/use-package-diminish.el b/lisp/use-package/use-package-diminish.el
> index 79421a0e273..0be2ba688a0 100644
> --- a/lisp/use-package/use-package-diminish.el
> +++ b/lisp/use-package/use-package-diminish.el
> @@ -70,8 +70,6 @@
> arg)
> body)))
>
> -(add-to-list 'use-package-keywords :diminish t)
> -
> (provide 'use-package-diminish)
>
> ;;; use-package-diminish.el ends here
> diff --git a/lisp/use-package/use-package-ensure.el b/lisp/use-package/use-package-ensure.el
> index 5f75b6b59ea..82ab3256ef0 100644
> --- a/lisp/use-package/use-package-ensure.el
> +++ b/lisp/use-package/use-package-ensure.el
> @@ -32,46 +32,10 @@
> (require 'cl-lib)
> (require 'use-package-core)
>
> -(defgroup use-package-ensure nil
> - "Support for :ensure and :pin keywords in `use-package' declarations."
> - :group 'use-package
> - :link '(custom-manual "(use-package) Installing packages")
> - :version "29.1")
> -
> (eval-when-compile
> (declare-function package-installed-p "package")
> (declare-function package-read-all-archive-contents "package" ()))
>
> -(defcustom use-package-always-ensure nil
> - "Treat every package as though it had specified using `:ensure SEXP'.
> -See also `use-package-defaults', which uses this value."
> - :type 'sexp
> - :group 'use-package-ensure)
> -
> -(defcustom use-package-always-pin nil
> - "Treat every package as though it had specified using `:pin SYM'.
> -See also `use-package-defaults', which uses this value."
> - :type 'symbol
> - :group 'use-package-ensure)
> -
> -(defcustom use-package-ensure-function 'use-package-ensure-elpa
> - "Function that ensures a package is installed.
> -This function is called with three arguments: the name of the
> -package declared in the `use-package' form; the arguments passed
> -to all `:ensure' keywords (always a list, even if only one); and
> -the current `state' plist created by previous handlers.
> -
> -Note that this function is called whenever `:ensure' is provided,
> -even if it is nil. It is up to the function to decide on the
> -semantics of the various values for `:ensure'.
> -
> -This function should return non-nil if the package is installed.
> -
> -The default value uses package.el to install the package."
> - :type '(choice (const :tag "package.el" use-package-ensure-elpa)
> - (function :tag "Custom"))
> - :group 'use-package-ensure)
> -
> ;;;; :pin
>
> (defun use-package-normalize/:pin (_name keyword args)
> @@ -196,18 +160,6 @@ manually updated package."
> body))
> body))
>
> -(add-to-list 'use-package-defaults
> - '(:ensure (list use-package-always-ensure)
> - (lambda (name args)
> - (and use-package-always-ensure
> - (not (plist-member args :load-path))))) t)
> -
> -(add-to-list 'use-package-defaults
> - '(:pin use-package-always-pin use-package-always-pin) t)
> -
> -(add-to-list 'use-package-keywords :ensure)
> -(add-to-list 'use-package-keywords :pin)
> -
> (provide 'use-package-ensure)
>
> ;;; use-package-ensure.el ends here
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: master 644d2a83316 1/2: Fix early use of use-package-always-ensure
2024-08-22 20:15 ` master 644d2a83316 1/2: Fix early use of use-package-always-ensure john muhl
@ 2024-09-01 9:32 ` Stefan Kangas
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Kangas @ 2024-09-01 9:32 UTC (permalink / raw)
To: john muhl, emacs-devel
john muhl <jm@pub.pink> writes:
> This commit caused some use-package tests to start failing.
Thanks, this should now be fixed.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-01 9:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <172411184679.14300.1289467153212355666@vcs2.savannah.gnu.org>
[not found] ` <20240819235727.648FFC1F9E8@vcs2.savannah.gnu.org>
2024-08-22 20:15 ` master 644d2a83316 1/2: Fix early use of use-package-always-ensure john muhl
2024-09-01 9:32 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).