From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.emacs.w3m Subject: Re: bogus change(s) in cl-macs.el Date: Fri, 26 Nov 2004 18:51:03 -0500 Message-ID: <87u0rcrx06.fsf-monnier+emacs@gnu.org> References: <87d5yajs0c.fsf-monnier+emacs@gnu.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1101513154 1368 80.91.229.6 (26 Nov 2004 23:52:34 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 26 Nov 2004 23:52:34 +0000 (UTC) Cc: snogglethorpe@gmail.com, emacs-devel@gnu.org, emacs-w3m@namazu.org, miles@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 27 00:52:29 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CXpt6-0002Lw-00 for ; Sat, 27 Nov 2004 00:52:29 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CXq2N-0000A6-4h for ged-emacs-devel@m.gmane.org; Fri, 26 Nov 2004 19:02:03 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CXq15-0008JN-KC for emacs-devel@gnu.org; Fri, 26 Nov 2004 19:00:43 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CXq13-0008Ip-TJ for emacs-devel@gnu.org; Fri, 26 Nov 2004 19:00:42 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CXq13-0008Il-9d for emacs-devel@gnu.org; Fri, 26 Nov 2004 19:00:41 -0500 Original-Received: from [209.226.175.184] (helo=tomts22-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CXprk-0007H8-6J; Fri, 26 Nov 2004 18:51:04 -0500 Original-Received: from alfajor ([67.68.216.58]) by tomts22-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20041126235103.IVWT1919.tomts22-srv.bellnexxia.net@alfajor>; Fri, 26 Nov 2004 18:51:03 -0500 Original-Received: by alfajor (Postfix, from userid 1000) id 53B5D2FD52; Fri, 26 Nov 2004 18:51:03 -0500 (EST) Original-To: Katsumi Yamaoka In-Reply-To: <87d5yajs0c.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 19 Nov 2004 02:10:55 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:30417 gmane.emacs.w3m:4578 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30417 > Well, actually we can't see it here because you haven't used print-gensym > to distinguish symbols with the same name. But indeed: > (labels ((foo nil 1) (bar nil 2)) (cons (foo) (bar))) > returns (1 . 1). This is because cl's macro environment uses symbol names > rather than symbols for symbol-macros, so if two symbols have the same name > (i.e. `eq', not just `equal') and they both are symbol-macros, then > CL screws up. I'm working on a patch for that. OK, I've committed basically your fix (except it also needed to be applied at one other place, and I added some comment explaining why we use `gensym' rather than `make-symbol' there). Stefan