syntax highlight fix for add-log.el

syntax highlight fix for add-log.el

[Marcelo Toledo]

The manual describing a Change Log entry, says: (...) "Aside from these
header lines, every line in the change log starts with a space or a
tab.".

The font-lock was not highlighting lines started with spaces, added
support for it and corrected an `indent-region' call.

Can I install it?

Index: lisp/add-log.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/add-log.el,v
retrieving revision 1.156
diff -c -r1.156 add-log.el
*** lisp/add-log.el	21 Mar 2005 14:37:35 -0000	1.156
--- lisp/add-log.el	3 Apr 2005 02:12:14 -0000
***************
*** 225,231 ****
        (2 'change-log-email-face)))
      ;;
      ;; File names.
!     ("^\t\\* \\([^ ,:([\n]+\\)"
       (1 'change-log-file-face)
       ;; Possibly further names in a list:
       ("\\=, \\([^ ,:([\n]+\\)" nil nil (1 'change-log-file-face))
--- 225,231 ----
        (2 'change-log-email-face)))
      ;;
      ;; File names.
!     ("^\\(?: \\{8\\}\\|\t\\)\\* \\([^ ,:([\n]+\\)"
       (1 'change-log-file-face)
       ;; Possibly further names in a list:
       ("\\=, \\([^ ,:([\n]+\\)" nil nil (1 'change-log-file-face))
***************
*** 310,316 ****
  			  (mark) (point)))
      (when (fboundp 'log-edit-previous-comment)
        (log-edit-previous-comment arg)
!       (indent-region (point-min) (point-max))
        (goto-char (point-min))
        (unless (save-restriction (widen) (bolp))
  	(delete-region (point) (progn (skip-chars-forward " \t\n") (point))))
--- 310,316 ----
  			  (mark) (point)))
      (when (fboundp 'log-edit-previous-comment)
        (log-edit-previous-comment arg)
!       (indent-region (point-min) (point-max) nil)
        (goto-char (point-min))
        (unless (save-restriction (widen) (bolp))
  	(delete-region (point) (progn (skip-chars-forward " \t\n") (point))))

-- 
Marcelo Toledo
marcelo@marcelotoledo.org
http://www.marcelotoledo.org
Mobile: 55 71 9116-1101

Re: syntax highlight fix for add-log.el

[Richard Stallman]

	  ;; File names.
    !     ("^\\(?: \\{8\\}\\|\t\\)\\* \\([^ ,:([\n]+\\)"

This seems to insist on 8 spaces.
It can be any number of spaces; one space is enough.

	    (log-edit-previous-comment arg)
    !       (indent-region (point-min) (point-max) nil)

This change looks like a no-op.  What is the bug you intend to fix?

Re: syntax highlight fix for add-log.el

[Marcelo Toledo]

Richard Stallman <rms@gnu.org> writes:

> 	  ;; File names.
>     !     ("^\\(?: \\{8\\}\\|\t\\)\\* \\([^ ,:([\n]+\\)"
>
> This seems to insist on 8 spaces.
> It can be any number of spaces; one space is enough.

Modified to work with 1 or more spaces.

> 	    (log-edit-previous-comment arg)
>     !       (indent-region (point-min) (point-max) nil)
>
> This change looks like a no-op.  What is the bug you intend to fix?

I was looking old code and old documentation where column was no
optional, sorry. Just ignore it.

I've installed this patch:

Index: lisp/ChangeLog
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.7247
diff -u -r1.7247 ChangeLog
--- lisp/ChangeLog	3 Apr 2005 21:26:11 -0000	1.7247
+++ lisp/ChangeLog	3 Apr 2005 22:44:25 -0000
@@ -1,3 +1,11 @@
+2005-04-03  Marcelo Toledo  <marcelo@marcelotoledo.org>
+
+        * add-log.el (change-log-font-lock-keywords): The manual
+        describing a Change Log entry, says: (...) "Aside from these
+        header lines, every line in the change log starts with a space or
+        a tab.". The font-lock was not highlighting lines started with
+        spaces, added support for it.
+
 2005-04-03  Roland Winkler  <Roland.Winkler@physik.uni-erlangen.de>
 
 	* textmodes/bibtex.el (bibtex-url): Use format to generate the url.
Index: lisp/add-log.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/add-log.el,v
retrieving revision 1.156
diff -u -r1.156 add-log.el
--- lisp/add-log.el	21 Mar 2005 14:37:35 -0000	1.156
+++ lisp/add-log.el	3 Apr 2005 22:44:33 -0000
@@ -225,7 +225,7 @@
       (2 'change-log-email-face)))
     ;;
     ;; File names.
-    ("^\t\\* \\([^ ,:([\n]+\\)"
+    ("^\\(?: +\\|\t\\)\\* \\([^ ,:([\n]+\\)"
      (1 'change-log-file-face)
      ;; Possibly further names in a list:
      ("\\=, \\([^ ,:([\n]+\\)" nil nil (1 'change-log-file-face))

-- 
Marcelo Toledo
marcelo@marcelotoledo.org
http://www.marcelotoledo.org
Mobile: 55 71 9116-1101

Re: syntax highlight fix for add-log.el

[Lute Kamstra]

Marcelo Toledo <marcelo@marcelotoledo.org> writes:

> The manual describing a Change Log entry, says: (...) "Aside from
> these header lines, every line in the change log starts with a space
> or a tab.".

Your patch goes only half the way in fixing the problem you describe.
What about this change to fix the rest?

Lute.


Index: lisp/add-log.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/add-log.el,v
retrieving revision 1.158
diff -u -r1.158 add-log.el
--- lisp/add-log.el	4 Apr 2005 08:47:07 -0000	1.158
+++ lisp/add-log.el	4 Apr 2005 10:39:11 -0000
@@ -225,8 +225,8 @@
       (2 'change-log-email-face)))
     ;;
     ;; File names.
-    ("^\\(?: +\\|\t\\)\\* \\([^ ,:([\n]+\\)"
-     (1 'change-log-file-face)
+    ("^\\( +\\|\t\\)\\* \\([^ ,:([\n]+\\)"
+     (2 'change-log-file-face)
      ;; Possibly further names in a list:
      ("\\=, \\([^ ,:([\n]+\\)" nil nil (1 'change-log-file-face))
      ;; Possibly a parenthesized list of names:
@@ -236,8 +236,8 @@
       nil nil (1 'change-log-list-face)))
     ;;
     ;; Function or variable names.
-    ("^\t(\\([^(),\n]+\\|(\\(setf\\|SETF\\) [^() ,\n]+)\\)"
-     (1 'change-log-list-face)
+    ("^\\( +\\|\t\\)(\\([^(),\n]+\\|(\\(setf\\|SETF\\) [^() ,\n]+)\\)"
+     (2 'change-log-list-face)
      ("\\=, *\\([^(),\n]+\\|(\\(setf\\|SETF\\) [^() ,\n]+)\\)" nil nil
       (1 'change-log-list-face)))
     ;;
@@ -250,8 +250,8 @@
     ;; Acknowledgements.
     ;; Don't include plain "From" because that is vague;
     ;; we want to encourage people to say something more specific.
-    ("\\(^\t\\|  \\)\\(Patch\\(es\\)? by\\|Report\\(ed by\\| from\\)\\|Suggest\\(ed by\\|ion from\\)\\)"
-     2 'change-log-acknowledgement-face))
+    ("\\(^\\( +\\|\t\\)\\|  \\)\\(Patch\\(es\\)? by\\|Report\\(ed by\\| from\\)\\|Suggest\\(ed by\\|ion from\\)\\)"
+     3 'change-log-acknowledgement-face))
   "Additional expressions to highlight in Change Log mode.")
 
 (defvar change-log-mode-map

Re: syntax highlight fix for add-log.el

[Marcelo Toledo]

Works great Lute, thanks. Can you install please?

Lute Kamstra <Lute.Kamstra.lists@xs4all.nl> writes:

> Your patch goes only half the way in fixing the problem you describe.
> What about this change to fix the rest?

-- 
Marcelo Toledo
marcelo@marcelotoledo.org
http://www.marcelotoledo.org
Mobile: 55 71 9116-1101