From: michael.cadilhac@lrde.org (Michaël Cadilhac)
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] Changes to emacs/lisp/ChangeLog
Date: Tue, 23 May 2006 19:14:57 +0200 [thread overview]
Message-ID: <87u07gzmr2.fsf@lrde.org> (raw)
In-Reply-To: jwvwtccu81i.fsf-monnier+emacs@gnu.org
[-- Attachment #1.1.1: Type: text/plain, Size: 1142 bytes --]
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> When I do C-x C-f /a/b/c, with shell being /bin/sh (zsh emuled),
>> I still have a weird behavior:
>
>> <TAB>
>> read-file-name-internal: Opening directory: no such file or directory, /a*/b*/
>> <TAB>
>> read-file-name-internal: Opening directory: no such file or directory, /a**/b**/
>> <TAB>
>> read-file-name-internal: Opening directory: no such file or directory, /a***/b***/
>> <TAB>
>> read-file-name-internal: Opening directory: no such file or directory, /a****/b****/
>
>> AFAIU, this patch fixes the /c* bug (i.e. the last part of the filename
>> being completed) but not the whole problem.
>
> Hmm... I remember working on such a bug report a few months ago.
> Can't remember whether I had fixed it at the time and if so how. But in any
> case, I can't reproduce the problem right now.
My bad, I recompiled a freshly checkouted Emacs and it works almost
right.
When I do C-x C-f /a/b/c TAB, no star are added, but an _error_ is
triggered instead of a [no match].
IMHO, it's due to file_name_completion, and I'd be very tempted to
make the following:
[-- Attachment #1.1.2: direr.patch --]
[-- Type: text/x-patch, Size: 1486 bytes --]
Index: src/ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/src/ChangeLog,v
retrieving revision 1.5083
diff -c -r1.5083 ChangeLog
*** src/ChangeLog 23 May 2006 08:12:13 -0000 1.5083
--- src/ChangeLog 23 May 2006 17:13:37 -0000
***************
*** 1,3 ****
--- 1,8 ----
+ 2006-05-23 Michaël Cadilhac <michael.cadilhac@lrde.org>
+
+ * dired.c (file_name_completion): Don't barf if the base directory
+ can't be opened.
+
2006-05-23 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
* macterm.c (fn_keycode_to_xkeysym_table, convert_fn_keycode): Remove.
Index: src/dired.c
===================================================================
RCS file: /sources/emacs/emacs/src/dired.c,v
retrieving revision 1.122
diff -c -r1.122 dired.c
*** src/dired.c 6 Feb 2006 15:23:20 -0000 1.122
--- src/dired.c 23 May 2006 17:13:37 -0000
***************
*** 503,509 ****
d = opendir (SDATA (Fdirectory_file_name (encoded_dir)));
if (!d)
! report_file_error ("Opening directory", Fcons (dirname, Qnil));
record_unwind_protect (directory_files_internal_unwind,
make_save_value (d, 0));
--- 503,509 ----
d = opendir (SDATA (Fdirectory_file_name (encoded_dir)));
if (!d)
! break;
record_unwind_protect (directory_files_internal_unwind,
make_save_value (d, 0));
[-- Attachment #1.1.3: Type: text/plain, Size: 422 bytes --]
It works if I do so, but I don't know if I'm not breaking another
functionality.
So ?
--
| Michaël `Micha' Cadilhac | Would someone please DTRT with this |
| Epita/LRDE Promo 2007 | then ACK? |
| http://www.lrde.org/~cadilh_m | -- Richard Stallman |
`-- - JID: micha@amessage.be --' - --'
[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]
[-- Attachment #2: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2006-05-23 17:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1FiEqb-0007QY-IW@savannah.gnu.org>
2006-05-23 12:07 ` [Emacs-diffs] Changes to emacs/lisp/ChangeLog Michaël Cadilhac
2006-05-23 14:39 ` Stefan Monnier
2006-05-23 17:14 ` Michaël Cadilhac [this message]
2006-05-23 20:51 ` Stefan Monnier
2006-05-24 8:48 ` Michaël Cadilhac
2006-05-26 19:15 ` PC-do-completion triggers an error (was: [Emacs-diffs] Changes to emacs/lisp/ChangeLog) Michaël Cadilhac
2006-06-10 19:00 ` PC-do-completion triggers an error Michaël Cadilhac
[not found] <E16r5bQ-0001Jp-00@subversions.gnu.org>
[not found] ` <m3vgbe5wjm.fsf@Janik.cz>
[not found] ` <200203311640.g2VGeFw10733@aztec.santafe.edu>
2002-04-01 9:12 ` [Emacs-diffs] Changes to emacs/lisp/ChangeLog Pavel Janík
2002-04-01 10:19 ` Eli Zaretskii
2002-04-01 15:05 ` Stefan Monnier
2002-04-01 17:02 ` Pavel Janík
2002-04-01 23:21 ` Richard Stallman
2002-04-02 17:09 ` Pavel Janík
2002-04-03 22:50 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87u07gzmr2.fsf@lrde.org \
--to=michael.cadilhac@lrde.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).