From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: [drew.adams@oracle.com: customizing hl-line-face should reset global-hl-line-overlay to nil] Date: Mon, 28 Aug 2006 13:13:45 -0400 Message-ID: <87u03wbx6e.fsf@stupidchicken.com> References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1156785162 7007 80.91.229.2 (28 Aug 2006 17:12:42 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 28 Aug 2006 17:12:42 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 28 19:12:41 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GHkf2-0003fv-OD for ged-emacs-devel@m.gmane.org; Mon, 28 Aug 2006 19:12:33 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GHkf2-000694-4F for ged-emacs-devel@m.gmane.org; Mon, 28 Aug 2006 13:12:32 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GHkei-00062b-M3 for emacs-devel@gnu.org; Mon, 28 Aug 2006 13:12:12 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GHkef-00061Q-BG for emacs-devel@gnu.org; Mon, 28 Aug 2006 13:12:11 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GHkef-00061M-64 for emacs-devel@gnu.org; Mon, 28 Aug 2006 13:12:09 -0400 Original-Received: from [18.19.1.138] (helo=cyd) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GHkne-00075e-QB for emacs-devel@gnu.org; Mon, 28 Aug 2006 13:21:26 -0400 Original-Received: by cyd (Postfix, from userid 1000) id ED8104E2FE; Mon, 28 Aug 2006 13:13:45 -0400 (EDT) Original-To: "Drew Adams" In-Reply-To: (Drew Adams's message of "Mon, 28 Aug 2006 09:15:50 -0700") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:59015 Archived-At: "Drew Adams" writes: > > However, please see my other email about using a face instead > > of a user option (variable). Wouldn't that also take care of this > > problem? That is, if there is no face variable, and users change > > the face itself, then that would be immediately reflected in the > > overlay, no? > > It would. But it would break other people's customizations as well. > > Do you really think that would affect a lot of people negatively? I don't. I > think that most users of hl-line (both of them ;-)) will appreciate having a > face to customize. I suspect the users who care about "having a face to customize" forms is an even smaller subset than those that will get annoyed by having their existing customizations break. Note that hl-line-mode has been in Emacs since 1999. I think Martin's patch is correct.