From: Juri Linkov <juri@jurta.org>
To: emacs-devel@gnu.org
Subject: Diff faces
Date: Fri, 12 Oct 2007 02:59:17 +0300 [thread overview]
Message-ID: <87tzoxqk2y.fsf@jurta.org> (raw)
Wouldn't it be better to use the same colors for equivalent faces of
ediff, smerge and diff-mode? So that ediff-fine-diff-B, diff-fine-change
and smerge-refined-change will be the same and so on.
PS: While looking at ediff faces I discovered a bug: trying to get the
description of ediff faces from the Help buffer created by `C-u C-x ='
fails with (wrong-type-argument symbolp "ediff-fine-diff-B").
Ediff puts face names as strings on overlays, but describe-face accepts
only symbols. The patch below fixes describe-face to not fail on face
name strings. As for fixing ediff, I don't know whether this is necessary,
since face names as strings are mostly interchangeable with face symbols.
There are only two places in ediff*.el files that call `face-name' to
convert face symbols to strings, so these calls could be removed.
Index: lisp/faces.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/faces.el,v
retrieving revision 1.377
diff -c -r1.377 faces.el
*** lisp/faces.el 21 Sep 2007 07:23:03 -0000 1.377
--- lisp/faces.el 11 Oct 2007 23:59:05 -0000
***************
*** 1285,1290 ****
--- 1285,1291 ----
(save-excursion
(set-buffer standard-output)
(dolist (f face)
+ (if (stringp f) (setq f (intern f)))
(insert "Face: " (symbol-name f))
(if (not (facep f))
(insert " undefined face.\n")
--
Juri Linkov
http://www.jurta.org/emacs/
next reply other threads:[~2007-10-11 23:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 23:59 Juri Linkov [this message]
2007-10-12 1:21 ` Diff faces Stefan Monnier
2007-10-14 21:30 ` Juri Linkov
2007-10-15 14:36 ` Stefan Monnier
2007-10-15 23:52 ` Juri Linkov
2007-10-16 3:20 ` Stefan Monnier
2007-10-16 4:12 ` Miles Bader
2007-10-19 16:18 ` Stefan Monnier
2007-10-19 20:55 ` Juri Linkov
2007-10-19 23:42 ` Andreas Schwab
2007-10-20 0:16 ` Juri Linkov
2007-10-20 12:51 ` Stefan Monnier
2007-10-20 0:52 ` Stefan Monnier
2007-10-12 15:59 ` Richard Stallman
2007-10-12 19:42 ` Michael Kifer
2007-10-13 6:41 ` Richard Stallman
2007-10-13 6:55 ` Michael Kifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tzoxqk2y.fsf@jurta.org \
--to=juri@jurta.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).