unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Thien-Thi Nguyen <ttn@gnuvola.org>
To: emacs-devel@gnu.org
Subject: [patch] vc-git-dired-state-info buglet
Date: Fri, 23 Nov 2007 13:09:21 +0100	[thread overview]
Message-ID: <87tzndw4cu.fsf@ambire.localdomain> (raw)

i think `vc-git-dired-state-info' should call `vc-git-state'
instead of `vc-state'.  here is a recipe: create dir `test',
put it under git version control system, add and commit some
files, then modify a subset of the files.  then do:

C-x v d test RET  ; => empty because no files "locked"
v t               ; => toggle terse mode

before the patch, no files are shown w/ "(modified)" status.
after the patch, some are shown, as i expected.

i wonder if my expectation is incorrect.  comments?

thi


________________________________________________________
*** vc-git.el	20 Oct 2007 01:28:35 -0000	1.25
--- vc-git.el	23 Nov 2007 12:02:57 -0000
***************
*** 205,211 ****
  
  (defun vc-git-dired-state-info (file)
    "Git-specific version of `vc-dired-state-info'."
!   (let ((git-state (vc-state file)))
      (if (eq git-state 'edited)
  	"(modified)"
        ;; fall back to the default VC representation
--- 205,211 ----
  
  (defun vc-git-dired-state-info (file)
    "Git-specific version of `vc-dired-state-info'."
!   (let ((git-state (vc-git-state file)))
      (if (eq git-state 'edited)
  	"(modified)"
        ;; fall back to the default VC representation

             reply	other threads:[~2007-11-23 12:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-23 12:09 Thien-Thi Nguyen [this message]
2007-11-27 21:55 ` [patch] vc-git-dired-state-info buglet Alexandre Julliard
2007-11-29  7:22   ` Dan Nicolaescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tzndw4cu.fsf@ambire.localdomain \
    --to=ttn@gnuvola.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).