unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Karl Fogel <kfogel@red-bean.com>
To: rms@gnu.org
Cc: esr@thyrsus.com, emacs-devel@gnu.org
Subject: Re: Commit practices
Date: Sat, 29 Dec 2007 23:58:51 -0800	[thread overview]
Message-ID: <87tzm0sjes.fsf@red-bean.com> (raw)
In-Reply-To: <E1J8n6n-0003nY-RE@fencepost.gnu.org> (Richard Stallman's message of "Sat\, 29 Dec 2007 20\:36\:57 -0500")

Richard Stallman <rms@gnu.org> writes:
> The reason I have asked people not to commit multiple files
> is that they bloat the log entries of each file, making them
> essentially unusable.
>
>     I did it this way for a reason.  Someday we are going to want to
>     migrate the CVS tree to a VCS that has real changesets.  We're almost
>     certainly going to do it with a tool functionally like cvs2svn that
>     tries to reconstruct commit groups using date, the content of the
>     comments, and possibly this Commit-ID thing I see in the CVS logs. It
>     will be helpful, when we do that, if there as many similarities across
>     related commits as possible for the migration tool to grab onto.
>
> In effect, the suggestion here is that we abandon the idea
> of useful readable info associated by the VCS with each file.
>
> That would mean that the ChangeLog file is the only place
> for such info.
>
> I won't say "absolutely not".

Grouping each logical change together in one commit (even when the
change involves multiple files) allows tools like cvs2cl to do their
job (see http://www.red-bean.com/cvs2cl for more).  Thus, the info
recorded by the VCS *would* still be useful -- no need to abandon that
idea.  By the way, cvs2svn uses essentially the same algorithm.

So, the ChangeLog would not be the only place for this info.

Also:

All the CVS documentation I've seen specifically recommends grouping
each logically unified change together in one commit.  That is also
the way I have always used CVS, and the way CVS maintainers use CVS.
I realize this sounds like "argument from authority", but given our
finite resources, the time-tested experience of others may be worth
taking into account.

-Karl

  parent reply	other threads:[~2007-12-30  7:58 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20071229141014.3364A2C83DC@grelber.thyrsus.com>
2007-12-29 18:32 ` Commit practices Eric S. Raymond
2007-12-29 18:45   ` Eli Zaretskii
2007-12-29 20:52     ` Eric S. Raymond
2007-12-30  1:36   ` Richard Stallman
2007-12-30  3:56     ` Stephen J. Turnbull
2007-12-30  6:45       ` Eric S. Raymond
2007-12-30  6:44     ` Eric S. Raymond
2007-12-30 10:08       ` David Kastrup
2007-12-30 10:47         ` Eric S. Raymond
2007-12-30 11:01           ` Miles Bader
2007-12-30 12:36             ` Eric S. Raymond
2007-12-30 12:43               ` Miles Bader
2007-12-30 13:33                 ` Eric S. Raymond
2007-12-30 13:51                   ` Miles Bader
2007-12-30 14:00                     ` David Kastrup
2007-12-30 12:44               ` David Kastrup
2007-12-30 13:39                 ` Eric S. Raymond
2007-12-30 13:52                   ` David Kastrup
2007-12-30 14:02       ` Richard Stallman
2007-12-30 17:25         ` Eric S. Raymond
2007-12-30 22:58           ` Richard Stallman
2007-12-31  3:25             ` Eric S. Raymond
2007-12-31 22:29               ` Richard Stallman
2007-12-30  7:58     ` Karl Fogel [this message]
2007-12-31  0:59     ` Dan Nicolaescu
2007-12-31 22:29       ` Richard Stallman
2008-01-01  0:48         ` Dan Nicolaescu
2008-01-01 22:47           ` Johan Bockgård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tzm0sjes.fsf@red-bean.com \
    --to=kfogel@red-bean.com \
    --cc=emacs-devel@gnu.org \
    --cc=esr@thyrsus.com \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).