* DocView: SPC doesn't go the the next page
@ 2008-01-03 23:16 Juri Linkov
2008-01-04 8:30 ` Tassilo Horn
0 siblings, 1 reply; 4+ messages in thread
From: Juri Linkov @ 2008-01-03 23:16 UTC (permalink / raw)
To: emacs-pretest-bug; +Cc: Tassilo Horn
In the latest version of doc-view.el, when the image height is greater
than the Emacs window's height, typing SPC (doc-view-scroll-up-or-next-page)
doesn't go to the next page. Instead, when if reaches the end of the current
page, it goes to the beginning of the current page.
--
Juri Linkov
http://www.jurta.org/emacs/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: DocView: SPC doesn't go the the next page
2008-01-03 23:16 DocView: SPC doesn't go the the next page Juri Linkov
@ 2008-01-04 8:30 ` Tassilo Horn
2008-01-04 9:54 ` Juri Linkov
0 siblings, 1 reply; 4+ messages in thread
From: Tassilo Horn @ 2008-01-04 8:30 UTC (permalink / raw)
To: emacs-devel
Juri Linkov <juri@jurta.org> writes:
Hi Juri,
> In the latest version of doc-view.el, when the image height is greater
> than the Emacs window's height, typing SPC
> (doc-view-scroll-up-or-next-page) doesn't go to the next page.
> Instead, when if reaches the end of the current page, it goes to the
> beginning of the current page.
I don't understand why this happened (or why it worked before), but I
changed the implementations for the scrolling commands to something
sane. It gives very nice results here. Please try it out.
Bye,
Tassilo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: DocView: SPC doesn't go the the next page
2008-01-04 8:30 ` Tassilo Horn
@ 2008-01-04 9:54 ` Juri Linkov
2008-01-04 13:33 ` Tassilo Horn
0 siblings, 1 reply; 4+ messages in thread
From: Juri Linkov @ 2008-01-04 9:54 UTC (permalink / raw)
To: emacs-devel
>> In the latest version of doc-view.el, when the image height is greater
>> than the Emacs window's height, typing SPC
>> (doc-view-scroll-up-or-next-page) doesn't go to the next page.
>> Instead, when if reaches the end of the current page, it goes to the
>> beginning of the current page.
>
> I don't understand why this happened (or why it worked before), but I
> changed the implementations for the scrolling commands to something
> sane. It gives very nice results here. Please try it out.
Thank you.
There are still one border case: at the end of the last page typing SPC
goes to the beginning of the same last page. Maybe it would be better to
stay at the end of the last page to not give a false impression that SPC
navigated to the next page.
--
Juri Linkov
http://www.jurta.org/emacs/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: DocView: SPC doesn't go the the next page
2008-01-04 9:54 ` Juri Linkov
@ 2008-01-04 13:33 ` Tassilo Horn
0 siblings, 0 replies; 4+ messages in thread
From: Tassilo Horn @ 2008-01-04 13:33 UTC (permalink / raw)
To: emacs-devel
Juri Linkov <juri@jurta.org> writes:
>>> In the latest version of doc-view.el, when the image height is
>>> greater than the Emacs window's height, typing SPC
>>> (doc-view-scroll-up-or-next-page) doesn't go to the next page.
>>> Instead, when if reaches the end of the current page, it goes to the
>>> beginning of the current page.
>>
>> I don't understand why this happened (or why it worked before), but I
>> changed the implementations for the scrolling commands to something
>> sane. It gives very nice results here. Please try it out.
>
> Thank you.
>
> There are still one border case: at the end of the last page typing
> SPC goes to the beginning of the same last page. Maybe it would be
> better to stay at the end of the last page to not give a false
> impression that SPC navigated to the next page.
Fixed.
Tassilo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-01-04 13:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-03 23:16 DocView: SPC doesn't go the the next page Juri Linkov
2008-01-04 8:30 ` Tassilo Horn
2008-01-04 9:54 ` Juri Linkov
2008-01-04 13:33 ` Tassilo Horn
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).