From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: [nico@ngolde.de: some code issues] Date: Thu, 10 Jan 2008 10:27:40 -0500 Message-ID: <87tzllzonn.fsf@stupidchicken.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1199978887 31422 80.91.229.12 (10 Jan 2008 15:28:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 10 Jan 2008 15:28:07 +0000 (UTC) Cc: Nico Golde , emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 10 16:28:26 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JCzKN-000084-F3 for ged-emacs-devel@m.gmane.org; Thu, 10 Jan 2008 16:28:19 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JCzJz-00059j-TH for ged-emacs-devel@m.gmane.org; Thu, 10 Jan 2008 10:27:55 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JCzJu-00057v-8E for emacs-devel@gnu.org; Thu, 10 Jan 2008 10:27:50 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JCzJo-00052r-B2 for emacs-devel@gnu.org; Thu, 10 Jan 2008 10:27:48 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JCzJo-00052n-7A for emacs-devel@gnu.org; Thu, 10 Jan 2008 10:27:44 -0500 Original-Received: from [18.115.7.124] (helo=furry) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JCzJk-00067D-NR; Thu, 10 Jan 2008 10:27:40 -0500 Original-Received: by furry (Postfix, from userid 1000) id 4B7B7C02E; Thu, 10 Jan 2008 10:27:40 -0500 (EST) In-Reply-To: (Richard Stallman's message of "Mon\, 07 Jan 2008 06\:30\:41 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:86704 Archived-At: > I had a quick look at the pop.c code today and found some > issues. > > In pop_stat: > > If I don't miss anything the atoi call in 380 is not save as it is not > save because it is not ensure that &fromserver[4] is not NULL. A crafted > pop3 server could thus crash emacs. This is of course not a real issue but > wouldn't be nice. Same for the pop_last function. > > In pop_list: > > in 441 and 442 there should be some check for how_many to prevent an integer > overflow here. Fixed. Thanks for pointing these out. > Same problem for the xnew macro in etags.c I don't think this is a problem, considering the way the xnew macro is called in etags.c --- unless you can point to a specific problem.