From: Chong Yidong <cyd@stupidchicken.com>
To: rms@gnu.org
Cc: Nico Golde <nico@ngolde.de>, emacs-devel@gnu.org
Subject: Re: [nico@ngolde.de: some code issues]
Date: Thu, 10 Jan 2008 10:27:40 -0500 [thread overview]
Message-ID: <87tzllzonn.fsf@stupidchicken.com> (raw)
In-Reply-To: <E1JBqBl-0004Jr-0n@fencepost.gnu.org> (Richard Stallman's message of "Mon\, 07 Jan 2008 06\:30\:41 -0500")
> I had a quick look at the pop.c code today and found some
> issues.
>
> In pop_stat:
>
> If I don't miss anything the atoi call in 380 is not save as it is not
> save because it is not ensure that &fromserver[4] is not NULL. A crafted
> pop3 server could thus crash emacs. This is of course not a real issue but
> wouldn't be nice. Same for the pop_last function.
>
> In pop_list:
>
> in 441 and 442 there should be some check for how_many to prevent an integer
> overflow here.
Fixed. Thanks for pointing these out.
> Same problem for the xnew macro in etags.c
I don't think this is a problem, considering the way the xnew macro is
called in etags.c --- unless you can point to a specific problem.
next prev parent reply other threads:[~2008-01-10 15:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 11:30 [nico@ngolde.de: some code issues] Richard Stallman
2008-01-10 15:24 ` Chong Yidong
2008-01-10 15:27 ` Chong Yidong [this message]
2008-01-10 15:35 ` Nico Golde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tzllzonn.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=nico@ngolde.de \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).