From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.60; Different heights for customize faces Date: Sun, 11 May 2008 23:10:50 +0300 Organization: JURTA Message-ID: <87tzh4psg5.fsf@jurta.org> References: <4822B6FB.9030102@gmail.com> <87iqxn6mq9.fsf@jurta.org> <48261EE2.7030506@gmail.com> <8763tliu0v.fsf@jurta.org> <482643A1.5020309@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1210536691 2786 80.91.229.12 (11 May 2008 20:11:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 11 May 2008 20:11:31 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org To: "Lennart Borgman \(gmail\)" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 11 22:12:07 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JvHtq-00062h-GZ for ged-emacs-devel@m.gmane.org; Sun, 11 May 2008 22:12:02 +0200 Original-Received: from localhost ([127.0.0.1]:41959 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JvHt7-0001ev-H1 for ged-emacs-devel@m.gmane.org; Sun, 11 May 2008 16:11:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JvHt4-0001ek-H5 for emacs-devel@gnu.org; Sun, 11 May 2008 16:11:14 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JvHt2-0001eP-OZ for emacs-devel@gnu.org; Sun, 11 May 2008 16:11:14 -0400 Original-Received: from [199.232.76.173] (port=45044 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JvHt2-0001eM-Ju for emacs-devel@gnu.org; Sun, 11 May 2008 16:11:12 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:54820) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JvHt2-0001nr-B0 for emacs-devel@gnu.org; Sun, 11 May 2008 16:11:12 -0400 Original-Received: from mail.gnu.org ([199.232.76.166]:41525 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JvHsC-0006cR-5Z for emacs-pretest-bug@gnu.org; Sun, 11 May 2008 16:10:20 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JvHsw-0001n9-LV for emacs-pretest-bug@gnu.org; Sun, 11 May 2008 16:11:12 -0400 Original-Received: from anti-4.kiev.sovam.com ([62.64.120.202]:63237) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JvHsw-0001mh-7I for emacs-pretest-bug@gnu.org; Sun, 11 May 2008 16:11:06 -0400 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by anti-4.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1JvHst-0002RJ-UA; Sun, 11 May 2008 23:11:04 +0300 In-Reply-To: <482643A1.5020309@gmail.com> (Lennart Borgman's message of "Sun, 11 May 2008 02:53:53 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-pc-linux-gnu) X-Scanner-Signature: 565941832c2f675ae953af64aa3a5396 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 2798 [May 08 2008] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Info: {TO: local part of email appears in body} X-SpamTest-Method: none X-SpamTest-Rate: 15 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release X-detected-kernel: by monty-python.gnu.org: FreeBSD 6.x (1) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:96981 gmane.emacs.pretest.bugs:22268 Archived-At: >>>>> The heights for custom-variable-tag-face and custom-face-tag differs. >>>> Sorry, I see no bug. >>> Are those too faces the same height? Any one else seeing different heights? >> >> If you what to say that different heights look ugly then I argee. > > Eh, yes. I could perhaps have been clear, but I just could not imagine > that the different heights were by intent. It is currently defined as 1.2 height: (defface custom-face-tag `((t (:weight bold :height 1.2 :inherit variable-pitch))) "Face used for face tags." :group 'custom-faces) >> Also using the blue color for custom-variable-tag-face makes option names >> similar to links. Maybe we should use the same colors that font-lock >> defines for font-lock-constant-face and font-lock-variable-name and just >> make them bold? > > I think that would be worth to try. Could you propose a better color? Meanwhile, I like to fix the original problem you reported by the following patch. It changes the appearance of custom-face-tag to be the same as custom-variable-tag. These option types can be still distinguished in the Customization buffer because faces have the explicit text "face:" appended after the face name. Index: lisp/cus-edit.el =================================================================== RCS file: /sources/emacs/emacs/lisp/cus-edit.el,v retrieving revision 1.346 diff -u -r1.346 cus-edit.el --- lisp/cus-edit.el 6 May 2008 07:57:28 -0000 1.346 +++ lisp/cus-edit.el 11 May 2008 20:10:11 -0000 @@ -3218,7 +3218,7 @@ ;;; The `custom-face' Widget. (defface custom-face-tag - `((t (:weight bold :height 1.2 :inherit variable-pitch))) + `((t :inherit custom-variable-tag)) "Face used for face tags." :group 'custom-faces) ;; backward-compatibility alias -- Juri Linkov http://www.jurta.org/emacs/