From: Juri Linkov <juri@jurta.org>
To: "Lennart Borgman \(gmail\)" <lennart.borgman@gmail.com>
Cc: emacs-pretest-bug@gnu.org
Subject: Re: 23.0.60; Different heights for customize faces
Date: Sun, 11 May 2008 23:10:50 +0300 [thread overview]
Message-ID: <87tzh4psg5.fsf@jurta.org> (raw)
In-Reply-To: <482643A1.5020309@gmail.com> (Lennart Borgman's message of "Sun, 11 May 2008 02:53:53 +0200")
>>>>> The heights for custom-variable-tag-face and custom-face-tag differs.
>>>> Sorry, I see no bug.
>>> Are those too faces the same height? Any one else seeing different heights?
>>
>> If you what to say that different heights look ugly then I argee.
>
> Eh, yes. I could perhaps have been clear, but I just could not imagine
> that the different heights were by intent.
It is currently defined as 1.2 height:
(defface custom-face-tag
`((t (:weight bold :height 1.2 :inherit variable-pitch)))
"Face used for face tags."
:group 'custom-faces)
>> Also using the blue color for custom-variable-tag-face makes option names
>> similar to links. Maybe we should use the same colors that font-lock
>> defines for font-lock-constant-face and font-lock-variable-name and just
>> make them bold?
>
> I think that would be worth to try.
Could you propose a better color?
Meanwhile, I like to fix the original problem you reported
by the following patch. It changes the appearance of
custom-face-tag to be the same as custom-variable-tag.
These option types can be still distinguished in the
Customization buffer because faces have the explicit
text "face:" appended after the face name.
Index: lisp/cus-edit.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/cus-edit.el,v
retrieving revision 1.346
diff -u -r1.346 cus-edit.el
--- lisp/cus-edit.el 6 May 2008 07:57:28 -0000 1.346
+++ lisp/cus-edit.el 11 May 2008 20:10:11 -0000
@@ -3218,7 +3218,7 @@
;;; The `custom-face' Widget.
(defface custom-face-tag
- `((t (:weight bold :height 1.2 :inherit variable-pitch)))
+ `((t :inherit custom-variable-tag))
"Face used for face tags."
:group 'custom-faces)
;; backward-compatibility alias
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2008-05-11 20:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-08 8:16 23.0.60; Different heights for customize faces Lennart Borgman (gmail)
2008-05-09 23:59 ` Juri Linkov
2008-05-10 22:17 ` Lennart Borgman (gmail)
2008-05-11 0:06 ` Juri Linkov
2008-05-11 0:53 ` Lennart Borgman (gmail)
2008-05-11 20:10 ` Juri Linkov [this message]
2008-05-11 22:35 ` Lennart Borgman (gmail)
2008-05-13 0:07 ` Juri Linkov
2008-05-13 0:39 ` Lennart Borgman (gmail)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tzh4psg5.fsf@jurta.org \
--to=juri@jurta.org \
--cc=emacs-pretest-bug@gnu.org \
--cc=lennart.borgman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).