From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: The latest lisp/faces.el changes seem to break color-themes again Date: Thu, 16 Oct 2008 12:36:05 -0400 Message-ID: <87tzbcfqfe.fsf@cyd.mit.edu> References: <87skqxw20c.fsf@anzu.internal.golden-gryphon.com> <87od1lvxa9.fsf@anzu.internal.golden-gryphon.com> <87abd4vfyb.fsf@grepfind.mwolson.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1224174997 24410 80.91.229.12 (16 Oct 2008 16:36:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 Oct 2008 16:36:37 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michael Olson Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 16 18:37:37 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KqVqr-00012d-Jl for ged-emacs-devel@m.gmane.org; Thu, 16 Oct 2008 18:37:30 +0200 Original-Received: from localhost ([127.0.0.1]:50942 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KqVpi-0007Tl-Nb for ged-emacs-devel@m.gmane.org; Thu, 16 Oct 2008 12:36:18 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KqVpe-0007Tb-4g for emacs-devel@gnu.org; Thu, 16 Oct 2008 12:36:14 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KqVpb-0007TN-Rr for emacs-devel@gnu.org; Thu, 16 Oct 2008 12:36:13 -0400 Original-Received: from [199.232.76.173] (port=56251 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KqVpb-0007TK-I4 for emacs-devel@gnu.org; Thu, 16 Oct 2008 12:36:11 -0400 Original-Received: from cyd.mit.edu ([18.115.2.24]:35434) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KqVpM-0004tX-Lg; Thu, 16 Oct 2008 12:35:57 -0400 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 3031257E095; Thu, 16 Oct 2008 12:36:06 -0400 (EDT) In-Reply-To: <87abd4vfyb.fsf@grepfind.mwolson.org> (Michael Olson's message of "Thu, 16 Oct 2008 06:15:40 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104557 Archived-At: Michael Olson writes: > The problem could possibly be due to Emacs having problems with using > ":foreground nil" in a defface statement. I just received a patch for > EMMS to that effect. I just checked in a change to make internal-set-lisp-face-attribute treat null foreground/background as equivalent to unspecified. This is a Emacs 20'ism that ought to be phased out in your code, but AFAICT there's no harm handling it. Let me know if there is anything else that breaks (I don't use color-themes so I can't test the original report).