From: Tassilo Horn <tassilo@member.fsf.org>
To: Emacs developers <emacs-devel@gnu.org>
Subject: Re: Concerning delete-by-moving-to-trash on free systems
Date: Thu, 27 Nov 2008 15:58:03 +0100 [thread overview]
Message-ID: <87tz9trzb8.fsf@thinkpad.tsdh.de> (raw)
In-Reply-To: <492EB022.8080905@harpegolden.net> (David De La Harpe Golden's message of "Thu, 27 Nov 2008 14:35:14 +0000")
David De La Harpe Golden <david@harpegolden.net> writes:
Hi!
>> Nice! Why do you fallback to ~/.local/share/ in
>> move-file-to-trash-freedesktop. With the predicate you already
>> checked that XDG_DATA_HOME is set. If it's not set in
>> move-file-to-trash-freedesktop I'd expect an error.
>>
>
> XDG_DATA_HOME is not guaranteed to be set in nonetheless
> freedesktop.org compliant environments (it's not set on my desktop
> running the generally-highly-fd.o XFCE4!):
I see. I looked at it too briefly.
> If it's actually okay for emacs to use the freedesktop-style trashcan
> by default rather than the builtin emacs "fallback" trashcan support,
> then the move-file-to-trash--freedesktop-p test could be dropped and
> the patch slightly simplified.
I'd say it's more than ok. As I mentioned in my original posting the
current fallback trashcan loses data. That's much more problematic than
moving the files to a real trash can which cannot be accessed
appropriately with emacs ATM.
> Note that it's really only one side of comprehensive trashcan support
> (the writing side). While it's not urgent (since most people
> interested in fd.o trashcans can presumably use their desktop
> environment file manager's trashcan interface),
Exactly. I like moving to trash because seldomly but sometimes I delete
something which I shouldn't delete. The main point is that it's still
there, no matter if I have to fire up some other app to restore it.
> for the reading side, someone might conceivably want a dired that's
> trashcan-aware, so that you could browse the traschcan in a slightly
> extended dired view that offers a restore option (and at least with
> the metadata-available fd.o-style trashcan (and probably some others)
> it'd also be possible for dired to offer restorations of files when
> you're browsing a directory that has ex-members in the trashcan...).
That would be fantastic.
> That's generally more complicated e.g. while my patch for _writing_ to
> trashcan avails of the option not to use per-volume trashcans in the
> relevant spec, _reading_ from trash properly should probably not
> disregard the existence of per-volume trash.
Ok, let's add that to the 23.2 TODO list. ;-)
Anyway, my main point is (if I didn't mention it often enough): Don't
release 23.1 with an option which sounds great but loses data.
Bye,
Tassilo
next prev parent reply other threads:[~2008-11-27 14:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 10:09 Concerning delete-by-moving-to-trash on free systems Tassilo Horn
2008-11-27 13:19 ` David De La Harpe Golden
2008-11-27 14:00 ` Tassilo Horn
2008-11-27 14:35 ` David De La Harpe Golden
2008-11-27 14:58 ` Tassilo Horn [this message]
2008-11-27 15:26 ` Juanma Barranquero
2008-11-27 16:20 ` Tassilo Horn
2008-11-27 13:43 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tz9trzb8.fsf@thinkpad.tsdh.de \
--to=tassilo@member.fsf.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).