From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: Patch for bug #6515: unneeded let-bound variables in bookmark.el Date: Sun, 04 Jul 2010 19:07:25 -0400 Message-ID: <87tyoeongy.fsf@kslab.red-bean.com> References: <4C267485.2000804@gmail.com> <4C267553.3090109@gmail.com> <878w61xy3a.fsf@red-bean.com> Reply-To: Karl Fogel NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1278284856 1720 80.91.229.12 (4 Jul 2010 23:07:36 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 4 Jul 2010 23:07:36 +0000 (UTC) Cc: emacs-devel@gnu.org To: Christoph Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 05 01:07:35 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OVYHe-0000O7-NN for ged-emacs-devel@m.gmane.org; Mon, 05 Jul 2010 01:07:35 +0200 Original-Received: from localhost ([127.0.0.1]:39802 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OVYHe-0001a4-40 for ged-emacs-devel@m.gmane.org; Sun, 04 Jul 2010 19:07:34 -0400 Original-Received: from [140.186.70.92] (port=49284 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OVYHY-0001Yr-Qd for emacs-devel@gnu.org; Sun, 04 Jul 2010 19:07:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OVYHX-0003c9-B6 for emacs-devel@gnu.org; Sun, 04 Jul 2010 19:07:28 -0400 Original-Received: from osh-net-219-98.onshore.net ([66.146.219.98]:49907 helo=sanpietro.red-bean.com) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OVYHX-0003bK-8a for emacs-devel@gnu.org; Sun, 04 Jul 2010 19:07:27 -0400 Original-Received: from localhost ([127.0.0.1]:51419 helo=kslab.red-bean.com ident=kfogel) by sanpietro.red-bean.com with esmtp (Exim 4.72) (envelope-from ) id 1OVYHR-0001Wv-5p; Sun, 04 Jul 2010 18:07:21 -0500 In-Reply-To: <878w61xy3a.fsf@red-bean.com> (Karl Fogel's message of "Sat, 26 Jun 2010 17:50:33 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:126769 Archived-At: Karl Fogel writes: >Christoph writes: >>> Find attached a bugfix for bug #6515 >>> (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6515) for review. >> >>Sorry, this was intended to go to the bug tracker. > >Actually, I'm glad you sent it here. IMHO, the patch is small enough >and trivial enough to go in regardless of assignment papers -- a mere >description of the problem would suffice to cause any reasonable >programmer to generate the exact same patch, if my understanding is >correct (I haven't looked at it in depth yet, but will soon). I clean-roomed it (because I wasn't sure it was small enough to not worry about papers), and of course the result was byte-for-byte the same as the original patch. I checked it in, and then immediately saw in http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6515 that Yidong says he checked it in as well. But oddly, my trunk (which is bound to master trunk) doesn't have the change, even after updating. I'm not sure what's going on with that, but in any case the change is certainly installed in trunk now, because http://bzr.savannah.gnu.org/r/emacs/trunk/.bzr/branch/last-revision currently says: 100717 kfogel@red-bean.com-20100704195702-mbiefzxkbx7dgsby ...which is the change I checked in. Thanks for pointing out this bug! -Karl