From: Karl Fogel <kfogel@red-bean.com>
To: Christoph <cschol2112@googlemail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Patch for bug #6515: unneeded let-bound variables in bookmark.el
Date: Sun, 04 Jul 2010 19:07:25 -0400 [thread overview]
Message-ID: <87tyoeongy.fsf@kslab.red-bean.com> (raw)
In-Reply-To: <878w61xy3a.fsf@red-bean.com> (Karl Fogel's message of "Sat, 26 Jun 2010 17:50:33 -0400")
Karl Fogel <kfogel@red-bean.com> writes:
>Christoph <cschol2112@googlemail.com> writes:
>>> Find attached a bugfix for bug #6515
>>> (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6515) for review.
>>
>>Sorry, this was intended to go to the bug tracker.
>
>Actually, I'm glad you sent it here. IMHO, the patch is small enough
>and trivial enough to go in regardless of assignment papers -- a mere
>description of the problem would suffice to cause any reasonable
>programmer to generate the exact same patch, if my understanding is
>correct (I haven't looked at it in depth yet, but will soon).
I clean-roomed it (because I wasn't sure it was small enough to not
worry about papers), and of course the result was byte-for-byte the same
as the original patch. <shrug>
I checked it in, and then immediately saw in
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6515
that Yidong says he checked it in as well. But oddly, my trunk (which
is bound to master trunk) doesn't have the change, even after updating.
I'm not sure what's going on with that, but in any case the change is
certainly installed in trunk now, because
http://bzr.savannah.gnu.org/r/emacs/trunk/.bzr/branch/last-revision
currently says:
100717 kfogel@red-bean.com-20100704195702-mbiefzxkbx7dgsby
...which is the change I checked in.
Thanks for pointing out this bug!
-Karl
next prev parent reply other threads:[~2010-07-04 23:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-26 21:43 Patch for bug #6515: unneeded let-bound variables in bookmark.el Christoph
2010-06-26 21:46 ` Christoph
2010-06-26 21:50 ` Karl Fogel
2010-07-04 23:07 ` Karl Fogel [this message]
2010-07-04 23:27 ` Christoph
2010-07-04 23:44 ` Karl Fogel
2010-07-05 22:48 ` Glenn Morris
2010-07-06 1:10 ` Karl Fogel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tyoeongy.fsf@kslab.red-bean.com \
--to=kfogel@red-bean.com \
--cc=cschol2112@googlemail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).