From: Chong Yidong <cyd@stupidchicken.com>
To: Jambunathan K <kjambunathan@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] package-x.el: package-upload-buffer-internal
Date: Mon, 01 Nov 2010 11:45:43 -0400 [thread overview]
Message-ID: <87tyk1rqs8.fsf@stupidchicken.com> (raw)
In-Reply-To: <81pquvqtms.fsf@gmail.com> (Jambunathan K.'s message of "Thu, 28 Oct 2010 01:45:55 +0530")
Jambunathan K <kjambunathan@gmail.com> writes:
> 1. M-x package-upload-file currently downloads 'archive-contents' from a
> remote location and writes back the updated file to
> package-archive-upload-base. This seems inconsistent to me. The
> attached fix addresses this inconsistency.
Thanks for the patch, but could you explain why you think the current
behavior is inconsistent? The reason it downloads archive-contents is
that the local copy might be out of date. Before changing
archive-contents, it should be necessary to make sure you're working on
the most recent copy.
By the way, in the future, please post context diffs ("diff -c", or use
the diff utilities built into Emacs). I find it difficult to read the
diff you sent. Thanks.
next prev parent reply other threads:[~2010-11-01 15:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 20:15 [PATCH] package-x.el: package-upload-buffer-internal Jambunathan K
2010-11-01 15:45 ` Chong Yidong [this message]
2010-11-01 16:35 ` Jambunathan K
2010-11-01 21:39 ` Chong Yidong
2010-11-02 2:03 ` Jambunathan K
2011-02-04 5:29 ` Jambunathan K
2011-02-04 5:29 ` Jambunathan K
2010-11-01 18:16 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tyk1rqs8.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=kjambunathan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).