unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Tassilo Horn <tsdh@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: Ingo Lohmar <i.lohmar@gmail.com>, emacs-devel@gnu.org
Subject: Re: include new package wconf.el in GNU ELPA
Date: Fri, 31 Jul 2015 10:27:45 +0200	[thread overview]
Message-ID: <87twskhgu6.fsf@gnu.org> (raw)
In-Reply-To: <55BB1F61.7030104@gmx.at> (martin rudalics's message of "Fri, 31 Jul 2015 09:10:25 +0200")

martin rudalics <rudalics@gmx.at> writes:

>> I had a look at the corresponding code in emacs, and actually the
>> restoration of point is not done in `set-window-configuration' but
>> instead it's done afterwards in `jump-to-register', in `winner-set', and
>> probably other places as well.
>
> I didn't look into these.  But do they really change a buffer's point?
> Or do they change a window's point (aka `window-point').

They use `goto-char' in the window which is selected after setting the
window configuration, so I guess it's the buffer's point.

BTW, my advice was completely broken.  Here is a better version:

--8<---------------cut here---------------start------------->8---
(defun th/window-config-keep-points-and-selected-window (old config)
  (let ((bufpoints (mapcar
		    (lambda (buf)
		      (cons buf (with-selected-window (get-buffer-window buf)
				  (point))))
		    (cl-remove-if-not #'get-buffer-window
				      (buffer-list (selected-frame)))))
	(selected-buf (current-buffer)))
    (funcall old config)
    ;; Restore selected window
    (when-let ((w (get-buffer-window selected-buf)))
      (select-window w))
    ;; The setting of point is not performed by `set-window-configuration'
    ;; itself but by `jump-to-register' or the winner functions.
    (run-with-timer 0.139 nil
		    (lambda ()
		      (dolist (bp bufpoints)
			(let ((buf (car bp))
			      (p   (cdr bp)))
			  (when-let ((w (get-buffer-window buf)))
			    (with-selected-window w
			      (goto-char p)))))))))

(advice-add #'set-window-configuration :around
	    #'th/window-config-keep-points-and-selected-window)
--8<---------------cut here---------------end--------------->8---

But that's also really bad.  For example, `edebug' uses
`set-window-configuration' internally, so point always jumps back after
each edebug step.

Seems like I can't achieve what I'm looking for too easily.

Bye,
Tassilo



  reply	other threads:[~2015-07-31  8:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-30 15:31 include new package wconf.el in GNU ELPA Ingo Lohmar
2015-07-30 18:57 ` Dmitry Gutov
2015-07-30 19:17 ` Tassilo Horn
2015-07-30 20:58   ` Ingo Lohmar
2015-07-31  5:35     ` Tassilo Horn
2015-07-31  7:10       ` martin rudalics
2015-07-31  8:27         ` Tassilo Horn [this message]
2015-07-31  9:56           ` martin rudalics
2015-07-31 13:39             ` Tassilo Horn
2015-08-01 10:50               ` martin rudalics
2015-08-03  7:45                 ` Tassilo Horn
2015-07-31  9:24       ` Ingo Lohmar
2015-07-31  7:10   ` martin rudalics
2015-07-31  8:37     ` Tassilo Horn
2015-07-31  9:56       ` martin rudalics
2015-07-31 13:56         ` Tassilo Horn
2015-08-01 10:50           ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87twskhgu6.fsf@gnu.org \
    --to=tsdh@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=i.lohmar@gmail.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).