unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: David Engster <deng@randomsample.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: eggert@cs.ucla.edu, bruce.connor.am@gmail.com, emacs-devel@gnu.org
Subject: Re: When do we merge the commits from emacs-25 onto master?
Date: Tue, 24 Nov 2015 20:33:24 +0100	[thread overview]
Message-ID: <87twobfb0b.fsf@isaac.fritz.box> (raw)
In-Reply-To: <83twobxn7e.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 24 Nov 2015 20:32:37 +0200")

Eli Zaretskii writes:
>> From: David Engster <deng@randomsample.de>
>> Date: Mon, 23 Nov 2015 23:43:21 +0100
>> Cc: Paul Eggert <eggert@cs.ucla.edu>, emacs-devel <emacs-devel@gnu.org>
>> 
>> We still haven't figured out how to deal with the generated ChangeLogs,
>> so I'm not sure we should merge at the moment.
>
> Would it work to somehow teach gitmerge.el to use the (fixed) text
> from ChangeLog.2 as the merge-commit log message, instead of the
> original log message at emacs-25 commit time?

I'm not entirely sure what you mean, but the original commits will enter
'master' through the merge, so gitlog-to-changelog will generate entries
for them.

I think at first we must decide between two options:

i) Generate ChangeLog.2 separately for the two branches and exclude it
   from merges.

ii) Devise some workflow which will allow to merge ChangeLog.2 from
   emacs-25 into master. Cherry-picks from master to emacs-25 are also a
   problem, obviously, but they will comprise far less commits
   (hopefully), so I think it's OK if they involve more work.

Option i) is simple, but will create more work for the people fixing the
ChangeLogs. Most importantly, when emacs-25 is merged into master, all
the ChangeLogs will have to be fixed again. It will be easier if merging
and ChangeLog-fixing is done at the same time by one person, since then
one can pretty much copy&paste, but I'm not sure how realistic that
is.

We could also do an extreme version of i): only create ChangeLog.2 for
emacs-25 once, immediately before the release. We will have fixed
ChangeLogs for all the commits already in master; the job is then to
extract only those which are in emacs-25. Maybe gitlog-to-changelog
could mark those commits with a special string? We could remove that
mark again when emacs 25.1 is released.

I already described one workflow for ii) in the other thread. Different
workflows are possible, of course, but I'd claim they all will be of the
same complexity.

-David



  reply	other threads:[~2015-11-24 19:33 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-23 20:36 When do we merge the commits from emacs-25 onto master? Artur Malabarba
2015-11-23 20:51 ` Eli Zaretskii
2015-11-23 22:05 ` Paul Eggert
2015-11-23 22:34   ` Artur Malabarba
2015-11-23 22:43     ` David Engster
2015-11-24 14:25       ` ChangeLog and the release branch (was: When do we merge the commits from emacs-25 onto master?) Artur Malabarba
2015-11-24 13:29         ` ChangeLog and the release branch Dmitry Gutov
2015-11-24 16:24         ` ChangeLog and the release branch (was: When do we merge the commits from emacs-25 onto master?) Eli Zaretskii
2015-11-26 21:07           ` ChangeLog and the release branch Yagnesh Raghava Yakkala
2015-11-27  7:26             ` Eli Zaretskii
2015-11-28 11:50               ` David Engster
2015-11-28 12:14                 ` Eli Zaretskii
2015-11-28 12:36                   ` David Engster
2015-11-28 19:15                     ` John Wiegley
2015-11-24 18:32       ` When do we merge the commits from emacs-25 onto master? Eli Zaretskii
2015-11-24 19:33         ` David Engster [this message]
2015-11-24 19:46         ` Paul Eggert
2015-11-24 20:14           ` Eli Zaretskii
2015-11-24 22:04             ` Paul Eggert
2015-11-25  0:35               ` David Engster
2015-11-25  6:32                 ` Paul Eggert
2015-11-25 18:18                   ` Eli Zaretskii
2015-11-25 18:16                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87twobfb0b.fsf@isaac.fritz.box \
    --to=deng@randomsample.de \
    --cc=bruce.connor.am@gmail.com \
    --cc=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).