From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 71783e9: Add the string-numeric-lessp function Date: Sun, 21 Feb 2016 15:43:51 +1100 Message-ID: <87twl2fzaw.fsf@gnus.org> References: <20160221043348.25201.81719@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456029909 997 80.91.229.3 (21 Feb 2016 04:45:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 21 Feb 2016 04:45:09 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 21 05:44:55 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aXLt7-0002Rc-8N for ged-emacs-devel@m.gmane.org; Sun, 21 Feb 2016 05:44:53 +0100 Original-Received: from localhost ([::1]:37982 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXLt3-00065C-6D for ged-emacs-devel@m.gmane.org; Sat, 20 Feb 2016 23:44:49 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXLsm-000650-47 for emacs-devel@gnu.org; Sat, 20 Feb 2016 23:44:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXLsi-0001SQ-CV for emacs-devel@gnu.org; Sat, 20 Feb 2016 23:44:32 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:36637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXLsi-0001SH-5a for emacs-devel@gnu.org; Sat, 20 Feb 2016 23:44:28 -0500 Original-Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aXLsE-0006fv-JK for emacs-devel@gnu.org; Sun, 21 Feb 2016 05:43:59 +0100 In-Reply-To: (Lars Ingebrigtsen's message of "Sun, 21 Feb 2016 04:33:48 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aXLsE-0006fv-JK MailScanner-NULL-Check: 1456634640.46837@Yk37aM3+wNDFKUonJ0y2JQ X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200360 Archived-At: Lars Ingebrigtsen writes: Ok, this is now implemented: > +DEFUN ("string-numeric-lessp", Fstring_numeric_lessp, Replete with tests. Feel free to change the name, implementation, or anything else. :-) Particularly this: > + /* If we're still in a number, add it to the sum and continue. */ > + /* FIXME: Integer overflow? */ > + if (c >= '0' && c <= '9') > + { > + number = number * 10; > + number += c - '0'; > + (*isp)++; > + (*isp_byte) += chlen; > + } > + else > + break; > + } There has to be a simple way to do that check... hm... I see that `string-to-number' uses strtoumax... Hm... perhaps I can rewrite this function to use that instead... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no