From: Lars Ingebrigtsen <larsi@gnus.org>
To: emacs-devel@gnu.org
Subject: Re: master 71783e9: Add the string-numeric-lessp function
Date: Sun, 21 Feb 2016 15:43:51 +1100 [thread overview]
Message-ID: <87twl2fzaw.fsf@gnus.org> (raw)
In-Reply-To: <E1aXLiO-0006ZB-4R@vcs.savannah.gnu.org> (Lars Ingebrigtsen's message of "Sun, 21 Feb 2016 04:33:48 +0000")
Lars Ingebrigtsen <larsi@gnus.org> writes:
Ok, this is now implemented:
> +DEFUN ("string-numeric-lessp", Fstring_numeric_lessp,
Replete with tests. Feel free to change the name, implementation, or
anything else. :-)
Particularly this:
> + /* If we're still in a number, add it to the sum and continue. */
> + /* FIXME: Integer overflow? */
> + if (c >= '0' && c <= '9')
> + {
> + number = number * 10;
> + number += c - '0';
> + (*isp)++;
> + (*isp_byte) += chlen;
> + }
> + else
> + break;
> + }
There has to be a simple way to do that check... hm... I see that
`string-to-number' uses strtoumax... Hm... perhaps I can rewrite this
function to use that instead...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next parent reply other threads:[~2016-02-21 4:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160221043348.25201.81719@vcs.savannah.gnu.org>
[not found] ` <E1aXLiO-0006ZB-4R@vcs.savannah.gnu.org>
2016-02-21 4:43 ` Lars Ingebrigtsen [this message]
2016-02-21 5:36 ` master 71783e9: Add the string-numeric-lessp function Lars Ingebrigtsen
2016-02-21 6:15 ` Stephan Mueller
2016-02-21 10:02 ` Lars Ingebrigtsen
2016-02-21 19:35 ` Yuri Khan
2016-02-22 2:51 ` Lars Ingebrigtsen
2016-02-22 17:59 ` Richard Stallman
2016-02-21 21:30 ` Paul Eggert
2016-02-22 1:32 ` Andy Moreton
2016-02-22 4:01 ` Paul Eggert
2016-02-22 16:11 ` Eli Zaretskii
2016-02-22 2:53 ` Lars Ingebrigtsen
2016-02-22 3:50 ` Paul Eggert
2016-02-22 4:00 ` Lars Ingebrigtsen
2016-02-22 4:16 ` Paul Eggert
2016-02-22 4:22 ` Lars Ingebrigtsen
2016-02-22 5:56 ` Paul Eggert
2016-03-07 0:16 ` Juri Linkov
2016-03-07 0:53 ` Paul Eggert
2016-03-07 17:45 ` Richard Stallman
2016-03-07 17:49 ` Lars Magne Ingebrigtsen
2016-03-07 23:55 ` Juri Linkov
2016-03-07 23:52 ` Juri Linkov
2016-03-08 2:06 ` Paul Eggert
2016-03-08 9:26 ` Andreas Schwab
2016-03-09 9:26 ` Paul Eggert
2016-03-07 2:27 ` Drew Adams
2016-03-07 21:14 ` Johan Bockgård
2016-03-07 22:03 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twl2fzaw.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).