From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: Is it time to drop ChangeLogs? Date: Thu, 07 Jul 2016 17:28:23 +0100 Message-ID: <87twg12z14.fsf@russet.org.uk> References: <56BE7E37.3090708@cs.ucla.edu> <4hd1rw1ubr.fsf@fencepost.gnu.org> <83vb50wxhv.fsf@gnu.org> <87y49vz4cg.fsf@acer.localhost.com> <87twg2g86g.fsf@lifelogs.com> <83eg76n5h5.fsf@gnu.org> <87y45eeoor.fsf@lifelogs.com> <577D42BB.1020500@cs.ucla.edu> <87oa694rfw.fsf@russet.org.uk> <87k2gx4ng3.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1467909658 22962 80.91.229.3 (7 Jul 2016 16:40:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 7 Jul 2016 16:40:58 +0000 (UTC) Cc: Paul Eggert , Emacs developers To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 07 18:40:49 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bLCM4-0002Di-UO for ged-emacs-devel@m.gmane.org; Thu, 07 Jul 2016 18:40:49 +0200 Original-Received: from localhost ([::1]:41178 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLCM4-0006yC-5x for ged-emacs-devel@m.gmane.org; Thu, 07 Jul 2016 12:40:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLCAA-0001CI-78 for emacs-devel@gnu.org; Thu, 07 Jul 2016 12:28:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLCA5-0006sS-8p for emacs-devel@gnu.org; Thu, 07 Jul 2016 12:28:29 -0400 Original-Received: from cloud103.planethippo.com ([31.216.48.48]:47734) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLCA4-0006sO-UD for emacs-devel@gnu.org; Thu, 07 Jul 2016 12:28:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From; bh=4UqzvylreAE9r98NoHBRkyQOtxVwzFQNHbMhBcbtIzs=; b=tCFpwDmbtH56TbWmKE44aBy1wV /JwA3L2FQ+LurFIAeEeOtkrJb1+r6nERNkkREuBYDyhkTYnl7kE2/Aii8kNlKVJoj5VnNCAejurs0 B4PqKZo3q9Cj+831MAuH2wZUGAeicYnIxh5vxft51FZYAZVJ3Ms6nC1yW46U52x80ALSeQFManJgn sspNNsu2CmxJdKs8o9sf50JBCNPCmFbUThmHjgUk+78tesdIrGlRNx8HIFAyws3a8Tdgl9a8rGC1+ HveBBucpzFDJWRJCIlLUa4iNindBAcLClfKhatsooiWUwu3UcTcsPOznIKEWzIhwFR+Q2YvbkFJVg Hv0khiSQ==; Original-Received: from janus-nat-128-240-225-60.ncl.ac.uk ([128.240.225.60]:32706 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.86_1) (envelope-from ) id 1bLCA4-001427-16; Thu, 07 Jul 2016 17:28:24 +0100 In-Reply-To: (Noam Postavsky's message of "Thu, 7 Jul 2016 09:15:25 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 31.216.48.48 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205353 Archived-At: Noam Postavsky writes: >>> I've been sending patches to bug threads, and often getting useful >>> feedback on them (and since it's by email, the comments can easily be >>> inline). Personally, I don't find it more clunky than pushing to a >>> branch, and then opening a PR in a web browser. >> >> This is true for the first patch, but not true for additional commits. > > Yeah, you're right about that. Most of my Emacs patches so far have > been small enough that it didn't really bother me too much. Indeed. And there are many patches to emacs which affect one small part of Emacs. No worries. I don't think it's necessarily the case that all changes should go through PR. It depends on the experience of the developer and the criticality of the code. >From my own perspective, I like code review, and would always be happy to have feedback on my code, but that many not be possible. >>> Yes, some patches are forgotten, but I don't see how a PR "system" >>> makes that less likely to happen, e.g., cask has a bunch of open PRs >>> sitting around: https://github.com/cask/cask/pulls. >> >> I think you have just demonstrated my point. You found out all the >> outstanding ones also. >> >> >>>> Perhaps, as a half way house, we could use the resources that we have. >>>> PRs could go to the bug reporting system. This will, at least, keep all >>>> the conversations in one place. If we can tag these with "has patch" >>>> here as well, it will give an queue also. >>> >>> I thought that was the current system. Here is the queue: >>> http://debbugs.gnu.org/cgi/pkgreport.cgi?package=emacs;include=tags%3Apatch;bug-rev=on >> >> Again, also my point. > > If your point is that there are more open patches in Emacs than cask, > IMO that's mostly because Emacs is a larger and older project. No, sorry, I was being opaque. Having a nice queue system is a good thing, and we could use debbugs to do pull requests also, was my point. Phil