From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] url: Wrap cookie headers in url-http--encode-string. Date: Wed, 07 Sep 2016 22:49:30 +0200 Message-ID: <87twdrigf9.fsf@toke.dk> References: <20160907153014.15752-1-toke@toke.dk> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1473281406 31210 195.159.176.226 (7 Sep 2016 20:50:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 7 Sep 2016 20:50:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 07 22:49:57 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhjnA-0006tN-ON for ged-emacs-devel@m.gmane.org; Wed, 07 Sep 2016 22:49:56 +0200 Original-Received: from localhost ([::1]:42959 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhjn8-0007W3-NS for ged-emacs-devel@m.gmane.org; Wed, 07 Sep 2016 16:49:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhjmx-0007Vs-FV for emacs-devel@gnu.org; Wed, 07 Sep 2016 16:49:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhjms-0005Wz-3B for emacs-devel@gnu.org; Wed, 07 Sep 2016 16:49:42 -0400 Original-Received: from mail2.tohojo.dk ([77.235.48.147]:48940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhjmr-0005Wb-Pr for emacs-devel@gnu.org; Wed, 07 Sep 2016 16:49:38 -0400 X-Virus-Scanned: amavisd-new at mail2.tohojo.dk DKIM-Filter: OpenDKIM Filter v2.10.3 mail2.tohojo.dk 0C9AC40D5E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=201310; t=1473281371; bh=Gc/Y3CjTpq90MhFg0buk405FZSJZW0jQ3E1mbyoLaNs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=bZ19BHIqRygCQh+JNoLtzz/CKiCBekVtuwi3PWPdAJYNba/75iIdQ1D1OsBbymW9y YZi5DyYuvDgE+5clkR9+h1q1z8gdP6DcBT5X6XAGwbMTrl/UgkgKWQ4vK/FqgsaTA5 eaYSqbAF6/MRmfG3Xzo8Mg/CHR7533+71C+tYOs8= Original-Received: by alrua-kau.kau.toke.dk (Postfix, from userid 1000) id 177C2C4027D; Wed, 7 Sep 2016 22:49:30 +0200 (CEST) In-Reply-To: (Lars Ingebrigtsen's message of "Wed, 07 Sep 2016 21:14:10 +0200") X-Clacks-Overhead: GNU Terry Pratchett X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.235.48.147 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207279 Archived-At: Lars Ingebrigtsen writes: > Toke H=C3=B8iland-J=C3=B8rgensen writes: > >> In some cases the output of url-cookie-generate-header can be multibyte, >> which will trip the length check that was added at the end of >> url-http-create-request. > > I think that test should be removed so that Emacs 25.1 can be released > (with the same level of workingness that that function has in Emacs > 24.4). > > It was a mistake to add that test to Emacs 25. > > And then these things can be worked on for the next release. Fine with me :) -Toke